New issue
Advanced search Search tips

Issue 681517 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Thumbnails of files on media views are broken in quick view

Project Member Reported by nya@chromium.org, Jan 16 2017

Issue description

When I open quick views for media files on media views, thumbnails are broken (broken <img> tag is shown).

This is also the case with MTP.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d72441d795c9e7a397c96ddbb79409e22fc73ea3

commit d72441d795c9e7a397c96ddbb79409e22fc73ea3
Author: nya <nya@chromium.org>
Date: Tue Jan 17 12:15:14 2017

Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on
DRIVE or PROVIDED volumes (see MultiMetadataProvider.prototype.get()),
so this patch changes behavior only on MTP, MEDIA_VIEW volumes.

BUG= 681517 
TEST=Broken <img> is not shown in MTP and media views.
TEST=Preview works on Drive, Downloads, ZIP archive and RAR archive.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2633053003
Cr-Commit-Position: refs/heads/master@{#444032}

[modify] https://crrev.com/d72441d795c9e7a397c96ddbb79409e22fc73ea3/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/d72441d795c9e7a397c96ddbb79409e22fc73ea3/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

Comment 2 by nya@chromium.org, Jan 17 2017

Status: Fixed (was: Started)

Comment 3 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Status: Assigned (was: Fixed)
Quick preview doesn't work for media files in ZIP archive.

Build: 9460.5.0, 59.0.3071.15

Comment 6 by nya@chromium.org, Apr 25 2017

Status: Fixed (was: Assigned)
Thanks for testing!

But if you mean "no preview available", it's different from this issue (this bug is for broken thumbnails). No preview issue is tracked in  Issue 685315 .

Status: Verified (was: Fixed)
Thanks nya@

Verified on 9460.5.0, 59.0.3071.15

Sign in to add a comment