New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 681498 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Oct 5
Cc:
yyushkina@chromium.org
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
michae...@chromium.org
█ ranjitkan@chromium.org
█ claudiomagni@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

[MD Settings] Relaunch button not shown for new UI language after reloading the page

Reported by dchau...@etouch.net, Jan 16 2017 
Chrome Version: Chrome Version: 57.0.2983.0 (Official Build) 266a86c94d34f3c7c3d22ee00624636b801f80d3-refs/heads/master@{#443819} 32/64-bit.
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings page and go to 'Language' section.
2. Add Hindi language from 'Add languages' overlay and click on three dot icon to open menu list.
3. Select 'Display Google Chrome in this language' option from menu list('RELAUNCH' button will displayed).
4. Reload the page, again go to 'Languages' section, expand it and observe the Hindi language section.

'RELAUNCH' button disappears from Hindi language section.
'RELAUNCH' button should display under Hindi language section.

This is a regression issue, broken in M-57 series, below is manual regression range.

Good build: 57.0.2951.0
Bad builds: 57.0.2952.0

Note: This issue is not seen on 'Mac' and 'Linux' OS.

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
1.6 MB View Download
Expected behavior.mp4
1.3 MB View Download

Comment 1 by kkaluri@chromium.org, Jan 16 2017

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: michae...@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 57.0.2951.0,  Revision Range - 438385
Bad build  : 57.0.2952.0,  Revision Range - 438707

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/b6f207ca201f3eb08c2150f5c3610c68a30c8984..4cb2126002cd187035ba90ee13ebda77e16d81f6

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/4cb2126002cd187035ba90ee13ebda77e16d81f6

From the above CL suspecting the below change
---------------------------
Review-Url: https://codereview.chromium.org/2573643005

michaelpg@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 2 by michae...@chromium.org, Jan 18 2017

Labels: -Pri-1 -Type-Bug-Regression OS-Chrome Pri-3 Type-Bug
Summary: [MD Settings] Relaunch button not shown for new UI language after reloading the page (was: Regression:[MD Settings]'RELAUNCH' button disappears after reloading the page.)
Options has a similar bug. It's hard to know whether a restart is needed, because for some locales, the user's preference might *not* match the application locale. So we incorrectly showed Restart sometimes ( bug 561227 ). The fix for that gave us this bug.

Since Options has this issue (actually worse, because Options doesn't even show the correct selected language) and it's not obvious how to fix it, marking Pri-3 and non-regression.

Comment 3 by michae...@chromium.org, Oct 4 2017

Cc: yyushkina@chromium.org claudiomagni@chromium.org michae...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Bulk unassigning my language settings bugs as I am no longer working on Settings.
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 5

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by dpa...@chromium.org, Oct 5

Status: WontFix (was: Untriaged)
Since most users will restart as soon as they change language, I don't think is worth fixing.
►

Sign in to add a comment