New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681491 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocking:
issue 614589



Sign in to add a comment

Regression : Unnecessary Space is seen between Options of 'Privacy and security' in chrome://md-settings of Guest

Project Member Reported by mmanchala@chromium.org, Jan 16 2017

Issue description

Chrome Version:  57.0.2982.0/9188.0.0 dev channel Gnawty,Parrot and Spring
OS: Chrome

What steps will reproduce the problem?
(1)Browse as guest ->Go to chrome://md-settings page
(2)Now Click on 'Main menu' at L.H.S -> click on 'Advanced' -> select  
Privacy and security'
(3)Now observe Unnecessary Space between Options(Please refer screenshot)

Expected: No space should be seen between options
Actual: Instead Unnecessary Space is seen between Options

This is Regression Issue as same is working fine in 57.0.2978.0/9178.0.0 dev-channel Daisy
 
Actual_space.jpg
102 KB View Download
Expected.jpg
101 KB View Download
Blocking: 614589
Cc: dbeam@chromium.org steve...@chromium.org
We are hiding these <settings-toggle-button>s in Guest mode but not hiding the rows they're contained in.

Comment 2 by dbeam@chromium.org, Jan 18 2017

Owner: dbeam@chromium.org
Status: Started (was: Untriaged)
https://codereview.chromium.org/2636383002
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d6d6df8d9dd312483bfda4c6db5d5afcdfc217e

commit 2d6d6df8d9dd312483bfda4c6db5d5afcdfc217e
Author: dbeam <dbeam@chromium.org>
Date: Wed Jan 18 15:42:46 2017

MD Settings: hide rows (rather than row contents) for some custom toggles in privacy

R=michaelpg@chromium.org
BUG= 681491 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2636383002
Cr-Commit-Position: refs/heads/master@{#444370}

[modify] https://crrev.com/2d6d6df8d9dd312483bfda4c6db5d5afcdfc217e/chrome/browser/resources/settings/privacy_page/privacy_page.html

Comment 4 by dbeam@chromium.org, Jan 19 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9270.0.0/58.0.3007.0

Sign in to add a comment