New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681487 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Cursor is not visible after hitting 'Spacebar' for PDF page after adding 'PDF viewer' extension.

Reported by rk...@etouch.net, Jan 16 2017

Issue description

Chrome Version: 57.0.2983.0 Revision 266a86c94d34f3c7c3d22ee00624636b801f80d3-refs/heads/master@{#443819}
OS: Windows(7,8,10),Linux (14.04 LTS)

URL: https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm?utm_source=chrome-app-launcher-info-dialog
 
What steps will reproduce the problem?
(1) Launch chrome, navigate to above url and click on 'ADD TO CHROME'
(2) Then navigate to any PDF file(eg.www.orimi.com/pdf-test.pdf), click on extension icon.
(3) Hitt Spacebar and observe.

Actual: Nothing is happened after hitting Spacebar i.e. Cursor is not visible.

Expected: Cursor should be seen after hitting Spacebar.

This is a regression issue, broken in 'M-57', will soon update the other info:

Good Build: 57.0.2979.0
Bad Build: 57.0.2980.0

Note: Issue is not seen on Mac OS.
 
Actual_Cursor.mp4
594 KB View Download
Expected_Cursor.mp4
300 KB View Download

Comment 1 by hdodda@chromium.org, Jan 16 2017

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision M-57
Owner: yosin@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build: 57.0.2979.0 (revision : 443120)
Bad Build: 57.0.2980.0 (revision : 443474)

You are probably looking for a change made after 443188 (known good), but no later than 443189 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/2dcda31b3f6d9e8cf588f0c233d9c8c7cb9b4521..c5138fa204cedceffaf7a7e777529a9a5d69964c

From the CL above, assigning the issue to the concern owner 

@yosin - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2628763003

Thanks!
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by ajha@chromium.org, Jan 23 2017

Cc: yoichio@chromium.org
Issue is still reproducible on the latest M-57 branched build(57.0.2987.6). Friendly ping to get an update on this.
yosin@ Since this issue is marked as RB-Stable, could you please let us know is there any latest update available for this issue.

Thanks!
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Able to reproduce this issue on Windows-7 using chrome latest Dev 58.0.3012.0.

yosin@ We're getting closer to M57 early stable launch and this issue is marked as RB-Stable, so can we get any latest update on this issue? 

Thanks!

Comment 7 by yosin@chromium.org, Feb 15 2017

Owner: brajkumar@chromium.org
My patch doesn't affect focus change. Rather my patch checks focus.

Comment 8 by gov...@chromium.org, Feb 16 2017

A friendly reminder that M57 Stable is launch is coming VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Comment 9 by gov...@chromium.org, Feb 22 2017


URGENT - PTAL ASAP.

We're getting VERY close to M57 Stable promotion. And 
this issue is marked as M57 stable release blocker. Pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion).

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M58.

Thank you.
Labels: -hasbisect-per-revision Needs-Bisect
Owner: rk...@etouch.net
While performing per-revision bisect getting the same suspect as mentioned in the comment #1.

rkote@ Could you please check the same and provide chromium bisect from your end?

Thanks!
Components: -Internals>Plugins>PDF
This is not the internal PDF viewer, it's an extension which displays PDFs as HTML5. Removing the Internals>Plugins>PDF label.
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 22 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "rkote@etouch.net" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: rdevlin....@chromium.org
rdevlin.cronin@, could you ptal please? 
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)
The bisect from #1 is correct; I've confirmed that reverting it locally changes the behavior.  This also makes sense with the cl description, "Keyboard event should not insert a character at selection if selection doesn't have focus".  We would previously insert characters into the text field even if the field didn't have focus, and yosin@'s patch changed that behavior.

It may be that the new behavior is desired; I'll leave that up to others to decide.

Comment 15 by yosin@chromium.org, Feb 24 2017

Owner: ----
Status: WontFix (was: Assigned)
Yes, this is expected behavior both logical, compatible to other browsers and W3C UI Event spec[1].


[1] https://www.w3.org/TR/uievents/

Sign in to add a comment