Layout Test paint/invalidation/media-audio-no-spurious-repaints.html is flaky |
||||
Issue descriptionThe following layout tests are flaky paint/invalidation/media-audio-no-spurious-repaints.html virtual/stable/paint/invalidation/media-audio-no-spurious-repaints.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=paint%2Finvalidation%2Fmedia-audio-no-spurious-repaints.html
,
Jan 17 2017
,
Jan 17 2017
Assigning to the original author of the test.
,
Mar 15 2017
Not sure why the bot didn;t pick it up, but fixed by Make layout test media-audio-no-spurious-repaints.html pass The number of invalidations has doubled in some cases. None of the changes I could see to the MediaControls shadow DOM seem to have caused this, so I cannot explain why the increase happened. But it has, and a couple more repaints doesn't seem like a major problem. TBR=wangxianzhu@chromium.org BUG= 681471 Review-Url: https://codereview.chromium.org/2754533002 Cr-Commit-Position: refs/heads/master@{#456855} Committed: https://chromium.googlesource.com/chromium/src/+/d1df3ad6b707ae3bfff924a4674207e4772cd5fa
,
Mar 16 2017
The point of the original change was to avoid power regressions due to spurious repaints of a plain audio element. If it's a total fixed number more that's probably okay, but if it's fixed multiple per second then it's probably worth reexamining to see if power usage has changed since this regressed.
,
Mar 16 2017
I looked back for a cause in the media code and could find none. There's been enormous churn in invalidation code recently so it is probably due to that. We have plenty of checks in place to catch regressions due to those invalidation changes, and any change for this particular scenario will likely show up as a contributor to a larger behavior change. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jan 16 2017