New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681469 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to unlock, add or delete user, as the main user is unable to sign in to locked profile.

Reported by yfulgaon...@etouch.net, Jan 16 2017

Issue description

Chrome Version : 57.0.2982.0 (Official Build) 4180b2e34325e450db3d4feb3c09b58ced38e98a-refs/heads/master@{#443804} 32/64 bit
OS : Mac(10.12.1, 10.11.6, 10.12), Windows(7,8,10)

Precondition: Sign in to chrome.

What steps will reproduce the problem?
1. Launch chrome, go to ‘chrome://settings', from ‘People’ section add a Supervised user and switch to supervised user.
2. Now close the supervised user window (user switch to ‘Parent user’) and in parent user click on avatar icon and select ‘Exit and childlock’ option.
3. In Switch person window, click on locked profile and observe the sign in overlay.

Actual : Unable to unlock, add or delete user, as user unable to sign in to locked profile.
Expected : User should be able to sign in to locked user.

This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info.
Good build : 57.0.2978.0
Bad build : 57.0.2979.0
 
Actual_signin_overlay.mov
8.9 MB Download
Expected_signin.mov
7.6 MB Download
Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: msarda@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 57.0.2978.0,  Revision Range -442756
Bad build  : 57.0.2979.0,  Revision Range -443120

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/87f7645fd8cf2ce0c2a6964a5b9674b875063319..a80bb6a60810ca919a1d01bc391716c040070b4f


The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/a80bb6a60810ca919a1d01bc391716c040070b4f

From the above CL suspecting the below change
---------------------------
Review-Url: https://codereview.chromium.org/2621083002

msarda@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner
Labels: OS-Linux
Update : Above issue is also seen on Linux 14.04 LTS OS.

Comment 3 by msarda@chromium.org, Jan 16 2017

Cc: mahmadi@chromium.org
CC+ Mohamad

This is very probably related to my CL. I did not know that in that case the user is signing in to an incognito profile. I'll take a look this afternoon.


Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ec1c6df6c10a2eb6911dcf6aa01b5ffcfe6eabe

commit 5ec1c6df6c10a2eb6911dcf6aa01b5ffcfe6eabe
Author: msarda <msarda@chromium.org>
Date: Tue Jan 17 19:23:12 2017

Allow load of the chrome://chrome-signin in incognito profile

This CL allows to load the chrome://chrome-signin URL in incognito
profiles as this is used when unlocking the first time a profile.
This basically reverts the change https://codereview.chromium.org/2621083002/
for the chrome://chrome-signin URL as the assumption in that CL was
wrong.

BUG= 681469 

Review-Url: https://codereview.chromium.org/2637133002
Cr-Commit-Position: refs/heads/master@{#444107}

[modify] https://crrev.com/5ec1c6df6c10a2eb6911dcf6aa01b5ffcfe6eabe/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Comment 6 by msarda@chromium.org, Jan 17 2017

Status: Fixed (was: Assigned)
Labels: TE-Verified-M57 TE-Verified-57.0.2986.0
Tested the issue on Latest Dev# 57.0.2986.0 on Windows, Mac and Linux and is not reproducible. Hence adding TE-Verified Labels.
Adding video for further reference.

Thank You.
681469.mov
7.7 MB Download

Sign in to add a comment