New issue
Advanced search Search tips

Issue 681452 link

Starred by 1 user
Status: Fixed
Owner:
karandeepb@chromium.org
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

MacViewsBrowser build is broken.

Project Member Reported by karandeepb@chromium.org, Jan 16 2017 
Chrome Version: 57.0.2984.0
OS: Mac

What steps will reproduce the problem?
(1) Build with mac_views_browser = true.
(2) Get a build error ./../chrome/browser/ui/views/frame/browser_frame_mac.mm:28:13: error: reference to non-static member function must be called; did you mean to call it with no arguments?
  if (event.type == content::NativeWebKeyboardEvent::Char)
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c41a037768a53c4b60be748debba0347a8c10580

commit c41a037768a53c4b60be748debba0347a8c10580
Author: karandeepb <karandeepb@chromium.org>
Date: Wed Jan 18 03:32:58 2017

Fix MacViewsBrowser build.

r443407 changed the WebInputEvent class so that its "type" member variable is
accessed via a getter. However, its usage in browser_frame_mac.mm was not
updated. This CL changes the code to use the getter, hence fixing the
MacViewsBrowser build.

BUG= 681452 

Review-Url: https://codereview.chromium.org/2632863004
Cr-Commit-Position: refs/heads/master@{#444259}

[modify] https://crrev.com/c41a037768a53c4b60be748debba0347a8c10580/chrome/browser/ui/views/frame/browser_frame_mac.mm

Comment 2 by karandeepb@chromium.org, Jan 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment