New issue
Advanced search Search tips

Issue 681428 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove OutputCapture from the webkitpy codebase.

Project Member Reported by qyears...@chromium.org, Jan 16 2017

Issue description

Possible simplification in the webkitpy codebase:

OutputCapture could be removed and replaced with either LoggingTestCase.assertLog (if asserting things about logs), or asserting the contents of SystemHost.stdout if asserting about output.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c0c9992b03751b32210ea1fa5ef2513da642cdb

commit 8c0c9992b03751b32210ea1fa5ef2513da642cdb
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Jan 18 19:44:30 2017

Replace OutputCapture with LoggingTestCase in port_testcase.py

Reason: I think that this way is slightly more readable and straightforward than the way with OutputCapture.

BUG= 681428 

Review-Url: https://codereview.chromium.org/2622043004
Cr-Commit-Position: refs/heads/master@{#444441}

[modify] https://crrev.com/8c0c9992b03751b32210ea1fa5ef2513da642cdb/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ef1d5a499fa80a92b5fcfed34d175cfac981d99

commit 4ef1d5a499fa80a92b5fcfed34d175cfac981d99
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Feb 09 17:58:39 2017

Refactoring: Remove trivial uses of OutputCapture.

There are a few cases of unit tests that use OutputCapture, where use
of OutputCapture doesn't appear to make a difference when tests are run
with test-webkitpy:

    layout_tests/port/base_unittest.py
    layout_tests/run_webkit_tests_unittest.py
    tool/commands/optimize_baselines_unittest.py
    w3c/test_converter_unittest.py

BUG= 681428 

Review-Url: https://codereview.chromium.org/2680863007
Cr-Commit-Position: refs/heads/master@{#449347}

[modify] https://crrev.com/4ef1d5a499fa80a92b5fcfed34d175cfac981d99/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
[modify] https://crrev.com/4ef1d5a499fa80a92b5fcfed34d175cfac981d99/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/4ef1d5a499fa80a92b5fcfed34d175cfac981d99/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py
[modify] https://crrev.com/4ef1d5a499fa80a92b5fcfed34d175cfac981d99/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py

Labels: -Type-Bug Type-Task
Status: Archived (was: Available)

Sign in to add a comment