Remove OutputCapture from the webkitpy codebase. |
|||
Issue descriptionPossible simplification in the webkitpy codebase: OutputCapture could be removed and replaced with either LoggingTestCase.assertLog (if asserting things about logs), or asserting the contents of SystemHost.stdout if asserting about output.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ef1d5a499fa80a92b5fcfed34d175cfac981d99 commit 4ef1d5a499fa80a92b5fcfed34d175cfac981d99 Author: qyearsley <qyearsley@chromium.org> Date: Thu Feb 09 17:58:39 2017 Refactoring: Remove trivial uses of OutputCapture. There are a few cases of unit tests that use OutputCapture, where use of OutputCapture doesn't appear to make a difference when tests are run with test-webkitpy: layout_tests/port/base_unittest.py layout_tests/run_webkit_tests_unittest.py tool/commands/optimize_baselines_unittest.py w3c/test_converter_unittest.py BUG= 681428 Review-Url: https://codereview.chromium.org/2680863007 Cr-Commit-Position: refs/heads/master@{#449347} [modify] https://crrev.com/4ef1d5a499fa80a92b5fcfed34d175cfac981d99/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py [modify] https://crrev.com/4ef1d5a499fa80a92b5fcfed34d175cfac981d99/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py [modify] https://crrev.com/4ef1d5a499fa80a92b5fcfed34d175cfac981d99/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py [modify] https://crrev.com/4ef1d5a499fa80a92b5fcfed34d175cfac981d99/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
,
Aug 9 2017
,
Aug 16 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jan 18 2017