New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 681424 link

Starred by 1 user
Status: Fixed
Owner:
alancutter@chromium.org
Closed: Feb 2017
Cc:
█ suzyh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 671904
issue 442163



Sign in to add a comment

Refactor CSS Transitions to use InterpolationTypes instead of AnimatableValues

Project Member Reported by alancutter@chromium.org, Jan 16 2017 
CSS Animations and Web Animations are built on InterpolationTypes.
The AnimatableValue code path used by CSS Transitions is largely a duplication of the same logic.

CSS Transitions should be rewritten on top of InterpolationTypes instead of AnimatableValues. Doing this would help enable transitions on custom properties and reduce redundant interpolation logic in the code base.

Design doc: https://docs.google.com/document/d/14tj6M5kyNpr10dFp5m43udOMUVPwxnulBEW7Kvh2vMs/edit?usp=sharing

Comment 1 by suzyh@chromium.org, Jan 17 2017

Labels: Update-Monthly

Comment 2 by alancutter@chromium.org, Jan 18 2017

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5daf520b6c9deab9b911e19827b4216f1818ed4

commit c5daf520b6c9deab9b911e19827b4216f1818ed4
Author: alancutter <alancutter@chromium.org>
Date: Wed Jan 25 04:43:13 2017

Update interpolation testing code for compatibility with custom properties

This change to interpolation-test.js makes it possible to test animations
on custom properties. This is in preparation for adding color interpolation
to registered custom properties.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2654663007
Cr-Commit-Position: refs/heads/master@{#445948}

[modify] https://crrev.com/c5daf520b6c9deab9b911e19827b4216f1818ed4/third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aca84dc37eb032e7ed985a19597a233b6f491fcc

commit aca84dc37eb032e7ed985a19597a233b6f491fcc
Author: alancutter <alancutter@chromium.org>
Date: Mon Feb 06 02:16:32 2017

Make StyleResolverState argument a pointer in CSSInterpolationType::maybeConvertValue()

There are very few scenarios where the StyleResolverState is required
to convert a CSSValue for animations. This patch makes passing in the
state optional in preparation for supporting animations on registered
custom properties which do not need access to the StyleResolverState.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2651533005
Cr-Commit-Position: refs/heads/master@{#448203}

[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSLengthPairInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSValueInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
[modify] https://crrev.com/aca84dc37eb032e7ed985a19597a233b6f491fcc/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.h
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cd8efe88167f61d41362d233d6d2e04986f83f0

commit 3cd8efe88167f61d41362d233d6d2e04986f83f0
Author: alancutter <alancutter@chromium.org>
Date: Tue Feb 07 00:29:17 2017

Make maybeConvertStandardUnderlyingValue() take a ComputedStyle instead of StyleResolverState

This change removes the dependency on StyleResolverState from underlying
value conversion logic in CSSInterpolationType. This is in preparation
for CSS Transitions using InterpolationTypes where there's no such
StyleResolverState available to construct the InterpolationValues.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2657553003
Cr-Commit-Position: refs/heads/master@{#448464}

[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
[modify] https://crrev.com/3cd8efe88167f61d41362d233d6d2e04986f83f0/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.h
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/059255004a9e29dab9936f0527da655a148ce459

commit 059255004a9e29dab9936f0527da655a148ce459
Author: alancutter <alancutter@chromium.org>
Date: Tue Feb 07 06:51:52 2017

Move PropertyRegistry::Registration into PropertyRegistration

Before this change PropertyRegistration represented the C++ implementation
of the PropertyRegistration IDL interface and nothing else.
This patch moves the Registration class out of PropertyRegistry and merges
it with PropertyRegistration.

This change is to enable forward declarations to what was
PropertyRegistry::Registration by making it a top level class.
C++ doesn't let you forward declare inner classes.

This change is required for removing a dependency on Document in:
https://codereview.chromium.org/2654783004

BUG= 681424 

Review-Url: https://codereview.chromium.org/2676993002
Cr-Commit-Position: refs/heads/master@{#448566}

[modify] https://crrev.com/059255004a9e29dab9936f0527da655a148ce459/third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
[modify] https://crrev.com/059255004a9e29dab9936f0527da655a148ce459/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
[modify] https://crrev.com/059255004a9e29dab9936f0527da655a148ce459/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/059255004a9e29dab9936f0527da655a148ce459/third_party/WebKit/Source/core/css/PropertyRegistration.h
[modify] https://crrev.com/059255004a9e29dab9936f0527da655a148ce459/third_party/WebKit/Source/core/css/PropertyRegistry.cpp
[modify] https://crrev.com/059255004a9e29dab9936f0527da655a148ce459/third_party/WebKit/Source/core/css/PropertyRegistry.h
[modify] https://crrev.com/059255004a9e29dab9936f0527da655a148ce459/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/059255004a9e29dab9936f0527da655a148ce459/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp
[modify] https://crrev.com/059255004a9e29dab9936f0527da655a148ce459/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b556a4992cb17a53683d83d290c4b4736d1727cd

commit b556a4992cb17a53683d83d290c4b4736d1727cd
Author: alancutter <alancutter@chromium.org>
Date: Wed Feb 08 02:43:13 2017

Record PropertyRegistrations on CSSInterpolationTypes for registered custom properties

This change removes the dependency on having access to the Document's
PropertyRegistry during animation value conversion.
This is part of removing the dependency on StyleResolverState when
converting the underlying value to an animation value.
That is part of refactoring CSS Transitions to use InterpolationTypes
instead of AnimatableValues.
That is part of adding support for transitions on registered custom
properties.

This change removes the dependency on Document by storing the
PropertyRegistration on the CSSInterpolationType so that it doesn't
need to look up the registration on Document's PropertyRegistry every
time.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2654783004
Cr-Commit-Position: refs/heads/master@{#448871}

[modify] https://crrev.com/b556a4992cb17a53683d83d290c4b4736d1727cd/third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
[modify] https://crrev.com/b556a4992cb17a53683d83d290c4b4736d1727cd/third_party/WebKit/Source/core/animation/CSSInterpolationType.h
[modify] https://crrev.com/b556a4992cb17a53683d83d290c4b4736d1727cd/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
[modify] https://crrev.com/b556a4992cb17a53683d83d290c4b4736d1727cd/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.h
[modify] https://crrev.com/b556a4992cb17a53683d83d290c4b4736d1727cd/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp
[modify] https://crrev.com/b556a4992cb17a53683d83d290c4b4736d1727cd/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h
[modify] https://crrev.com/b556a4992cb17a53683d83d290c4b4736d1727cd/third_party/WebKit/Source/core/css/PropertyRegistration.cpp
[modify] https://crrev.com/b556a4992cb17a53683d83d290c4b4736d1727cd/third_party/WebKit/Source/core/css/PropertyRegistration.h
[modify] https://crrev.com/b556a4992cb17a53683d83d290c4b4736d1727cd/third_party/WebKit/Source/core/css/PropertyRegistry.cpp
[modify] https://crrev.com/b556a4992cb17a53683d83d290c4b4736d1727cd/third_party/WebKit/Source/core/css/PropertyRegistry.h
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/389b00724cc8c2699446844ff5b8718bd052349f

commit 389b00724cc8c2699446844ff5b8718bd052349f
Author: alancutter <alancutter@chromium.org>
Date: Wed Feb 08 04:49:14 2017

Remove dependency on StyleResolverState in CSSInterpolationType::maybeConvertUnderlyingValue()

In order to use CSSInterpolationTypes to drive CSS Transitions we must
remove the dependency that CSSInterpolationType::maybeConvertUnderlyingValue()
has on StyleResolverState. During CSS Transition creation there is no
StyleResolverState, only ComputedStyle objects.
This is in preparation for CSS Transitions using InterpolationTypes.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2652063003
Cr-Commit-Position: refs/heads/master@{#448908}

[modify] https://crrev.com/389b00724cc8c2699446844ff5b8718bd052349f/third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
[modify] https://crrev.com/389b00724cc8c2699446844ff5b8718bd052349f/third_party/WebKit/Source/core/animation/InterpolationEnvironment.h

Comment 9 by alancutter@chromium.org, Feb 14 2017

Labels: -Update-Monthly Update-Weekly
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20557391eabfddda39e9dd2734af1c8197845430

commit 20557391eabfddda39e9dd2734af1c8197845430
Author: alancutter <alancutter@chromium.org>
Date: Wed Feb 15 01:46:29 2017

Avoid mutating the NonInterpolableValue in CSSTextIndentInterpolationType::maybeMergeSingles()

This patch fixes test failures in https://codereview.chromium.org/2680923005
caused by incorrect handling of NIVs in CSSTextIndentInterpolationType.
Though the inputs to maybeMergeSingles() are r value references the inner
contents are shared by other InterpolationValues cloned from the same
conversion. This patch updates it to not mutate the inner contents.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2691983003
Cr-Commit-Position: refs/heads/master@{#450551}

[modify] https://crrev.com/20557391eabfddda39e9dd2734af1c8197845430/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e47e5f7e3c033378b37b1e39c0c236ed6a608d8f

commit e47e5f7e3c033378b37b1e39c0c236ed6a608d8f
Author: alancutter <alancutter@chromium.org>
Date: Wed Feb 15 07:17:46 2017

Fix misinterpretation of background-position edge in underlying value for animations

This patch adds logic for handling the BackgroundEdgeOrigin component of
a FillLayer in animations. This ensures we interpret "right" and "bottom"
edges correctly in animations involving underlying values.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2695893002
Cr-Commit-Position: refs/heads/master@{#450622}

[add] https://crrev.com/e47e5f7e3c033378b37b1e39c0c236ed6a608d8f/third_party/WebKit/LayoutTests/animations/underlying-background-position-edge.html
[modify] https://crrev.com/e47e5f7e3c033378b37b1e39c0c236ed6a608d8f/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a661d2c478a78a6bba5938b42f624a81a17329e

commit 9a661d2c478a78a6bba5938b42f624a81a17329e
Author: alancutter <alancutter@chromium.org>
Date: Fri Feb 17 02:18:53 2017

Don't animate caret-color: auto

This patch enables ColorPropertyFunctions to effectively return nullptr
instead of a StyleColor when the property doesn't have a color value.
This allows us to not run animations for caret-color when one side is "auto".

TEST=external/csswg-test/css-ui-3/caret-color-021.html
BUG= 676295 , 681424 

Review-Url: https://codereview.chromium.org/2694383002
Cr-Commit-Position: refs/heads/master@{#451183}

[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/LayoutTests/animations/composition/caret-color-composition.html
[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h
[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/ColorPropertyFunctions.cpp
[modify] https://crrev.com/9a661d2c478a78a6bba5938b42f624a81a17329e/third_party/WebKit/Source/core/animation/ColorPropertyFunctions.h
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbd434ef8e9ef91ca5cfd146b937b3c76a3b0f2c

commit cbd434ef8e9ef91ca5cfd146b937b3c76a3b0f2c
Author: alancutter <alancutter@chromium.org>
Date: Fri Feb 17 04:42:06 2017

Don't ignore "none" in underlying image lists for animations

This patch ensures "none" in the computed value of background-image
and -webkit-mask-image are handled by animation code. Without this
values like "url(x), none" behave like "url(x)".

This issue is currently unreachable without refactoring CSS Transitions
onto using CSSInterpolationTypes (https://codereview.chromium.org/2680923005).
The relevant test case is: animations/interpolation/background-image-interpolation.html

BUG= 681424 

Review-Url: https://codereview.chromium.org/2693843002
Cr-Commit-Position: refs/heads/master@{#451215}

[modify] https://crrev.com/cbd434ef8e9ef91ca5cfd146b937b3c76a3b0f2c/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp
[modify] https://crrev.com/cbd434ef8e9ef91ca5cfd146b937b3c76a3b0f2c/third_party/WebKit/Source/core/animation/ImageListPropertyFunctions.h
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2457ae9482f7e385d88cad62e066ee9203159d46

commit 2457ae9482f7e385d88cad62e066ee9203159d46
Author: alancutter <alancutter@chromium.org>
Date: Fri Feb 17 07:34:13 2017

Add TransitionInterpolation class for CSS Transition refactor

This patch is part of refactoring CSS Transitions to use
CSSInterpolationTypes instead of AnimatableValues:
https://codereview.chromium.org/2680923005

The TransitionInterpolation class is a sibling of
InvalidatableInterpolation and does the same thing except it does
not need to deal with additive animations, keyframes being
invalidated by the environment and needing reconversion of the
InterpolationValues.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2650133002
Cr-Commit-Position: refs/heads/master@{#451262}

[modify] https://crrev.com/2457ae9482f7e385d88cad62e066ee9203159d46/third_party/WebKit/Source/core/animation/BUILD.gn
[modify] https://crrev.com/2457ae9482f7e385d88cad62e066ee9203159d46/third_party/WebKit/Source/core/animation/InterpolableValue.h
[modify] https://crrev.com/2457ae9482f7e385d88cad62e066ee9203159d46/third_party/WebKit/Source/core/animation/Interpolation.h
[modify] https://crrev.com/2457ae9482f7e385d88cad62e066ee9203159d46/third_party/WebKit/Source/core/animation/InterpolationType.h
[add] https://crrev.com/2457ae9482f7e385d88cad62e066ee9203159d46/third_party/WebKit/Source/core/animation/TransitionInterpolation.cpp
[add] https://crrev.com/2457ae9482f7e385d88cad62e066ee9203159d46/third_party/WebKit/Source/core/animation/TransitionInterpolation.h
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32281b4e0848e645fc4bf6e568179088ca870a22

commit 32281b4e0848e645fc4bf6e568179088ca870a22
Author: alancutter <alancutter@chromium.org>
Date: Mon Feb 20 01:59:27 2017

Add TransitionKeyframe class for CSS Transition refactor

This patch is part of refactoring CSS Transitions to use
CSSInterpolationTypes instead of AnimatableValues:
https://codereview.chromium.org/2680923005

The TransitionKeyframe class represents animation keyframes
of a CSS transition. It is created to replace the use of
AnimatableValueKeyframes while using InterpolationValues
instead of AnimatableValues.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2651553004
Cr-Commit-Position: refs/heads/master@{#451542}

[modify] https://crrev.com/32281b4e0848e645fc4bf6e568179088ca870a22/third_party/WebKit/Source/core/animation/BUILD.gn
[modify] https://crrev.com/32281b4e0848e645fc4bf6e568179088ca870a22/third_party/WebKit/Source/core/animation/Keyframe.h
[add] https://crrev.com/32281b4e0848e645fc4bf6e568179088ca870a22/third_party/WebKit/Source/core/animation/TransitionKeyframe.cpp
[add] https://crrev.com/32281b4e0848e645fc4bf6e568179088ca870a22/third_party/WebKit/Source/core/animation/TransitionKeyframe.h
[modify] https://crrev.com/32281b4e0848e645fc4bf6e568179088ca870a22/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb8696135be40717770ba4422c140c79851d9f74

commit cb8696135be40717770ba4422c140c79851d9f74
Author: alancutter <alancutter@chromium.org>
Date: Mon Feb 20 02:40:08 2017

Don't animate visibility keyframes that don't include "visible"

This change updates the requirements for smoothly interpolating
visibility animations to include needing one side to be "visible".
This is to maintain existing behaviour once CSS Transitions is
refactored to use CSSInterpolationTypes in:
https://codereview.chromium.org/2680923005

Relevant spec text:
https://drafts.csswg.org/css-transitions/#animtype-visibility

BUG= 681424 

Review-Url: https://codereview.chromium.org/2682603004
Cr-Commit-Position: refs/heads/master@{#451548}

[modify] https://crrev.com/cb8696135be40717770ba4422c140c79851d9f74/third_party/WebKit/LayoutTests/animations/interpolation/visibility-interpolation.html
[modify] https://crrev.com/cb8696135be40717770ba4422c140c79851d9f74/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33adb63225089cac29c7973df63cac8dffb731d3

commit 33adb63225089cac29c7973df63cac8dffb731d3
Author: alancutter <alancutter@chromium.org>
Date: Mon Feb 20 03:11:41 2017

Add "auto" handling to border-image-width animations

Animation code was not able to handle "auto" values in border-image-width
keyframes. This patch adds it to the NonInterpolableValue along with
appropriate handling for animating between values with matched auto
keywords.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2696563006
Cr-Commit-Position: refs/heads/master@{#451550}

[modify] https://crrev.com/33adb63225089cac29c7973df63cac8dffb731d3/third_party/WebKit/LayoutTests/animations/interpolation/border-image-width-interpolation-expected.txt
[modify] https://crrev.com/33adb63225089cac29c7973df63cac8dffb731d3/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c72872d7955bffc87b46ce9eff180ed5b0beb4d

commit 8c72872d7955bffc87b46ce9eff180ed5b0beb4d
Author: alancutter <alancutter@chromium.org>
Date: Mon Feb 20 05:40:03 2017

Add TransitionKeyframeEffectModel specialisation

This patch is part of refactoring CSS Transitions to use
CSSInterpolationTypes instead of AnimatableValues:
https://codereview.chromium.org/2680923005

BUG= 681424 

Review-Url: https://codereview.chromium.org/2651533004
Cr-Commit-Position: refs/heads/master@{#451563}

[modify] https://crrev.com/8c72872d7955bffc87b46ce9eff180ed5b0beb4d/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f73251b30347e8e66d536dde147da1d83b07cbb

commit 8f73251b30347e8e66d536dde147da1d83b07cbb
Author: alancutter <alancutter@chromium.org>
Date: Mon Feb 20 05:49:27 2017

Allow CSSTransformInterpolationType to merge interpolated values together

This patch is part of refactoring CSS Transitions to use
CSSInterpolationTypes instead of AnimatableValues:
https://codereview.chromium.org/2680923005

When using CSSInterpolationTypes for CSS Transitions we need to be able to
use interpolated InterpolationValues as keyframe values for retargeted
composited transitions. This patch ensures CSSTransformInterpolationType
has the ability to do this.

BUG= 681424 

Review-Url: https://codereview.chromium.org/2693823002
Cr-Commit-Position: refs/heads/master@{#451565}

[modify] https://crrev.com/8f73251b30347e8e66d536dde147da1d83b07cbb/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9

commit 6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9
Author: alancutter <alancutter@chromium.org>
Date: Mon Feb 20 11:34:08 2017

Refactor CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues

This patch updates CSSAnimations::calculateTransitionUpdateForProperty()
to use TransitionKeyframes instead of AnimatableValueKeyframes.
This obsoletes the use of AnimatableValues as the main data type for
CSS Transitions by replacing them with InterpolationValues and CSSInterpolationTypes.

Design doc:
https://docs.google.com/document/d/14tj6M5kyNpr10dFp5m43udOMUVPwxnulBEW7Kvh2vMs/edit?usp=sharing

BUG= 681424 

Review-Url: https://codereview.chromium.org/2680923005
Cr-Commit-Position: refs/heads/master@{#451598}

[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/animations/interpolation/backdrop-filter-interpolation-expected.txt
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/animations/interpolation/border-image-source-interpolation-expected.txt
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/animations/interpolation/box-shadow-interpolation-expected.txt
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/animations/interpolation/filter-interpolation-expected.txt
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/LayoutTests/animations/interpolation/list-style-image-interpolation-expected.txt
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation-expected.txt
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/animations/interpolation/svg-stroke-dasharray-interpolation-expected.txt
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/animations/interpolation/text-indent-interpolation-expected.txt
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation-expected.txt
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/animations/interpolation/webkit-mask-box-image-source-interpolation-expected.txt
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/LayoutTests/animations/transition-zoomed-length.html
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/transitions/mismatched-shadow-transitions-expected.txt
[delete] https://crrev.com/2090c9f72c7eebd76726965cfc7d15cb8d1cc12d/third_party/WebKit/LayoutTests/transitions/mismatched-shadow-transitions.html
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/LayoutTests/transitions/multiple-shadow-transitions-expected.txt
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/LayoutTests/transitions/multiple-shadow-transitions.html
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/LayoutTests/transitions/svg-transitions-expected.txt
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/LayoutTests/transitions/svg-transitions.html
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/Source/core/animation/css/CSSAnimations.h
[modify] https://crrev.com/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f2ed615392e13d7a13bb18629bf412b0e990c92

commit 2f2ed615392e13d7a13bb18629bf412b0e990c92
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Feb 20 13:08:36 2017

Auto-rebaseline for r451598

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/610819

https://chromium.googlesource.com/chromium/src/+/6b6a6c64cdccd

BUG= 681424 
TBR=alancutter@chromium.org

Review-Url: https://codereview.chromium.org/2702173003 .
Cr-Commit-Position: refs/heads/master@{#451613}

[modify] https://crrev.com/2f2ed615392e13d7a13bb18629bf412b0e990c92/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2f2ed615392e13d7a13bb18629bf412b0e990c92/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/2f2ed615392e13d7a13bb18629bf412b0e990c92/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/2f2ed615392e13d7a13bb18629bf412b0e990c92/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/2f2ed615392e13d7a13bb18629bf412b0e990c92/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/2f2ed615392e13d7a13bb18629bf412b0e990c92/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png

Comment 22 by alancutter@chromium.org, Feb 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment