New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 681421 link

Starred by 1 user
Status: Fixed
Owner:
█ rsgav...@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Compling Android version gives info about using deprecated elements

Project Member Reported by mar...@mwiacek.com, Jan 15 2017 
Steps to reproduce the problem:
ninja -C out/Release chrome_public_apk

What is the expected behavior?

What went wrong?
ui/android/java/src/org/chromium/ui/UiUtils.java:167: warning: [deprecation] getLocale() in InputMethodSubtype has been deprecated

                String locale = subtypes.get(j).getLocale();

chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java:979: warning: [deprecation] getFocusedVirtualView() in ExploreByTouchHelper has been deprecated

            mNodeProvider.sendEventForVirtualView(mNodeProvider.getFocusedVirtualView(),

chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:400: warning: [deprecation] FEATURE_INDETERMINATE_PROGRESS in Window has been deprecated

                getWindow().setFeatureInt(Window.FEATURE_INDETERMINATE_PROGRESS,

chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:401: warning: [deprecation] PROGRESS_VISIBILITY_OFF in Window has been deprecated

                Window.PROGRESS_VISIBILITY_OFF);

chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:1040: warning: [deprecation] getColor(int) in Resources has been deprecated

                .setToolbarColor(context.getResources().getColor(R.color.dark_action_bar_color))

chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java:237: warning: [deprecation] builder(CastDevice,Listener) in CastOptions has been deprecated

                .builder(mSink.getDevice(), listener)

chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java:252: warning: [deprecation] launchApplication(GoogleApiClient,String,boolean) in CastApi has been deprecated
                return Cast.CastApi.launchApplication(apiClient, appId, relaunchIfRunning);

chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java:150: warning: [deprecation] setContent(RemoteViews) in Builder has been deprecated

        builder.setContent(compactView);

chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java:172: warning: [deprecation] bigContentView in Notification has been deprecated

        notification.bigContentView = bigView;

Did this work before? N/A 

Chrome version: 57  Channel: canary
OS Version: 6
Flash Version:

Comment 1 by mar...@mwiacek.com, Jan 15 2017 

https://codereview.chromium.org/2632103002/ contains proposed patch
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/834246eadace04e43bc7f49d2f9deca590364a54

commit 834246eadace04e43bc7f49d2f9deca590364a54
Author: marcin <marcin@mwiacek.com>
Date: Wed Jan 18 18:43:03 2017

(Android) Replacing deprecated API with current

BUG= 681421 

Review-Url: https://codereview.chromium.org/2632103002
Cr-Commit-Position: refs/heads/master@{#444426}

[modify] https://crrev.com/834246eadace04e43bc7f49d2f9deca590364a54/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[modify] https://crrev.com/834246eadace04e43bc7f49d2f9deca590364a54/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/834246eadace04e43bc7f49d2f9deca590364a54/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
[modify] https://crrev.com/834246eadace04e43bc7f49d2f9deca590364a54/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/834246eadace04e43bc7f49d2f9deca590364a54/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
[modify] https://crrev.com/834246eadace04e43bc7f49d2f9deca590364a54/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
[modify] https://crrev.com/834246eadace04e43bc7f49d2f9deca590364a54/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
[modify] https://crrev.com/834246eadace04e43bc7f49d2f9deca590364a54/ui/android/java/src/org/chromium/ui/UiUtils.java
[modify] https://crrev.com/834246eadace04e43bc7f49d2f9deca590364a54/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java

Comment 3 by rsgav...@chromium.org, Jan 20 2017

Labels: Needs-Feedback
hi, Does #2 fix the issue?

Comment 4 by mar...@mwiacek.com, Jan 21 2017 

Yes, all bug issues were fixed. Unfortunately I cannot close bug (lack of privileges?)
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 30 2017

Labels: -Needs-Feedback Needs-Review
Owner: rsgav...@chromium.org
Thank you for providing more feedback. Adding requester "rsgavara@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by rsgav...@chromium.org, Jan 30 2017

Status: Fixed (was: Unconfirmed)
Thank you! Closing this per #4
►

Sign in to add a comment