DevTools: persistence: tab crash after editing function source before stepping into it |
|||
Issue descriptionChrome Version: 57.0.2982.0 OS: Windows 10 See attached screencast What steps will reproduce the problem? (1) Have workspaces setup with persistence 2.0 (2) Trigger a breakpoint on a function that hasn't been called before (3) Edit the source of the function and save (4) Immediately after saving, step into/F11 the function What is the expected result? No crash interruption please What happens instead? Target page crashes, DevTools disconnects Notes: - Editing "around" the function source is fine, no crash - Seems less likely to crash if I wait a long time in between saving and stepping into. - Doesn't matter when the debugger is paused, I can repro with a breakpoint inside a long setTimeout.
,
Jan 20 2017
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9889b14fb43fb5faba6df832065a5d3373e76df3 commit 9889b14fb43fb5faba6df832065a5d3373e76df3 Author: luoe <luoe@chromium.org> Date: Fri Jan 20 23:51:52 2017 DevTools: add missing check for null script in SourceMapNamesResolver SourceMapNamesResolver.js was missing a check due to the possibility for SDK.DebuggerModel.Location.script() to return null. BUG= 681419 Review-Url: https://codereview.chromium.org/2649593002 Cr-Commit-Position: refs/heads/master@{#445212} [modify] https://crrev.com/9889b14fb43fb5faba6df832065a5d3373e76df3/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
,
Jan 26 2017
After doing a bisect on a Windows machine, this issue was fixed somewhere in this V8 autoroll: https://chromium.googlesource.com/chromium/src/+/b57345e696995369c8df3c23782734167386baee I was unable to reproduce this error at that commit and after. |
|||
►
Sign in to add a comment |
|||
Comment 1 by l...@chromium.org
, Jan 15 2017DevTools in DevTools has a console error after stepping into: Uncaught (in promise) TypeError: Cannot read property 'sourceMapURL' of null at Object.Sources.SourceMapNamesResolver.resolveScopeInObject (sources_module.js:273) at Sources.ScopeChainSidebarPane._innerUpdate (sources_module.js:866) Sources.SourceMapNamesResolver.resolveScopeInObject @ sources_module.js:273 _innerUpdate @ sources_module.js:866