Issue metadata
Sign in to add a comment
|
Alert messages in Gmail not being spoken by ChromeVox
Reported by
mjanusau...@gmail.com,
Jan 15 2017
|
||||||||||||||||||||||||
Issue descriptionMode: force_next Version: 57.0.2970.0 Reproduction Steps: 1. Select conversation(s) in Gmail. 2. Press # to delete. 3.Notice that now the alert messages confirming the deletion are no longer spoken by ChromeVox while . Previously they were being repeated multiple times. Looks like the fix may have been a bit too agressive.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82e8eb7b5935197660fe3ef05c8ef05e9e5d8c26 commit 82e8eb7b5935197660fe3ef05c8ef05e9e5d8c26 Author: dtseng <dtseng@chromium.org> Date: Mon Jan 23 20:34:22 2017 Improve live region performance Previously, we explicitly omitted alert nodes from being processed as live regions to address hangs in ChromeVox. - before this patch, ChromeVox would generate output for the same live region potentially the same number of times we get a tree change under the live region container; this could be thousands of times - we walked up the ancestry chain using a recursive call - we walked up the final container node's ancestry chain looking for a previously outputted live region Fixes: - walk up ancestry chain looking for the live region container first - move logic to check if the live region container was previously processed immediately after (without any tree walking since the map could only contain live region containers) TEST=manual on Gmail's keyboard shortcuts page (?). Delete a message with '#'. Verify appropriate alert output. BUG= 681417 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2640283004 Cr-Commit-Position: refs/heads/master@{#445469} [modify] https://crrev.com/82e8eb7b5935197660fe3ef05c8ef05e9e5d8c26/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
,
Jan 23 2017
,
Jan 23 2017
Approving merge to M57.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9165ea416a31dce68c0409e34022d51a871c3133 commit 9165ea416a31dce68c0409e34022d51a871c3133 Author: David Tseng <dtseng@chromium.org> Date: Mon Jan 23 23:41:32 2017 Merge to m57: Improve live region performance Previously, we explicitly omitted alert nodes from being processed as live regions to address hangs in ChromeVox. - before this patch, ChromeVox would generate output for the same live region potentially the same number of times we get a tree change under the live region container; this could be thousands of times - we walked up the ancestry chain using a recursive call - we walked up the final container node's ancestry chain looking for a previously outputted live region Fixes: - walk up ancestry chain looking for the live region container first - move logic to check if the live region container was previously processed immediately after (without any tree walking since the map could only contain live region containers) TEST=manual on Gmail's keyboard shortcuts page (?). Delete a message with '#'. Verify appropriate alert output. BUG= 681417 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=dtseng@chromium.org Review-Url: https://codereview.chromium.org/2640283004 Cr-Commit-Position: refs/heads/master@{#445469} (cherry picked from commit 82e8eb7b5935197660fe3ef05c8ef05e9e5d8c26) Review-Url: https://codereview.chromium.org/2653803002 . Cr-Commit-Position: refs/branch-heads/2987@{#46} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/9165ea416a31dce68c0409e34022d51a871c3133/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
,
Jan 23 2017
,
Apr 5 2017
verified on 58.0.3029.51 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pbath...@chromium.org
, Jan 17 2017Status: Untriaged (was: Unconfirmed)