New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681391 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Slight change to focus ring layout test under gpu rasterization

Project Member Reported by bsalo...@google.com, Jan 15 2017

Issue description

There is a slight change in one pixel of focus ring rasterization due to a Skia change. This is blocking the Skia roll. The change is innocuous and these tests should be rebaeslined.

Skia change: https://skia.googlesource.com/skia/+/3b830a9ea3bce9eba663ab95486cf153831cd29c

Layout test failures:
https://storage.googleapis.com/chromium-layout-test-archives/linux_trusty_blink_rel/3634/layout-test-results/results.html


 
Cc: jcgregorio@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3733756a5300a744db816bda2b819a7be3b1dc0f

commit 3733756a5300a744db816bda2b819a7be3b1dc0f
Author: bsalomon <bsalomon@google.com>
Date: Sun Jan 15 23:14:59 2017

Mark two GPU raster focus ring layout tests as needing rebaselining

BUG= 681391 

TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2634833002
Cr-Commit-Position: refs/heads/master@{#443818}

[modify] https://crrev.com/3733756a5300a744db816bda2b819a7be3b1dc0f/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f1412bdbe40b21539aaf83fd831fa5bf1a85e92

commit 7f1412bdbe40b21539aaf83fd831fa5bf1a85e92
Author: bsalomon <bsalomon@google.com>
Date: Tue Jan 17 14:32:40 2017

Rebaseline two focus ring layout test image results after slight gpu raster change.

BUG= 681391 

Review-Url: https://codereview.chromium.org/2638653006
Cr-Commit-Position: refs/heads/master@{#444046}

[modify] https://crrev.com/7f1412bdbe40b21539aaf83fd831fa5bf1a85e92/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by bsalo...@google.com, Jan 17 2017

Status: Fixed (was: Assigned)

Sign in to add a comment