New issue
Advanced search Search tips

Issue 681369 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in document

Project Member Reported by ClusterFuzz, Jan 15 2017

Issue description

Project Member

Comment 1 by sheriffbot@chromium.org, Jan 15 2017

Labels: M-57
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 15 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 15 2017

Labels: Pri-1
Components: Blink>Compositing
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
chrishtr: ClusterFuzz suspects that https://chromium.googlesource.com/chromium/src/+/1cf98b57647fa75d2aa18a94ba2128f1dc770386 introduced this issue. Can you please take a look?
It appears that the cause is that MouseEventManager::handleMouseDraggedEvent calls

m_frame->eventHandler().selectionController().handleMouseDraggedEvent

which may mutate the DOM and invalidate the node which is the target of the event.

This root cause is not due to my CL; my CL just added code which exhibited it by
trying to access fields on the invalidated node.
I have an easy fix.
Status: Started (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Jan 19 2017

ClusterFuzz has detected this issue as fixed in range 444249:444262.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6358216842936320

Fuzzer: bj_broddelwerk
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x60e000079b40
Crash State:
  document
  frameView
  blink::AutoscrollController::startAutoscrollForSelection
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=436983:437053
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=444249:444262

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97YjtM5Aui8sq53ESm_rqlKWXUmTMD1hK6JZHGmSaazx3gV8a_DsF6VrJ412EICHWdLgVTZeSTlNSvettye_X59HWTDeqcpGrGfs7e4TJadWMBItOOYAUa47f3O9wWRje9VgRCDN5JWTBsB8ws2jRB23QnBT_s0BI7V0M5ENBvwAW28YH9FUC4JpEHhWxHAmB4kpRA99UEGcK9oEWcbPzeuPOhU9ps3yljtND4Avs-mjoVsFCQwvhIrizm4XlnR2HIEu6fzN9cxe_VyYDyl1X6DKbdZTrbTsv4YJlm1xB1FBdfET54L1m1_621ZApIUBYKA_uU9EiHaqeMPkH19U3Z5l1hg-zjk-g627enAb_iYtsIN4Fg?testcase_id=6358216842936320


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jan 19 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6358216842936320 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jan 19 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: ClusterFuzz-Wrong
Status: Started (was: Verified)
Status: Fixed (was: Started)
Labels: -ReleaseBlock-Beta
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 28 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ClusterFuzz-Wrong
We have made a bunch of changes on ClusterFuzz side, so resetting ClusterFuzz-Wrong label.

Sign in to add a comment