New issue
Advanced search Search tips

Issue 681279 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Slow processing of sys info before sending to the feedback app.

Project Member Reported by afakhry@chromium.org, Jan 14 2017

Issue description

The below function takes ~30ms on peach_pit!

https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/feedback_private/feedback_service.cc?q=FeedbackService::OnSystemLogsFetchComplete&sq=package:chromium&l=107-117&dr=CSs

void FeedbackService::OnSystemLogsFetchComplete(
    const GetSystemInformationCallback& callback,
    std::unique_ptr<system_logs::SystemLogsResponse> sys_info_map) {
  SystemInformationList sys_info_list;
  if (sys_info_map.get()) {
    for (const auto& itr : *sys_info_map)
      PopulateSystemInfo(&sys_info_list, itr.first, itr.second);
  }

  callback.Run(sys_info_list);
}
 
Status: Fixed (was: Assigned)

Sign in to add a comment