New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681269 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 658246



Sign in to add a comment

DownloadUIItem needs to add download progress info and observer calls.

Project Member Reported by dim...@chromium.org, Jan 14 2017

Issue description

This is to support progress indication in DownloadCenter.


 

Comment 1 by dim...@chromium.org, Jan 14 2017

Blocking: 658246
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d507add10786ba9b0e6e4291ffe75940d4a9846

commit 9d507add10786ba9b0e6e4291ffe75940d4a9846
Author: dimich <dimich@chromium.org>
Date: Fri Feb 10 18:01:46 2017

Adding status info to DownloadUIItem and piping it through.

BUG= 681269 

Review-Url: https://codereview.chromium.org/2631933002
Cr-Commit-Position: refs/heads/master@{#449655}

[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/components/offline_pages/core/BUILD.gn
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/components/offline_pages/core/downloads/BUILD.gn
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/components/offline_pages/core/downloads/download_ui_adapter.h
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/components/offline_pages/core/downloads/download_ui_item.cc
[modify] https://crrev.com/9d507add10786ba9b0e6e4291ffe75940d4a9846/components/offline_pages/core/downloads/download_ui_item.h

Cc: dim...@chromium.org
Owner: dewittj@chromium.org
Taking this for the next step.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e932ed672d61ea3e2e4675aa17715bb2899af788

commit e932ed672d61ea3e2e4675aa17715bb2899af788
Author: dimich <dimich@chromium.org>
Date: Fri Feb 24 21:38:39 2017

[Offline Pages] Make prerenderer notify us of network progress.

Today, Prerenderer is made aware of bytes that are loaded when each
resource finishes, but does not expose it to observers of
PrerenderContents and friends.  This change allows us to track
coarse-grained progress on background downloads.

BUG= 681269 

Review-Url: https://codereview.chromium.org/2711693002
Cr-Commit-Position: refs/heads/master@{#452934}

[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/android/offline_pages/prerender_adapter.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/android/offline_pages/prerender_adapter.h
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/android/offline_pages/prerender_adapter_unittest.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/android/offline_pages/prerendering_loader.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/android/offline_pages/prerendering_loader.h
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/android/offline_pages/prerendering_offliner.h
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/prerender/prerender_contents.h
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/prerender/prerender_handle.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/prerender/prerender_handle.h
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/prerender/prerender_link_manager.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/prerender/prerender_link_manager.h
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/chrome/browser/prerender/prerender_unittest.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/components/offline_pages/core/downloads/download_ui_adapter.h
[modify] https://crrev.com/e932ed672d61ea3e2e4675aa17715bb2899af788/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07bec82ec92e1047614b17192569f69260945d42

commit 07bec82ec92e1047614b17192569f69260945d42
Author: dimich <dimich@chromium.org>
Date: Tue Feb 28 01:08:51 2017

This fixes issues that prevent progress indication for Offline Pages in Download Home:
- The OfflinePageItemWrapper has to produce status string.
- The DownloadUIAdapter wrong hookup was causing byte counts to not update.

The David's CL https://codereview.chromium.org/2704853002/ is still necessary as it adds buttons hookup.

BUG= 681269 

Review-Url: https://codereview.chromium.org/2716013003
Cr-Commit-Position: refs/heads/master@{#453431}

[modify] https://crrev.com/07bec82ec92e1047614b17192569f69260945d42/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/07bec82ec92e1047614b17192569f69260945d42/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
[modify] https://crrev.com/07bec82ec92e1047614b17192569f69260945d42/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/07bec82ec92e1047614b17192569f69260945d42/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/07bec82ec92e1047614b17192569f69260945d42/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/07bec82ec92e1047614b17192569f69260945d42/components/offline_pages/core/downloads/download_ui_adapter.h

Status: Fixed (was: Started)

Sign in to add a comment