New issue
Advanced search Search tips

Issue 681260 link

Starred by 1 user
Status: Duplicate
Merged: issue 675657
Owner: ----
Closed: Jan 2017
Cc:
vapier@chromium.org
sjg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Compile error got past PreCQ

Project Member Reported by dgarr...@chromium.org, Jan 14 2017 
This CL caused a compile error on multiple boards:

https://chromium-review.googlesource.com/#/c/423276/

In this CQ run:

https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/13309

Why didn't the PreCQ catch it? What should we add to the PreCQ to catch these errors in future?

Comment 1 by sjg@chromium.org, Jan 14 2017 

Is this similar to  crbug.com/675657  ?

IMO it would be better to build all the packages with just a few toolchain combinations - i.e. those that are different. E.g. 32/64-bit ARM/x86. That would be 4 builders and should give pretty good coverage for most packages.

Comment 2 by vapier@chromium.org, Jan 17 2017

Mergedinto: 675657
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment