New issue
Advanced search Search tips

Issue 681253 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Long task: Update name in TaskAttributionTiming to "taskscript" from "frame"

Project Member Reported by panicker@chromium.org, Jan 14 2017

Issue description

Update based on updated spec: 
change name to "taskscript" from "frame"
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac7bf105a4b432d23c18f0e4a042b960c2a9af87

commit ac7bf105a4b432d23c18f0e4a042b960c2a9af87
Author: panicker <panicker@chromium.org>
Date: Fri Jan 20 04:30:49 2017

minor name updates based on spec update at: https://wicg.github.io/longtasks

BUG= 681252 , 681253 

Review-Url: https://codereview.chromium.org/2636503003
Cr-Commit-Position: refs/heads/master@{#444982}

[modify] https://crrev.com/ac7bf105a4b432d23c18f0e4a042b960c2a9af87/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-attributes.html
[modify] https://crrev.com/ac7bf105a4b432d23c18f0e4a042b960c2a9af87/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-externalscript.html
[modify] https://crrev.com/ac7bf105a4b432d23c18f0e4a042b960c2a9af87/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-raf.html
[modify] https://crrev.com/ac7bf105a4b432d23c18f0e4a042b960c2a9af87/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ac7bf105a4b432d23c18f0e4a042b960c2a9af87/third_party/WebKit/Source/core/timing/Performance.cpp
[modify] https://crrev.com/ac7bf105a4b432d23c18f0e4a042b960c2a9af87/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
[modify] https://crrev.com/ac7bf105a4b432d23c18f0e4a042b960c2a9af87/third_party/WebKit/Source/core/timing/PerformanceTest.cpp
[modify] https://crrev.com/ac7bf105a4b432d23c18f0e4a042b960c2a9af87/third_party/WebKit/Source/core/timing/TaskAttributionTiming.cpp
[modify] https://crrev.com/ac7bf105a4b432d23c18f0e4a042b960c2a9af87/third_party/WebKit/Source/core/timing/TaskAttributionTiming.h
[modify] https://crrev.com/ac7bf105a4b432d23c18f0e4a042b960c2a9af87/third_party/WebKit/Source/core/timing/TaskAttributionTiming.idl

Labels: Merge-Request-57
This is needed for M57 Origin Trial for Long Tasks
(it missed the branch cut by a few minutes)
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 3 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 3 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/962fe3e46b942f2dac235e72696ab844a4280492

commit 962fe3e46b942f2dac235e72696ab844a4280492
Author: Shubhie Panicker <panicker@chromium.org>
Date: Fri Feb 03 22:02:18 2017

minor name updates based on spec update at: https://wicg.github.io/longtasks

BUG= 681252 , 681253 

Review-Url: https://codereview.chromium.org/2636503003
Cr-Commit-Position: refs/heads/master@{#444982}
(cherry picked from commit ac7bf105a4b432d23c18f0e4a042b960c2a9af87)

Review-Url: https://codereview.chromium.org/2671083002 .
Cr-Commit-Position: refs/branch-heads/2987@{#301}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/962fe3e46b942f2dac235e72696ab844a4280492/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-attributes.html
[modify] https://crrev.com/962fe3e46b942f2dac235e72696ab844a4280492/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-externalscript.html
[modify] https://crrev.com/962fe3e46b942f2dac235e72696ab844a4280492/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-raf.html
[modify] https://crrev.com/962fe3e46b942f2dac235e72696ab844a4280492/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/962fe3e46b942f2dac235e72696ab844a4280492/third_party/WebKit/Source/core/timing/Performance.cpp
[modify] https://crrev.com/962fe3e46b942f2dac235e72696ab844a4280492/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
[modify] https://crrev.com/962fe3e46b942f2dac235e72696ab844a4280492/third_party/WebKit/Source/core/timing/PerformanceTest.cpp
[modify] https://crrev.com/962fe3e46b942f2dac235e72696ab844a4280492/third_party/WebKit/Source/core/timing/TaskAttributionTiming.cpp
[modify] https://crrev.com/962fe3e46b942f2dac235e72696ab844a4280492/third_party/WebKit/Source/core/timing/TaskAttributionTiming.h
[modify] https://crrev.com/962fe3e46b942f2dac235e72696ab844a4280492/third_party/WebKit/Source/core/timing/TaskAttributionTiming.idl

Status: Fixed (was: Assigned)

Sign in to add a comment