New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681251 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Predator blaming a comment-only change with 0 distance to crashed line

Project Member Reported by mbarbe...@chromium.org, Jan 14 2017

Issue description

Came across an unusual case while doing security triage. Unless I'm missing something, this looks like a pretty serious bug.

See https://cluster-fuzz.appspot.com/v2/testcase-detail/5918821207769088?noredirect=1 for the case in question.

It looks like we're not correctly identifying the crashing line in the older revisions we're diffing against. The CL only made comment changes, but it's identified as landing on the crashing line exactly. While it did modify the line number we had identified as crashing, that was the line number in the older CL. The actual crashing line is elsewhere, and can be computed based on the diff.
 
This is because we use ``git diff`` to get distance between crashed line and touched lines, the new version doesn't have this problem because we are using ``git blame``.
Status: WontFix (was: Assigned)
As we integrate with the Predator, the problem will be gone.

Sign in to add a comment