MD Settings: showing the advanced section is janky |
||||
Issue descriptionI assume there's another bug about this as well, but let's de-dupe if we find it. Right now, showing advanced options takes longer in MD Settings (chrome://md-settings) than it does in the old options page (chrome://settings-frame). There's additionally a paper-ripple animation on the "Show advanced" button that gets gummed up while the advanced page is showing. There's a bunch of stuff happening. Let's trying to get deeper understanding into what's taking time here to get on par with old options. The time it takes to show contents settings (issue 632618) might be related, but we wont know for sure until we understand what's going on a little better.
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f commit f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f Author: dschuyler <dschuyler@chromium.org> Date: Tue Feb 07 22:46:59 2017 [MD settings] idle load basic and advanced pages This CL uses lazy loading templates to preload the advanced page while the basic page is idle. The result is that the advanced page toggles much faster (addressing the 'jank' mentioned in the bug). This CL is replacing CL 2652443002. BUG= 681238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2660383002 Cr-Commit-Position: refs/heads/master@{#448757} [modify] https://crrev.com/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f/chrome/browser/resources/settings/basic_page/basic_page.js [add] https://crrev.com/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f/chrome/browser/resources/settings/controls/settings_idle_render.html [add] https://crrev.com/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f/chrome/browser/resources/settings/controls/settings_idle_render.js [modify] https://crrev.com/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f/chrome/test/BUILD.gn [modify] https://crrev.com/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f/chrome/test/data/webui/settings/advanced_page_browsertest.js [add] https://crrev.com/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f/chrome/test/data/webui/settings/settings_idle_render_browsertest.js [modify] https://crrev.com/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f/chrome/test/data/webui/settings/settings_main_test.js [modify] https://crrev.com/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f/chrome/test/data/webui/settings/settings_page_browsertest.js
,
Feb 7 2017
Please try this out on low end machines - it should be faster to expand the advanced section of the page then it was prior to this change.
,
Apr 3 2017
Verified on 9426.0.0 / 59.0.3055.0 ChromeOS
,
Apr 17 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dschuyler@chromium.org
, Jan 21 2017