mash: chrome window property changes are not reflected in ash. |
||
Issue descriptionmash: chrome window property changes are not reflected in ash. I believe this is the defect causing some issues with the mash shelf. PropertyConverter transports registered properties, we have one each in ash and chrome: ash::kShelfItemTypeKey is registered in the WindowManager ctor for ash: https://cs.chromium.org/chromium/src/ash/mus/window_manager.cc?rcl=0&l=93 No ash properties are registered for chrome's PropertyConverter, afaict: https://cs.chromium.org/chromium/src/ui/views/mus/mus_client.h?rcl=1484339010&l=149 That would explain why I can't set the app list shelf item type here: https://bugs.chromium.org/p/chromium/issues/detail?id=679087#c2 But it doesn't explain the full extent of the related issues I'm seeing. (it seems like the titles and icons of windows aren't always propagated)
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78697424ef7db4e0c3cdc55b2b628a460a063140 commit 78697424ef7db4e0c3cdc55b2b628a460a063140 Author: msw <msw@chromium.org> Date: Wed Jan 18 20:30:28 2017 Add PropertyConverter support for non-zero default primitive values. Add non-zero PropertyConverterTest default primitive values. (the revised test fails without the fix in this CL) BUG= 681233 TEST=Automated; further mash work relies on this functionality. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2635983005 Cr-Commit-Position: refs/heads/master@{#444462} [modify] https://crrev.com/78697424ef7db4e0c3cdc55b2b628a460a063140/ui/aura/mus/property_converter.cc [modify] https://crrev.com/78697424ef7db4e0c3cdc55b2b628a460a063140/ui/aura/mus/property_converter.h [modify] https://crrev.com/78697424ef7db4e0c3cdc55b2b628a460a063140/ui/aura/mus/property_converter_unittest.cc
,
Jan 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc1ee54c6abd46f02adb02fcb119a553ee661a84 commit dc1ee54c6abd46f02adb02fcb119a553ee661a84 Author: msw <msw@chromium.org> Date: Sat Jan 28 00:56:25 2017 mash: Relay some Chrome aura window properties to Ash. Register ash window properties with Chrome's PropertyConverter. (register kPanelAttachedKey and kShelfItemTypeKey) Create MusPropertyMirror to copy properties to root windows (mash frames). Make DesktopWindowTreeHostMus surface content window prop changes. Implement an ash mirror with a best-guess set of properties to copy at first. BUG= 681233 TEST='chrome --mash' settings window title and shelf item are right. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2655513002 Cr-Commit-Position: refs/heads/master@{#446862} [modify] https://crrev.com/dc1ee54c6abd46f02adb02fcb119a553ee661a84/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc [modify] https://crrev.com/dc1ee54c6abd46f02adb02fcb119a553ee661a84/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h [modify] https://crrev.com/dc1ee54c6abd46f02adb02fcb119a553ee661a84/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/dc1ee54c6abd46f02adb02fcb119a553ee661a84/ui/views/mus/desktop_window_tree_host_mus.h [modify] https://crrev.com/dc1ee54c6abd46f02adb02fcb119a553ee661a84/ui/views/mus/mus_client.cc [modify] https://crrev.com/dc1ee54c6abd46f02adb02fcb119a553ee661a84/ui/views/mus/mus_client.h [add] https://crrev.com/dc1ee54c6abd46f02adb02fcb119a553ee661a84/ui/views/mus/mus_property_mirror.h
,
Jan 28 2017
This is generally fixed; other properties can be added to MusPropertyMirrorAsh (and the ash and chrome property converter instances) as needed. |
||
►
Sign in to add a comment |
||
Comment 1 by msw@chromium.org
, Jan 17 2017