New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681231 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Shape Detection: ConstructorCallWith=ExecutionContext

Project Member Reported by xianglu@chromium.org, Jan 14 2017

Issue description

In *Detector.idl, ConstructorCallWith=Document should be ConstructorCallWith=ExecutionContext, to work properly on a worker.

Shape Detection API Spec: https://wicg.github.io/shape-detection-api/#api
 
Cc: jochen@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa

commit 5314b70c4d6d2ae4ed6c7719bc5ac68861409baa
Author: xianglu <xianglu@chromium.org>
Date: Fri Jan 20 17:26:14 2017

Shape Detection: Remove ConstructorCallWith=Document

This CL moves FaceDetection, BarcodeDetection and TextDetection registration
to render_process_host_impl.cc. Now they no longer depend on |LocalFrame| to
get the interfaces. FaceDetection Java interface is registered in //content,
and the other two are still in //chrome.

BUG= 681231 
SPEC=https://wicg.github.io/shape-detection-api/#api
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2629523008
Cr-Commit-Position: refs/heads/master@{#445083}

[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionFactory.java
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/content/public/app/mojo/content_browser_manifest.json
[add] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/LayoutTests/shapedetection/detection-on-worker.html
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js
[add] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/LayoutTests/shapedetection/resources/worker.js
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.idl
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
[modify] https://crrev.com/5314b70c4d6d2ae4ed6c7719bc5ac68861409baa/third_party/WebKit/Source/modules/shapedetection/TextDetector.idl

Status: Fixed (was: Started)

Sign in to add a comment