New issue
Advanced search Search tips

Issue 681230 link

Starred by 1 user
Status: Fixed
Owner:
zmin@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests]:UnlockProfileAndHideLoginUI()

Project Member Reported by ligim...@chromium.org, Jan 14 2017 
Automated tests for the below commit have been missing.Would you mind adding tests to avoid regressions in future?

CL: 
https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb

Ref Bug: 
https://bugs.chromium.org/p/chromium/issues/detail?id=667227

Thank you!
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49f6220a80ff68d06c6c1c5179d0e494e0b8ad00

commit 49f6220a80ff68d06c6c1c5179d0e494e0b8ad00
Author: zmin <zmin@chromium.org>
Date: Fri Mar 24 18:58:58 2017

Allow sign in while browser is opened when force-sign-in policy is enabled.

Because force-sign-in policy won't force browser window closing before sign out when user is using Chrome,
force-sign-in policy will support sign in with browser opened.
Also add some browser test.

BUG= 642059 
BUG= 681230 
BUG= 682661 
BUG= 686743 

Review-Url: https://codereview.chromium.org/2760423002
Cr-Commit-Position: refs/heads/master@{#459501}

[modify] https://crrev.com/49f6220a80ff68d06c6c1c5179d0e494e0b8ad00/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/49f6220a80ff68d06c6c1c5179d0e494e0b8ad00/chrome/browser/ui/webui/signin/inline_login_handler_impl.h
[modify] https://crrev.com/49f6220a80ff68d06c6c1c5179d0e494e0b8ad00/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

Comment 2 by zmin@chromium.org, Apr 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment