[MD Settings - Sync settings page] Condense "Manage synced data" into one row |
||||||
Issue descriptionTo reproduce: (1) On a signed-in account, click Sync (2) Click the option "Manage synced data" "Opens Google Dashboard" Clicking this item opens a page called “Chrome Sync” Expected: (a) Use correct name to refer to that page. Which is correct: “Google Dashboard” or “Chrome Sync”? (b) Two lines isn’t necessary here. Recommend placing the info on one single line. “Managed synced data on [Google Dashboard | Chrome Sync]” (whatever correct name is)
,
Jan 14 2017
,
Jan 18 2017
(a) "Google Dashboard" is the correct name for the page. The "Google Dashboard" technically encompasses settings pages for lots of different products. The link is to the "Chrome Sync" settings page on the "Google Dashboard." We use "Google Dashboard" throughout the product and help center, so we should continue to use that title. (b) I defer to Alan about whether this should be on one or two lines. I could see "Manage synced data on the Google Dashboard" making sense and condensing the number of lines. But I defer to him.
,
Jan 19 2017
,
Feb 9 2017
(a) Thanks, Elliot, for clarifying. Looks like there was a conscious UI decision not to carry over the "Google Dashboard" name onto the individual pages linked from it. I'm still confused as to how the Google Dashboard and myactivity.google.com work together or are differentiated, but I will follow up offline about that. (b) I discussed this change w/Alan prior to filing this bug, and he approved it.
,
Feb 9 2017
Updating the title of the bug to reflect the request. To be clear, the request is to make the title of the row: Manage synced data on Google Dashboard Assigning to Tommy since he worked on this page previously. Feel free to re-assign as necessary. Removing the Milestone label too, since I don't think this is launch blocking.
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0c1afa12d5cc615038e3a88c65047814607bb99 commit e0c1afa12d5cc615038e3a88c65047814607bb99 Author: tommycli <tommycli@chromium.org> Date: Wed Apr 12 20:53:08 2017 MD Settings Sync: Remove secondary text from 'Manage Synced Data' link BUG= 681226 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2812233003 Cr-Commit-Position: refs/heads/master@{#464146} [modify] https://crrev.com/e0c1afa12d5cc615038e3a88c65047814607bb99/chrome/app/settings_strings.grdp [modify] https://crrev.com/e0c1afa12d5cc615038e3a88c65047814607bb99/chrome/browser/resources/settings/people_page/sync_page.html [modify] https://crrev.com/e0c1afa12d5cc615038e3a88c65047814607bb99/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Apr 12 2017
,
May 8 2017
Chrome OS 9532.0.0, 60.0.3092.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by srahim@chromium.org
, Jan 14 2017