New issue
Advanced search Search tips

Issue 681220 link

Starred by 1 user
Status: Archived
Owner:
benchan@chromium.org
Closed: Feb 2017
Cc:
harpreet@chromium.org
pprabhu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

CrOS: update cellular autotest control files

Project Member Reported by benchan@chromium.org, Jan 13 2017 
Update cellular autotest control files:

- Remove (obsolete):
  *.hefty
  *.wooly
  *.clumsy

- Add:
  *.huawei-me936
  *.altair-messi_v

- Rename (for more consistent naming):
  *.alt3100 -> *.altair-alt3100
  *.mu736 -> *.huawei-mu736
  *.e362 -> *.novatel-e362
  *.y3300 -> *.icera-y3300
  *.y3400 -> *.icera-y3400

we will need to keep old and new labels in lab machines for a while

Comment 1 by benchan@chromium.org, Jan 14 2017

Cc: harpreet@chromium.org
Status: Started (was: Assigned)

Comment 2 by pprabhu@chromium.org, Jan 14 2017 

Have you updated the DUTs in the lab with the labels already? Please loop in the current infra deputy (dshi@ next week) to do that.

Then I can review the rename CLs. Dropping obsolete files is OK.
What about the DUTs with those modems. We should return them to common inventory (if there are any).

Comment 3 by pprabhu@chromium.org, Jan 14 2017

Cc: pprabhu@chromium.org

Comment 4 by benchan@chromium.org, Jan 17 2017 

Re #2: Tried but kept having problem with atest (after installing labtools)

We will need to keep both sets of label for a while, so the first step is to apply new labels to the affected machines.

Comment 5 by benchan@chromium.org, Feb 3 2017 

pprabhu: DUTs are updated with new labels (with old labels preserved until we no longer schedule jobs based on old labels)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/78b214b8069040dcb1bc78b52ee672c261b13c68

commit 78b214b8069040dcb1bc78b52ee672c261b13c68
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 08:21:49 2017

network3g: rename control files from *.y3300 to *.icera-y3300

BUG= chromium:681220 
TEST=None

Change-Id: Ic25c7df0a67422516966dfc8fe027ca8cae62095
Reviewed-on: https://chromium-review.googlesource.com/428226
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[rename] https://crrev.com/78b214b8069040dcb1bc78b52ee672c261b13c68/client/site_tests/network_3GModemPresent/control.icera-y3300
[rename] https://crrev.com/78b214b8069040dcb1bc78b52ee672c261b13c68/client/site_tests/network_3GModemControl/control.icera-y3300
[rename] https://crrev.com/78b214b8069040dcb1bc78b52ee672c261b13c68/client/site_tests/network_3GSafetyDance/control.icera-y3300
[rename] https://crrev.com/78b214b8069040dcb1bc78b52ee672c261b13c68/client/site_tests/network_MobileSuspendResume/control.icera-y3300
[rename] https://crrev.com/78b214b8069040dcb1bc78b52ee672c261b13c68/client/site_tests/network_3GSmokeTest/control.icera-y3300
[rename] https://crrev.com/78b214b8069040dcb1bc78b52ee672c261b13c68/client/site_tests/network_3GStressEnable/control.icera-y3300
[rename] https://crrev.com/78b214b8069040dcb1bc78b52ee672c261b13c68/client/site_tests/network_3GIdentifiers/control.icera-y3300
[rename] https://crrev.com/78b214b8069040dcb1bc78b52ee672c261b13c68/client/site_tests/network_3GDisableWhileConnecting/control.icera-y3300
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2ca1569859a1fb537b7fb322731d662c93ac3ca3

commit 2ca1569859a1fb537b7fb322731d662c93ac3ca3
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 08:21:49 2017

network3g: rename control files from *.y3400 to *.icera-y3400

BUG= chromium:681220 
TEST=None

Change-Id: I27c9483c5338bf87388029c839d83ba01ecd3fc0
Reviewed-on: https://chromium-review.googlesource.com/428227
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[rename] https://crrev.com/2ca1569859a1fb537b7fb322731d662c93ac3ca3/client/site_tests/network_MobileSuspendResume/control.icera-y3400
[rename] https://crrev.com/2ca1569859a1fb537b7fb322731d662c93ac3ca3/client/site_tests/network_3GIdentifiers/control.icera-y3400
[rename] https://crrev.com/2ca1569859a1fb537b7fb322731d662c93ac3ca3/client/site_tests/network_3GSafetyDance/control.icera-y3400
[rename] https://crrev.com/2ca1569859a1fb537b7fb322731d662c93ac3ca3/client/site_tests/network_3GModemControl/control.icera-y3400
[rename] https://crrev.com/2ca1569859a1fb537b7fb322731d662c93ac3ca3/client/site_tests/network_3GModemPresent/control.icera-y3400
[rename] https://crrev.com/2ca1569859a1fb537b7fb322731d662c93ac3ca3/client/site_tests/network_3GSmokeTest/control.icera-y3400
[rename] https://crrev.com/2ca1569859a1fb537b7fb322731d662c93ac3ca3/client/site_tests/network_3GDisableWhileConnecting/control.icera-y3400
[rename] https://crrev.com/2ca1569859a1fb537b7fb322731d662c93ac3ca3/client/site_tests/network_3GStressEnable/control.icera-y3400
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4e819664955aedd1ee78537dd93f30c54b4d094f

commit 4e819664955aedd1ee78537dd93f30c54b4d094f
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 08:21:49 2017

network3g: rename control files from *.e362 to *.novatel-e362

BUG= chromium:681220 
TEST=None

Change-Id: If741d7c609685c15bf4a599fe0e39f5f11f9e7a9
Reviewed-on: https://chromium-review.googlesource.com/428228
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[rename] https://crrev.com/4e819664955aedd1ee78537dd93f30c54b4d094f/client/site_tests/network_3GSafetyDance/control.novatel-e362
[rename] https://crrev.com/4e819664955aedd1ee78537dd93f30c54b4d094f/client/site_tests/network_3GModemControl/control.novatel-e362
[rename] https://crrev.com/4e819664955aedd1ee78537dd93f30c54b4d094f/client/site_tests/network_3GIdentifiers/control.novatel-e362
[rename] https://crrev.com/4e819664955aedd1ee78537dd93f30c54b4d094f/client/site_tests/network_3GStressEnable/control.novatel-e362
[rename] https://crrev.com/4e819664955aedd1ee78537dd93f30c54b4d094f/client/site_tests/network_MobileSuspendResume/control.novatel-e362
[rename] https://crrev.com/4e819664955aedd1ee78537dd93f30c54b4d094f/client/site_tests/network_3GSmokeTest/control.novatel-e362
[rename] https://crrev.com/4e819664955aedd1ee78537dd93f30c54b4d094f/client/site_tests/network_3GModemPresent/control.novatel-e362
[rename] https://crrev.com/4e819664955aedd1ee78537dd93f30c54b4d094f/client/site_tests/network_3GDisableWhileConnecting/control.novatel-e362
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/66d057f2e25a0351e250f6f31a970273800f24c5

commit 66d057f2e25a0351e250f6f31a970273800f24c5
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 08:21:50 2017

network3g: rename control files from *.alt3100 to *.altair-alt3100

BUG= chromium:681220 
TEST=None

Change-Id: I58b6f01697cbd95f8e4768c017c5f7b210dabfe6
Reviewed-on: https://chromium-review.googlesource.com/428229
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[rename] https://crrev.com/66d057f2e25a0351e250f6f31a970273800f24c5/client/site_tests/network_3GSmokeTest/control.altair-alt3100
[rename] https://crrev.com/66d057f2e25a0351e250f6f31a970273800f24c5/client/site_tests/network_MobileSuspendResume/control.altair-alt3100
[rename] https://crrev.com/66d057f2e25a0351e250f6f31a970273800f24c5/client/site_tests/network_3GModemPresent/control.altair-alt3100
[rename] https://crrev.com/66d057f2e25a0351e250f6f31a970273800f24c5/client/site_tests/network_3GModemControl/control.altair-alt3100
[rename] https://crrev.com/66d057f2e25a0351e250f6f31a970273800f24c5/client/site_tests/network_3GSafetyDance/control.altair-alt3100
[rename] https://crrev.com/66d057f2e25a0351e250f6f31a970273800f24c5/client/site_tests/network_3GStressEnable/control.altair-alt3100
[rename] https://crrev.com/66d057f2e25a0351e250f6f31a970273800f24c5/client/site_tests/network_3GDisableWhileConnecting/control.altair-alt3100
[rename] https://crrev.com/66d057f2e25a0351e250f6f31a970273800f24c5/client/site_tests/network_3GIdentifiers/control.altair-alt3100
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/347ea3d29985d974473cd038f18c65422e453271

commit 347ea3d29985d974473cd038f18c65422e453271
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 08:21:50 2017

network3g: rename control files from *.mu736 to *.huawei-mu736

BUG= chromium:681220 
TEST=None

Change-Id: I9cc5fcbc1e0557829c9068461fcdf72c522a59d8
Reviewed-on: https://chromium-review.googlesource.com/428230
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[rename] https://crrev.com/347ea3d29985d974473cd038f18c65422e453271/client/site_tests/network_3GStressEnable/control.huawei-mu736
[rename] https://crrev.com/347ea3d29985d974473cd038f18c65422e453271/client/site_tests/network_3GSmokeTest/control.huawei-mu736
[rename] https://crrev.com/347ea3d29985d974473cd038f18c65422e453271/client/site_tests/network_3GSafetyDance/control.huawei-mu736
[rename] https://crrev.com/347ea3d29985d974473cd038f18c65422e453271/client/site_tests/network_3GModemControl/control.huawei-mu736
[rename] https://crrev.com/347ea3d29985d974473cd038f18c65422e453271/client/site_tests/network_MobileSuspendResume/control.huawei-mu736
[rename] https://crrev.com/347ea3d29985d974473cd038f18c65422e453271/client/site_tests/network_3GIdentifiers/control.huawei-mu736
[rename] https://crrev.com/347ea3d29985d974473cd038f18c65422e453271/client/site_tests/network_3GDisableWhileConnecting/control.huawei-mu736
[rename] https://crrev.com/347ea3d29985d974473cd038f18c65422e453271/client/site_tests/network_3GModemPresent/control.huawei-mu736
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/58e66c42c8158bfd5a21ee2e8c2142394f3948f0

commit 58e66c42c8158bfd5a21ee2e8c2142394f3948f0
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 08:21:50 2017

network3g: add control files for 'huawei-me936' modem

BUG= chromium:681220 
TEST=None

Change-Id: I01efbbc87f4730813f2bb49431cef54fe4e361d9
Reviewed-on: https://chromium-review.googlesource.com/428231
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[add] https://crrev.com/58e66c42c8158bfd5a21ee2e8c2142394f3948f0/client/site_tests/network_3GIdentifiers/control.huawei-me936
[add] https://crrev.com/58e66c42c8158bfd5a21ee2e8c2142394f3948f0/client/site_tests/network_3GStressEnable/control.huawei-me936
[add] https://crrev.com/58e66c42c8158bfd5a21ee2e8c2142394f3948f0/client/site_tests/network_3GDisableWhileConnecting/control.huawei-me936
[add] https://crrev.com/58e66c42c8158bfd5a21ee2e8c2142394f3948f0/client/site_tests/network_3GSafetyDance/control.huawei-me936
[add] https://crrev.com/58e66c42c8158bfd5a21ee2e8c2142394f3948f0/client/site_tests/network_3GModemControl/control.huawei-me936
[add] https://crrev.com/58e66c42c8158bfd5a21ee2e8c2142394f3948f0/client/site_tests/network_MobileSuspendResume/control.huawei-me936
[add] https://crrev.com/58e66c42c8158bfd5a21ee2e8c2142394f3948f0/client/site_tests/network_3GModemPresent/control.huawei-me936
[add] https://crrev.com/58e66c42c8158bfd5a21ee2e8c2142394f3948f0/client/site_tests/network_3GSmokeTest/control.huawei-me936
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/368c9fe3f89d18ee191048c96e72c9d68c8cecbc

commit 368c9fe3f89d18ee191048c96e72c9d68c8cecbc
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 08:21:51 2017

network3g: add control files for 'altair-messi_v' modem

BUG= chromium:681220 
TEST=None

Change-Id: I2d7e22cd7d145e3dbf29765cc64fa4f5bb0ba07e
Reviewed-on: https://chromium-review.googlesource.com/428232
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[add] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GDisableWhileConnecting/control.altair-messi_v
[add] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GModemPresent/control.altair-messi_v
[add] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GIdentifiers/control.altair-messi_v
[add] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GSafetyDance/control.altair-messi_v
[add] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GModemControl/control.altair-messi_v
[add] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_MobileSuspendResume/control.altair-messi_v
[add] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GStressEnable/control.altair-messi_v
[add] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GSmokeTest/control.altair-messi_v
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/197ee19f7e77f69a8fcd3453879ff50049cd48a8

commit 197ee19f7e77f69a8fcd3453879ff50049cd48a8
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 08:21:51 2017

network3g: remove obsolete control files for 'hefty' modem

BUG= chromium:681220 
TEST=None

Change-Id: I24189ebc47c4a15afe1a9281584ecfe2bfba7938
Reviewed-on: https://chromium-review.googlesource.com/428233
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[delete] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_MobileSuspendResume/control.hefty
[delete] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GDisableWhileConnecting/control.hefty
[delete] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GIdentifiers/control.hefty
[delete] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GStressEnable/control.hefty
[delete] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GModemPresent/control.hefty
[delete] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GSafetyDance/control.hefty
[delete] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GModemControl/control.hefty
[delete] https://crrev.com/368c9fe3f89d18ee191048c96e72c9d68c8cecbc/client/site_tests/network_3GSmokeTest/control.hefty
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5370bab98f1e78bf959501a6751d04190362de15

commit 5370bab98f1e78bf959501a6751d04190362de15
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 08:21:51 2017

network3g: remove obsolete control files for 'wooly' modem

BUG= chromium:681220 
TEST=None

Change-Id: Ia833a013bf2fac723e488a6aa12efe7f5a1a5e9b
Reviewed-on: https://chromium-review.googlesource.com/428234
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[delete] https://crrev.com/197ee19f7e77f69a8fcd3453879ff50049cd48a8/client/site_tests/network_MobileSuspendResume/control.wooly
[delete] https://crrev.com/197ee19f7e77f69a8fcd3453879ff50049cd48a8/client/site_tests/network_3GIdentifiers/control.wooly
[delete] https://crrev.com/197ee19f7e77f69a8fcd3453879ff50049cd48a8/client/site_tests/network_3GSmokeTest/control.wooly
[delete] https://crrev.com/197ee19f7e77f69a8fcd3453879ff50049cd48a8/client/site_tests/network_3GSafetyDance/control.wooly
[delete] https://crrev.com/197ee19f7e77f69a8fcd3453879ff50049cd48a8/client/site_tests/network_3GModemControl/control.wooly
[delete] https://crrev.com/197ee19f7e77f69a8fcd3453879ff50049cd48a8/client/site_tests/network_3GModemPresent/control.wooly
[delete] https://crrev.com/197ee19f7e77f69a8fcd3453879ff50049cd48a8/client/site_tests/network_3GDisableWhileConnecting/control.wooly
[delete] https://crrev.com/197ee19f7e77f69a8fcd3453879ff50049cd48a8/client/site_tests/network_3GStressEnable/control.wooly
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d240e0f1be8f4693be44fe241b79607138950820

commit d240e0f1be8f4693be44fe241b79607138950820
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 08:21:52 2017

network3g: remove obsolete control files for 'clumsy' modem

BUG= chromium:681220 
TEST=None

Change-Id: Ib3fc96a89e0a09105b441c7cf9ccefb537f0806c
Reviewed-on: https://chromium-review.googlesource.com/428235
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[delete] https://crrev.com/5370bab98f1e78bf959501a6751d04190362de15/client/site_tests/network_3GIdentifiers/control.clumsy
[delete] https://crrev.com/5370bab98f1e78bf959501a6751d04190362de15/client/site_tests/network_MobileSuspendResume/control.clumsy
[delete] https://crrev.com/5370bab98f1e78bf959501a6751d04190362de15/client/site_tests/network_3GModemPresent/control.clumsy
[delete] https://crrev.com/5370bab98f1e78bf959501a6751d04190362de15/client/site_tests/network_3GSmokeTest/control.clumsy
[delete] https://crrev.com/5370bab98f1e78bf959501a6751d04190362de15/client/site_tests/network_3GDisableWhileConnecting/control.clumsy
[delete] https://crrev.com/5370bab98f1e78bf959501a6751d04190362de15/client/site_tests/network_3GStressEnable/control.clumsy
[delete] https://crrev.com/5370bab98f1e78bf959501a6751d04190362de15/client/site_tests/network_3GModemControl/control.clumsy
[delete] https://crrev.com/5370bab98f1e78bf959501a6751d04190362de15/client/site_tests/network_3GSafetyDance/control.clumsy

Comment 16 by benchan@chromium.org, Feb 8 2017

Status: Fixed (was: Started)

Comment 17 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 18 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 19 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 20 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
►

Sign in to add a comment