New issue
Advanced search Search tips

Issue 681212 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug


Participants' hotlists:
dmurph-iterative-side-tasks

Show other hotlists

Other hotlists containing this issue:
IDB-Performance


Sign in to add a comment

IndexedDB: Avoid copying values for every operation

Project Member Reported by dmu...@chromium.org, Jan 13 2017

Issue description

We do memory copies like this:
https://cs.chromium.org/chromium/src/content/browser/indexed_db/indexed_db_backing_store.cc?q=indexed_db_backing_store.h&dr=C&l=1959

For every IndexedDB operation that involves a value (for writes AND reads). This can cause a lot of memory fragmentation and general performance issues. Can we avoid this?


Proposal:
Put the Int version into the IndexedDBValue struct itself, so we can just save this buffer directly (and read it directly) instead of doing all the copying.
 

Comment 1 by jsb...@chromium.org, Jan 14 2017

Do we have tools to measure heap thrashing? It'd be nice to measure before/after and/or look for other hot spots in the code.

Comment 2 by dmu...@chromium.org, Jan 17 2017

Cc: dmu...@chromium.org
+cc me
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 15 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by jsb...@chromium.org, Feb 20 2018

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Sign in to add a comment