New issue
Advanced search Search tips

Issue 681194 link

Starred by 1 user
Status: WontFix
Owner:
dgarr...@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

We shouldn't do work in _Finish on any build stage.

Project Member Reported by dgarr...@chromium.org, Jan 13 2017 
Errors in _Finish are handled badly:
   crbug.com/680248 

I worked around it here:
  https://chromium-review.googlesource.com/#/c/427384/

We should instead have those stages do this work in Perform and just get rid of _Finish().

Comment 1 by dshi@chromium.org, Jan 23 2017

Labels: -current-issue
Owner: dgarr...@chromium.org
dgarrett, can you find an owner for the bug or leave this as fixit?

Comment 2 by dgarr...@chromium.org, Jan 23 2017

Status: Assigned (was: Untriaged)

Comment 3 by dgarr...@chromium.org, Jan 31 2017

Status: WontFix (was: Assigned)
I've changed my mind on this.

I'm going to keep _Finish (well, rename it Finish), but handle and ignore errors in it.

Will fix on  crbug.com/680248
►

Sign in to add a comment