New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681184 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

git-cl should populate "Bug: " instead of "BUG=" for gerrit uploads

Project Member Reported by aga...@chromium.org, Jan 13 2017

Issue description

This will get people into the right mindset for gerrit CLs.
 

Comment 1 by aga...@chromium.org, Feb 23 2017

Owner: aga...@chromium.org
Status: Started (was: Available)
https://chromium-review.googlesource.com/446660
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/3a16ed155e3f7ac56db71f207d5779fc97c3bae8

commit 3a16ed155e3f7ac56db71f207d5779fc97c3bae8
Author: Aaron Gable <agable@chromium.org>
Date: Thu Mar 23 18:54:46 2017

Use Bug: footer for Gerrit CLs

Note that because it is now a gerrit footer, it both appears in the same block
as the Change-Id footer (no blank line between them), and isn't guaranteed to be
above the Change-Id footer. This doesn't matter during "git cl upload", when
a Change-Id hasn't been allocated yet, but will show up during "git cl
description".

Bug:  681184 
Change-Id: I2ab6fc13be8e992709618a666012410b1a7c02de
Reviewed-on: https://chromium-review.googlesource.com/446660
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/3a16ed155e3f7ac56db71f207d5779fc97c3bae8/tests/git_cl_test.py
[modify] https://crrev.com/3a16ed155e3f7ac56db71f207d5779fc97c3bae8/git_cl.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/449dfc4b5dc15a61acad73472238d2e60fd299f3

commit 449dfc4b5dc15a61acad73472238d2e60fd299f3
Author: Mark Mentovai <mark@chromium.org>
Date: Tue Mar 28 17:49:50 2017

Remove BUG_LINE_FORMAT from codereview.settings

The Bug: style (a Gerrit footer) is used by git-cl for Gerrit changes as
of 3a16ed155e3f.

Bug:  chromium:681184 
Change-Id: I58c29b6908aee57c7f03374180148f241af91b22
Reviewed-on: https://chromium-review.googlesource.com/461481
Reviewed-by: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/449dfc4b5dc15a61acad73472238d2e60fd299f3/codereview.settings

Status: Fix (was: Started)
Status: Fixed (was: Fix)

Comment 6 by rmis...@google.com, Apr 10 2017

Has bugdroid need updated to look at 'Bug:'?
Some Skia CLs have 'Bug:' but the referenced issues are not updated. Eg: https://chromium-review.googlesource.com/c/446660/
You may need to update which bug prefixes to look for in bugdroid config. However, I don't know where it is. 

Comment 8 by aga...@chromium.org, Apr 11 2017

It should recognize "Bug: NNN" footers since 10 months ago: https://chromium.googlesource.com/infra/infra/+/302e6e72321292f4c537d20f2cdca6c3a6e5af7c

I have evidence here that it does:
https://chromium-review.googlesource.com/c/470167/
https://bugs.chromium.org/p/chromium/issues/detail?id=601228#c8

Not sure why the skia bug didn't get updated. Probably just related to other bugdroid flakiness tracked here:
https://bugs.chromium.org/p/chromium/issues/detail?id=703548

Comment 9 by rmis...@google.com, Apr 11 2017

Cc: benjamin...@chromium.org
Yes looks like you are right, I did see "Bug: NNN" work on some issues.

Separate topic: Since we made "BUG=" Gerrity we should also support "NoTry:", "TBR:", etc in the CQ. Seeing a combination of the two styles is very confusing (benjaminwagner@ ran into this today).
rmistry@ I think I've already made CQ recognize No-Try No-Presubmit. However, I didn't teach presubmit support, so TBR: might still not work :( 
And I was correct right above, machenbach@ has independently filed  issue 710803  exact for presubmit support :(

Sign in to add a comment