New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681180 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Check failed: histogram->HasConstructionArguments() for MemoryAndroid.LowMemoryTimeBetween

Project Member Reported by dougarnett@chromium.org, Jan 13 2017

Issue description

Chrome Version: ToT
OS: Android 4.4.2
RAM: 512mb

Encountered the following histogram CHECK crash during background loading evaluation run. The histogram call code is over a year old so not sure why triggering now (was able to do many long running evals on same device a couple weeks ago without crashing).


01-13 16:10:37.016 F/chromium( 1651): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). M
emoryAndroid.LowMemoryTimeBetween/0/600000/50 vs. MemoryAndroid.LowMemoryTimeBetween/1/600000/50
01-13 16:10:37.016 F/chromium( 1651): #00 0x62c2a64f /data/app-lib/org.chromium.chrome-1/libbase.cr.so+0x0009d64f
01-13 16:10:37.016 F/chromium( 1651): #01 0x62c0a747 /data/app-lib/org.chromium.chrome-1/libbase.cr.so+0x0007d747
01-13 16:10:37.016 F/chromium( 1651): #02 0x62c0a7f5 /data/app-lib/org.chromium.chrome-1/libbase.cr.so+0x0007d7f5
01-13 16:10:37.016 F/chromium( 1651): #03 0x62c0ad3f /data/app-lib/org.chromium.chrome-1/libbase.cr.so+0x0007dd3f
01-13 16:10:37.016 F/chromium( 1651): #04 0x4193894f /system/lib/libdvm.so+0x0001e94f
01-13 16:10:37.016 F/chromium( 1651): #05 0x41969fdb /system/lib/libdvm.so+0x0004ffdb
01-13 16:10:37.016 F/chromium( 1651): #06 0x41941d2b /system/lib/libdvm.so+0x00027d2b
01-13 16:10:37.016 F/chromium( 1651): #07 0x4194942f /system/lib/libdvm.so+0x0002f42f
01-13 16:10:37.016 F/chromium( 1651): #08 0x41946913 /system/lib/libdvm.so+0x0002c913
01-13 16:10:37.016 F/chromium( 1651): #09 0x4197d7cb /system/lib/libdvm.so+0x000637cb
01-13 16:10:37.016 F/chromium( 1651): #10 0x41985d8d /system/lib/libdvm.so+0x0006bd8d
01-13 16:10:37.016 F/chromium( 1651): #11 0x41941d2b /system/lib/libdvm.so+0x00027d2b
01-13 16:10:37.016 F/chromium( 1651): #12 0x4194942f /system/lib/libdvm.so+0x0002f42f
01-13 16:10:37.016 F/chromium( 1651): #13 0x41946913 /system/lib/libdvm.so+0x0002c913
01-13 16:10:37.016 F/chromium( 1651): #14 0x4197d47f /system/lib/libdvm.so+0x0006347f
01-13 16:10:37.016 F/chromium( 1651): #15 0x41965843 /system/lib/libdvm.so+0x0004b843
01-13 16:10:37.016 F/chromium( 1651): #16 0x4020314f /system/lib/libandroid_runtime.so+0x0004f14f
01-13 16:10:37.016 F/chromium( 1651): #17 0x40203efd /system/lib/libandroid_runtime.so+0x0004fefd
01-13 16:10:37.016 F/chromium( 1651): #18 0x4007d065 /system/bin/app_process+0x00001065
01-13 16:10:37.016 F/chromium( 1651): #19 0x400bb31f /system/lib/libc.so+0x0000f31f
01-13 16:10:37.016 F/chromium( 1651): #20 0x4007cd83 /system/bin/app_process+0x00000d83
 
Status: Assigned (was: Untriaged)
Components: Internals>Metrics
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e1108687b5138bd546120a861d730b8b5268342

commit 0e1108687b5138bd546120a861d730b8b5268342
Author: romax <romax@chromium.org>
Date: Tue Feb 07 19:54:00 2017

Fixing mismatch between expected and declared minimum values.

All the declared minimum values defined in Java histograms will be silently
changed to 1 if it was 0 for CustomTimesHistogram. Adding the same check
used in c++ histograms to change the value before calling CheckHistogramArgs.
This would avoid a DCHECK described in the bug.

BUG= 681180 

Review-Url: https://codereview.chromium.org/2675883002
Cr-Commit-Position: refs/heads/master@{#448705}

[modify] https://crrev.com/0e1108687b5138bd546120a861d730b8b5268342/base/android/record_histogram.cc

Comment 4 by romax@chromium.org, Feb 23 2017

Status: Fixed (was: Assigned)

Sign in to add a comment