New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681168 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mash: Crash hiding app list

Project Member Reported by msw@chromium.org, Jan 13 2017

Issue description

mash: Crash hiding app list
On ToT @ #443627 having built 'chrome' and 'mash:all' (debug):
(1) Run chrome --mash
(2) Click the app list icon; the app list window will show.
(3) Click the app list icon again.
Expected: App list window hides.
Actual: Crash. Callstacks below; perhaps only the first one is related?

Received signal 11 <unknown> 000000000000
#0 0x7f95c8ba394e base::debug::StackTrace::StackTrace()
#1 0x7f95c8ba348f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f95c8fdf330 <unknown>
#3 0x7f95a3ca1a4f <unknown>
#4 0x7f95a3c9da47 <unknown>
#5 0x7f95a3ca481f <unknown>
#6 0x7f95c06e326d gl::GLApiBase::glClearFn()
#7 0x7f95c09de17f gpu::gles2::GLES2DecoderImpl::DoClear()
#8 0x7f95c09a3749 gpu::gles2::GLES2DecoderImpl::HandleClear()
#9 0x7f95c0a0c5f2 gpu::gles2::GLES2DecoderImpl::DoCommandsImpl<>()
#10 0x7f95c09d6475 gpu::gles2::GLES2DecoderImpl::DoCommands()
#11 0x7f95c0955a1b gpu::CommandParser::ProcessCommands()
#12 0x7f95c095890d gpu::CommandExecutor::PutChanged()
#13 0x7f95c0b6cf47 gpu::InProcessCommandBuffer::PumpCommandsOnGpuThread()
#14 0x7f95c0ae7e77 _ZN4base8internal13FunctorTraitsIMN3gpu5gles229AsyncReadPixelsCompletedQueryEFvvEvE6InvokeIRKNS_7WeakPtrIS4_EEJEEEvS6_OT_DpOT0_
#15 0x7f95c0b7843a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN3gpu22InProcessCommandBufferEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_
#16 0x7f95c0b783c2 _ZN4base8internal7InvokerINS0_9BindStateIMN3gpu22InProcessCommandBufferEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#17 0x7f95c0b7830c _ZN4base8internal7InvokerINS0_9BindStateIMN3gpu22InProcessCommandBufferEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#18 0x7f95c0957cab base::internal::RunMixin<>::Run()
#19 0x7f95c09566ff gpu::CommandBufferService::Flush()
#20 0x7f95c0b702ce gpu::InProcessCommandBuffer::FlushOnGpuThread()
#21 0x7f95c0b7b7fe _ZN4base8internal13FunctorTraitsIMN3gpu22InProcessCommandBufferEFviEvE6InvokeIRKNS_7WeakPtrIS3_EEJRKiEEEvS5_OT_DpOT0_
#22 0x7f95c0b7b70f _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN3gpu22InProcessCommandBufferEFviERKNS_7WeakPtrIS5_EEJRKiEEEvOT_OT0_DpOT1_
#23 0x7f95c0b7b683 _ZN4base8internal7InvokerINS0_9BindStateIMN3gpu22InProcessCommandBufferEFviEJNS_7WeakPtrIS4_EEiEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_iEEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#24 0x7f95c0b7b59c _ZN4base8internal7InvokerINS0_9BindStateIMN3gpu22InProcessCommandBufferEFviEJNS_7WeakPtrIS4_EEiEEEFvvEE3RunEPNS0_13BindStateBaseE
#25 0x7f95c0957cab base::internal::RunMixin<>::Run()
#26 0x7f95c0b70013 gpu::InProcessCommandBuffer::ProcessTasksOnGpuThread()
#27 0x7f95c0ae7e77 _ZN4base8internal13FunctorTraitsIMN3gpu5gles229AsyncReadPixelsCompletedQueryEFvvEvE6InvokeIRKNS_7WeakPtrIS4_EEJEEEvS6_OT_DpOT0_
#28 0x7f95c0b7843a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN3gpu22InProcessCommandBufferEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_
#29 0x7f95c0b783c2 _ZN4base8internal7InvokerINS0_9BindStateIMN3gpu22InProcessCommandBufferEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#30 0x7f95c0b7830c _ZN4base8internal7InvokerINS0_9BindStateIMN3gpu22InProcessCommandBufferEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#31 0x7f95c8ba8f11 _ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv
#32 0x7f95c8ba88f9 base::debug::TaskAnnotator::RunTask()
#33 0x7f95c8c313ef base::MessageLoop::RunTask()
#34 0x7f95c8c31654 base::MessageLoop::DeferOrRunPendingTask()
#35 0x7f95c8c3193e base::MessageLoop::DoWork()
#36 0x7f95c8c47b7c base::MessagePumpLibevent::Run()
#37 0x7f95c8c30fb5 base::MessageLoop::RunHandler()
#38 0x7f95c8cd1a79 base::RunLoop::Run()
#39 0x7f95c8d70e39 base::Thread::Run()
#40 0x7f95c8d71711 base::Thread::ThreadMain()
#41 0x7f95c8d5958a base::(anonymous namespace)::ThreadFunc()
#42 0x7f95c8fd7184 start_thread
#43 0x7f95b321e37d clone
  r8: 0000000000000001  r9: 00007f95a9da4008 r10: 0000000000000000 r11: 00007f95b32aa390
 r12: 00000748788c6220 r13: 0000000000000000 r14: 0000074882d55140 r15: 0000000000000001
  di: 000007487e361040  si: 000007487d866200  bp: 00000748752c29b0  bx: 000007487d866200
  dx: 0000000000000688  ax: 000007487e361040  cx: 0000074874a75f00  sp: 00007f95a9da4060
  ip: 00007f95a3ca1a4f efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000000
 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
[2021:2021:0113/132929.966686:3376221420658:ERROR:wm_shell_mus.cc(399)] Not implemented reached in virtual void ash::mus::WmShellMus::RemoveDisplayObserver(ash::WmDisplayObserver *)
[2013:2017:0113/132930.007183:3376221461156:INFO:service_process_launcher.cc(211)] Launched child process pid=2431, instance=c23d2828-70cc-4c4d-8c2a-8eb365dcce13, name=chrome_mash, user_id=8bc2d44c-32db-4659-b82a-d6d2c8f85e71
Created new window in existing browser session.
[2021:2021:0113/132930.076210:3376221530175:FATAL:window_tree_client.cc(319)] Check failed: !change->window() || windows_.count(change->window()->server_id()) > 0. 
#0 0x7f3cb157c94e base::debug::StackTrace::StackTrace()
#1 0x7f3cb15e333c logging::LogMessage::~LogMessage()
#2 0x7f3ca3891cb0 aura::WindowTreeClient::ScheduleInFlightChange()
#3 0x7f3ca38949a7 aura::WindowTreeClient::OnWindowMusRemoveChild()
#4 0x7f3ca3888d7c aura::WindowPortMus::OnWillRemoveChild()
#5 0x7f3ca38c3478 aura::Window::RemoveChild()
#6 0x7f3ca38c2cbc aura::Window::~Window()
#7 0x7f3ca38c3579 aura::Window::~Window()
#8 0x7f3ca38c3215 aura::Window::RemoveOrDestroyChildren()
#9 0x7f3ca38c2c91 aura::Window::~Window()
#10 0x7f3ca38c3579 aura::Window::~Window()
#11 0x7f3ca3890bc9 aura::WindowTreeClient::~WindowTreeClient()
#12 0x7f3ca3891039 aura::WindowTreeClient::~WindowTreeClient()
#13 0x7f3cb259a7bf std::default_delete<>::operator()()
#14 0x7f3cb41ed9fc std::unique_ptr<>::reset()
#15 0x7f3cb41e8690 ash::mus::WindowManager::Shutdown()
#16 0x7f3cb41e9ded ash::mus::WindowManager::OnLostConnection()
#17 0x7f3ca3893678 aura::WindowTreeClient::OnConnectionLost()
#18 0x7f3ca38b1b47 _ZN4base8internal13FunctorTraitsIMN4aura16WindowTreeClientEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_
#19 0x7f3ca38b1aba _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN4aura16WindowTreeClientEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_
#20 0x7f3ca38b1a42 _ZN4base8internal7InvokerINS0_9BindStateIMN4aura16WindowTreeClientEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#21 0x7f3ca38b198c _ZN4base8internal7InvokerINS0_9BindStateIMN4aura16WindowTreeClientEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#22 0x7f3cb1d5af3b base::internal::RunMixin<>::Run()
#23 0x7f3cb1d68006 mojo::InterfaceEndpointClient::NotifyError()
#24 0x7f3cb1d7918f mojo::internal::MultiplexRouter::ProcessNotifyErrorTask()
#25 0x7f3cb1d76d85 mojo::internal::MultiplexRouter::ProcessTasks()
#26 0x7f3cb1d79760 mojo::internal::MultiplexRouter::LockAndCallProcessTasks()
#27 0x7f3cb1d82b77 _ZN4base8internal13FunctorTraitsIMN4mojo8internal15MultiplexRouterEFvvEvE6InvokeIRK13scoped_refptrIS4_EJEEEvS6_OT_DpOT0_
#28 0x7f3cb1d82ac1 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo8internal15MultiplexRouterEFvvEJRK13scoped_refptrIS6_EEEEvOT_DpOT0_
#29 0x7f3cb1d82a62 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo8internal15MultiplexRouterEFvvEJ13scoped_refptrIS5_EEEEFvvEE7RunImplIRKS7_RKSt5tupleIJS9_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#30 0x7f3cb1d829ac _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo8internal15MultiplexRouterEFvvEJ13scoped_refptrIS5_EEEEFvvEE3RunEPNS0_13BindStateBaseE
#31 0x7f3cb1581f11 _ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv
#32 0x7f3cb15818f9 base::debug::TaskAnnotator::RunTask()
#33 0x7f3cb160a3ef base::MessageLoop::RunTask()
#34 0x7f3cb160a654 base::MessageLoop::DeferOrRunPendingTask()
#35 0x7f3cb160a93e base::MessageLoop::DoWork()
#36 0x7f3cb1620b7c base::MessagePumpLibevent::Run()
#37 0x7f3cb1609fb5 base::MessageLoop::RunHandler()
#38 0x7f3cb16aaa79 base::RunLoop::Run()
#39 0x7f3cb25a0af3 MashRunner::StartChildApp()
#40 0x7f3cb25a76da _ZN4base8internal13FunctorTraitsIM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEvE6InvokeIPS2_JS8_EEEvSA_OT_DpOT0_
#41 0x7f3cb25a75d6 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEJPS4_SA_EEEvOT_DpOT0_
#42 0x7f3cb25a7567 _ZN4base8internal7InvokerINS0_9BindStateIM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEJNS0_17UnretainedWrapperIS3_EEEEEFvS9_EE7RunImplIRKSB_RKSt5tupleIJSD_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOS9_
#43 0x7f3cb25a749c _ZN4base8internal7InvokerINS0_9BindStateIM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEJNS0_17UnretainedWrapperIS3_EEEEEFvS9_EE3RunEPNS0_13BindStateBaseEOS9_
#44 0x7f3cb25b9b83 base::internal::RunMixin<>::Run()
#45 0x7f3cb425d0d9 service_manager::RunStandaloneService()
#46 0x7f3cb259fe80 MashRunner::RunChild()
#47 0x7f3cb259fd4b MashRunner::Run()
#48 0x7f3cb25a0c1c MashMain()
#49 0x7f3cb2597f28 ChromeMain
#50 0x7f3cb2597e22 main
#51 0x7f3c9bb1ef45 __libc_start_main
#52 0x7f3cb2597d25 <unknown>

Received signal 6
#0 0x7f3cb157c94e base::debug::StackTrace::StackTrace()
#1 0x7f3cb157c48f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f3cb19b8330 <unknown>
#3 0x7f3c9bb33c37 gsignal
#4 0x7f3c9bb37028 abort
#5 0x7f3cb1578f26 base::debug::(anonymous namespace)::DebugBreak()
#6 0x7f3cb1578f08 base::debug::BreakDebugger()
#7 0x7f3cb15e36df logging::LogMessage::~LogMessage()
#8 0x7f3ca3891cb0 aura::WindowTreeClient::ScheduleInFlightChange()
#9 0x7f3ca38949a7 aura::WindowTreeClient::OnWindowMusRemoveChild()
#10 0x7f3ca3888d7c aura::WindowPortMus::OnWillRemoveChild()
#11 0x7f3ca38c3478 aura::Window::RemoveChild()
#12 0x7f3ca38c2cbc aura::Window::~Window()
#13 0x7f3ca38c3579 aura::Window::~Window()
#14 0x7f3ca38c3215 aura::Window::RemoveOrDestroyChildren()
#15 0x7f3ca38c2c91 aura::Window::~Window()
#16 0x7f3ca38c3579 aura::Window::~Window()
#17 0x7f3ca3890bc9 aura::WindowTreeClient::~WindowTreeClient()
#18 0x7f3ca3891039 aura::WindowTreeClient::~WindowTreeClient()
#19 0x7f3cb259a7bf std::default_delete<>::operator()()
#20 0x7f3cb41ed9fc std::unique_ptr<>::reset()
#21 0x7f3cb41e8690 ash::mus::WindowManager::Shutdown()
#22 0x7f3cb41e9ded [2050:2050:0113/132930.165100:FATAL:note_taking_helper.cc(93)] Check failed: g_helper. 
#0 0x7f52db54294e base::debug::StackTrace::StackTrace()
#1 0x7f52db5a933c logging::LogMessage::~LogMessage()
#2 0x7f52dd59c71d chromeos::NoteTakingHelper::Shutdown()
#3 0x7f52dd201cf0 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun()
#4 0x7f52d4de1e9e content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
#5 0x7f52d4def5d1 content::BrowserMainRunnerImpl::Shutdown()
#6 0x7f52d4ddb325 content::BrowserMain()
#7 0x7f52d64dcff6 content::RunNamedProcessTypeMain()
#8 0x7f52d64df1ee content::ContentMainRunnerImpl::Run()
#9 0x7f52d64dc422 content::ContentMain()
#10 0x7f52dc55df66 ChromeMain
#11 0x7f52dc55de22 main
#12 0x7f52c5ae4f45 __libc_start_main
#13 0x7f52dc55dd25 <unknown>

ash::mus::WindowManager::OnLostConnection()
#23 0x7f3ca3893678 aura::WindowTreeClient::OnConnectionLost()
#24 0x7f3ca38b1b47 _ZN4base8internal13FunctorTraitsIMN4aura16WindowTreeClientEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_
#25 0x7f3ca38b1aba _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN4aura16WindowTreeClientEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_
#26 0x7f3ca38b1a42 _ZN4base8internal7InvokerINS0_9BindStateIMN4aura16WindowTreeClientEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#27 0x7f3ca38b198c _ZN4base8internal7InvokerINS0_9BindStateIMN4aura16WindowTreeClientEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#28 0x7f3cb1d5af3b base::internal::RunMixin<>::Run()
#29 0x7f3cb1d68006 mojo::InterfaceEndpointClient::NotifyError()
#30 0x7f3cb1d7918f mojo::internal::MultiplexRouter::ProcessNotifyErrorTask()
#31 0x7f3cb1d76d85 mojo::internal::MultiplexRouter::ProcessTasks()
#32 0x7f3cb1d79760 mojo::internal::MultiplexRouter::LockAndCallProcessTasks()
#33 0x7f3cb1d82b77 _ZN4base8internal13FunctorTraitsIMN4mojo8internal15MultiplexRouterEFvvEvE6InvokeIRK13scoped_refptrIS4_EJEEEvS6_OT_DpOT0_
#34 0x7f3cb1d82ac1 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo8internal15MultiplexRouterEFvvEJRK13scoped_refptrIS6_EEEEvOT_DpOT0_
#35 0x7f3cb1d82a62 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo8internal15MultiplexRouterEFvvEJ13scoped_refptrIS5_EEEEFvvEE7RunImplIRKS7_RKSt5tupleIJS9_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#36 0x7f3cb1d829ac _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo8internal15MultiplexRouterEFvvEJ13scoped_refptrIS5_EEEEFvvEE3RunEPNS0_13BindStateBaseE
#37 0x7f3cb1581f11 _ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv
#38 0x7f3cb15818f9 base::debug::TaskAnnotator::RunTask()
#39 0x7f3cb160a3ef base::MessageLoop::RunTask()
#40 0x7f3cb160a654 base::MessageLoop::DeferOrRunPendingTask()
#41 0x7f3cb160a93e base::MessageLoop::DoWork()
#42 0x7f3cb1620b7c base::MessagePumpLibevent::Run()
#43 0x7f3cb1609fb5 base::MessageLoop::RunHandler()
#44 0x7f3cb16aaa79 base::RunLoop::Run()
#45 0x7f3cb25a0af3 MashRunner::StartChildApp()
#46 0x7f3cb25a76da _ZN4base8internal13FunctorTraitsIM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEvE6InvokeIPS2_JS8_EEEvSA_OT_DpOT0_
#47 0x7f3cb25a75d6 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEJPS4_SA_EEEvOT_DpOT0_
#48 0x7f3cb25a7567 _ZN4base8internal7InvokerINS0_9BindStateIM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEJNS0_17UnretainedWrapperIS3_EEEEEFvS9_EE7RunImplIRKSB_RKSt5tupleIJSD_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOS9_
#49 0x7f3cb25a749c _ZN4base8internal7InvokerINS0_9BindStateIM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEJNS0_17UnretainedWrapperIS3_EEEEEFvS9_EE3RunEPNS0_13BindStateBaseEOS9_
#50 0x7f3cb25b9b83 base::internal::RunMixin<>::Run()
#51 0x7f3cb425d0d9 service_manager::RunStandaloneService()
#52 0x7f3cb259fe80 MashRunner::RunChild()
#53 0x7f3cb259fd4b MashRunner::Run()
#54 0x7f3cb25a0c1c MashMain()
#55 0x7f3cb2597f28 ChromeMain
#56 0x7f3cb2597e22 main
#57 0x7f3c9bb1ef45 __libc_start_main
#58 0x7f3cb2597d25 <unknown>
  r8: fffffffffffffec8  r9: 000000142d7d6cc8 r10: 0000000000000008 r11: 0000000000000202
 r12: 00007f3cb2597cfc r13: 00007ffc2d7db750 r14: 0000000000000000 r15: 0000000000000000
  di: 00000000000007e5  si: 00000000000007e5  bp: 00007ffc2d7d7170  bx: 00007f3ca3b8fd40
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007ffc2d7d7038
  ip: 00007f3c9bb33c37 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

 

Comment 1 by sky@chromium.org, Jan 13 2017

Cc: fsam...@chromium.org
Labels: -Pri-3 Pri-2
I've been seeing this off and on and random points too. I'm currently trying to get immersive working and have occasionally seen this come up.

Comment 2 by sky@chromium.org, Jan 17 2017

Labels: -Pri-2 Pri-1
I'm bumping this to a 1 as I seem to trip over it fairly regularly.

Comment 3 by sky@chromium.org, Jan 20 2017

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15ef0aa9060364567a6cf2abd20f6d419619cc83

commit 15ef0aa9060364567a6cf2abd20f6d419619cc83
Author: sky <sky@chromium.org>
Date: Fri Jan 20 18:55:59 2017

Adds AppListDelegate to AppList that is notified on visibility changes

For mash chrome shows the app-list. Mash needs to inform the
AppListButton when the visibility changes otherwise the ink drop
animations checks. To address this ash installs an AppListDelegate
that is notified on visibility changes so that it can update the
button.

BUG= 681168 
TEST=none
R=xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2647833003
Cr-Commit-Position: refs/heads/master@{#445111}

[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ash/BUILD.gn
[add] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ash/app_list/app_list_delegate_impl.cc
[add] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ash/app_list/app_list_delegate_impl.h
[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ash/shell.cc
[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ash/shell.h
[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ui/app_list/presenter/BUILD.gn
[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ui/app_list/presenter/app_list.cc
[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ui/app_list/presenter/app_list.h
[add] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ui/app_list/presenter/app_list_delegate.h
[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ui/app_list/presenter/app_list_presenter.mojom
[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/15ef0aa9060364567a6cf2abd20f6d419619cc83/ui/app_list/presenter/app_list_presenter_impl.h

Comment 5 by sky@chromium.org, Jan 20 2017

Status: Fixed (was: Started)

Comment 6 by msw@chromium.org, Jan 22 2017

Thanks for fixing this; I wonder why the stack I found was so apparently unrelated.

Comment 7 by sky@chromium.org, Jan 23 2017

I suspect we haven't seen the last of this, although I could be wrong.

For some reason I've noticed that chrome will often times crash and not dump a stack. It may be that chrome was crashing, and it's the chrome crash that lead to the instability...
I think the gpu crash was a result of the app list related crash but I'm not certain because I wasn't able to repro this.

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment