New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 681151 link

Starred by 2 users
Status: WontFix
Owner:
mattreynolds@chromium.org
Closed: Nov 2017
Cc:
█ cco3@chromium.org
█ animohan@chromium.org
█ scottj@chromium.org
█ mmo...@chromium.org
mattreynolds@chromium.org
█ rzhao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

chrome://physical-web WebUI page Identical results should be deduplicated

Project Member Reported by mattreynolds@chromium.org, Jan 13 2017 
Chrome Version: 57.0.2981.0 (ToT)
OS: Android 7.1.2

What steps will reproduce the problem?
(0) Enable the Physical Web in Chrome for Android
(1) Configure two Physical Web beacons with the urls "http://cf.physical-web.org" and "http://c.pw3b.com".
(2) Navigate to chrome://physical-web

What is the expected result?

Only one result should be shown for the configuration page since both URLs redirect to the same final page.

What happens instead?

Two results are shown. (See attached screenshot)
Screenshot_20170113-123323.png
321 KB View Download

Comment 1 by rsgav...@chromium.org, Jan 25 2017

Status: Assigned (was: Untriaged)

Comment 2 by mattreynolds@chromium.org, Jan 31 2017

Status: Started (was: Assigned)

Comment 3 by mmo...@chromium.org, Feb 6 2017 

Issue 688368 has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1033377d9030c718bfaa1ecda9cbc01129fe7e7a

commit 1033377d9030c718bfaa1ecda9cbc01129fe7e7a
Author: mattreynolds <mattreynolds@chromium.org>
Date: Mon Feb 06 19:34:14 2017

Deduplicate Physical Web results with matching group IDs

When multiple Physical Web URLs are nearby and the broadcast URLs resolve
to the same or similar pages, only notify clients about the closest
instance of that URL. We identify similar pages via group ID, which is
constructed from the resolved URL (omitting any fragment), page title,
and page description.

BUG= 681151 

Review-Url: https://codereview.chromium.org/2669603003
Cr-Commit-Position: refs/heads/master@{#448350}

[modify] https://crrev.com/1033377d9030c718bfaa1ecda9cbc01129fe7e7a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/1033377d9030c718bfaa1ecda9cbc01129fe7e7a/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java

Comment 5 by vitaliii@chromium.org, Feb 7 2017 

I am a bit confused by the CL in #4.

First, it could break us (NTP). E.g. imagine there are 2 beacons A and B for the same resolved URL. You notify us about A only. Then A disappears, but B stays. We would mistakenly remove the url (A is gone), even though there is another beacon.

Could you keep in the loop for any interface related changes?

Second, it does not work.

chrome://physical-web still shows duplicates (see scr.png).

We (NTP) in C++ still get all URLs, because we get them through getUrlInfoList, e.g. on startup (after git apply logging.patch):

======= LOG STARTS HERE =======

02-07 10:41:12.068 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(236)] MYMYMY_C++  I see 0 items.
02-07 10:41:12.129 27944 27944 I MYMYMY_JAVA : deduplicateByGroupId 
02-07 10:41:19.281 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(293)] MYMYMY_C++ OnFound https://goo.gl/1MWLz8
02-07 10:41:19.281 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(236)] MYMYMY_C++  I see 3 items.
// Format is "scanned_url->resolved_url group_id distance_estimate"
02-07 10:41:19.281 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://play.google.com/->https://play.google.com/store 9221773842145951311 -1
02-07 10:41:19.281 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://google.com/->https://www.google.com/ 6464022343067968234 -1
02-07 10:41:19.281 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/1MWLz8->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.353 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(293)] MYMYMY_C++ OnFound https://google.com/
02-07 10:41:19.354 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(236)] MYMYMY_C++  I see 4 items.
02-07 10:41:19.354 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://play.google.com/->https://play.google.com/store 9221773842145951311 -1
02-07 10:41:19.354 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/lFUDg9->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.354 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://google.com/->https://www.google.com/ 6464022343067968234 -1
02-07 10:41:19.354 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/1MWLz8->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.355 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(293)] MYMYMY_C++ OnFound https://play.google.com/
02-07 10:41:19.356 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(236)] MYMYMY_C++  I see 4 items.
02-07 10:41:19.356 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://play.google.com/->https://play.google.com/store 9221773842145951311 -1
02-07 10:41:19.356 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/lFUDg9->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.356 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://google.com/->https://www.google.com/ 6464022343067968234 -1
02-07 10:41:19.356 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/1MWLz8->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.357 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(293)] MYMYMY_C++ OnFound https://goo.gl/lFUDg9
02-07 10:41:19.358 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(236)] MYMYMY_C++  I see 4 items.
02-07 10:41:19.358 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://play.google.com/->https://play.google.com/store 9221773842145951311 -1
02-07 10:41:19.358 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/lFUDg9->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.358 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://google.com/->https://www.google.com/ 6464022343067968234 -1
02-07 10:41:19.358 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/1MWLz8->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.388 27944 28091 I MYMYMY_JAVA:  PhysicalWebBleClient.onLost https://goo.gl/1MWLz8
02-07 10:41:19.388 27944 27944 I MYMYMY_JAVA:  removeUrl https://goo.gl/1MWLz8
02-07 10:41:19.388 27944 27944 I MYMYMY_JAVA: safeNotifyNativeListenersOnLost https://goo.gl/1MWLz8
02-07 10:41:19.388 27944 28091 I MYMYMY_JAVA:  PhysicalWebBleClient.onLost https://google.com
02-07 10:41:19.388 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(299)] MYMYMY_C++ OnLost https://goo.gl/1MWLz8
02-07 10:41:19.389 27944 27944 I MYMYMY_JAVA:  removeUrl https://google.com
02-07 10:41:19.389 27944 27944 I MYMYMY_JAVA: safeNotifyNativeListenersOnLost https://google.com
02-07 10:41:19.389 27944 28091 I MYMYMY_JAVA:  PhysicalWebBleClient.onLost https://play.google.com
02-07 10:41:19.389 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(299)] MYMYMY_C++ OnLost https://google.com/
02-07 10:41:19.389 27944 27944 I MYMYMY_JAVA:  removeUrl https://play.google.com
02-07 10:41:19.389 27944 28091 I MYMYMY_JAVA:  PhysicalWebBleClient.onLost https://goo.gl/lFUDg9
02-07 10:41:19.389 27944 27944 I MYMYMY_JAVA: safeNotifyNativeListenersOnLost https://play.google.com
02-07 10:41:19.389 27944 27944 I MYMYMY_JAVA:  removeUrl https://goo.gl/lFUDg9
02-07 10:41:19.390 27944 27944 I MYMYMY_JAVA: safeNotifyNativeListenersOnLost https://goo.gl/lFUDg9
02-07 10:41:19.390 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(299)] MYMYMY_C++ OnLost https://play.google.com/
02-07 10:41:19.390 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(299)] MYMYMY_C++ OnLost https://goo.gl/lFUDg9
02-07 10:41:19.522 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(293)] MYMYMY_C++ OnFound https://goo.gl/lFUDg9
02-07 10:41:19.523 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(236)] MYMYMY_C++  I see 1 items.
02-07 10:41:19.523 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/lFUDg9->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.555 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(293)] MYMYMY_C++ OnFound https://google.com/
02-07 10:41:19.556 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(236)] MYMYMY_C++  I see 3 items.
02-07 10:41:19.556 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://play.google.com/->https://play.google.com/store 9221773842145951311 -1
02-07 10:41:19.556 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://google.com/->https://www.google.com/ 6464022343067968234 -1
02-07 10:41:19.556 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/lFUDg9->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.603 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(293)] MYMYMY_C++ OnFound https://play.google.com/
02-07 10:41:19.603 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(236)] MYMYMY_C++  I see 3 items.
02-07 10:41:19.603 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://play.google.com/->https://play.google.com/store 9221773842145951311 -1
02-07 10:41:19.603 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://google.com/->https://www.google.com/ 6464022343067968234 -1
02-07 10:41:19.603 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/lFUDg9->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.640 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(293)] MYMYMY_C++ OnFound https://goo.gl/1MWLz8
02-07 10:41:19.640 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(236)] MYMYMY_C++  I see 4 items.
02-07 10:41:19.641 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://play.google.com/->https://play.google.com/store 9221773842145951311 -1
02-07 10:41:19.641 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/1MWLz8->https://abc.xyz/ 18286465925553944445 -1
02-07 10:41:19.641 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://google.com/->https://www.google.com/ 6464022343067968234 -1
02-07 10:41:19.641 27944 27944 I chromium: [INFO:physical_web_page_suggestions_provider.cc(246)] MYMYMY_C++     https://goo.gl/lFUDg9->https://abc.xyz/ 18286465925553944445 -1


=======  LOG ENDS HERE  =======
scr.png
289 KB View Download
logging.patch
6.4 KB Download

Comment 6 by mmo...@chromium.org, Feb 14 2017

Summary: chrome://physical-web WebUI page Identical results should be deduplicated (was: chrome://physical-web Identical results should be deduplicated)

Comment 7 by mattreynolds@chromium.org, Nov 3 2017

Status: WontFix (was: Started)
►

Sign in to add a comment