New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681149 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

new line character in text may slow down Chrome

Project Member Reported by khmel@chromium.org, Jan 13 2017

Issue description

Repro:

create view::Label and set text that contains new line character 0xa.
There is noticeable lag on first render attempt.

After investigation I found:

This character is marked as kMissingGlyphId. 

Following fails due this:
https://cs.chromium.org/chromium/src/ui/gfx/render_text_harfbuzz.cc?q=RenderTextHarfBuzz::CompareFamily&sq=package:chromium&l=1418&dr=CSs

As result following is called:
https://cs.chromium.org/chromium/src/ui/gfx/render_text_harfbuzz.cc?q=RenderTextHarfBuzz::CompareFamily&sq=package:chromium&dr=CSs&l=1500

Which is slow on first time.

Related bug:
b/33252040

In this bug, lag is caused during label::SizeToFit() call.



 

Comment 1 by xiy...@chromium.org, Jan 13 2017

Cc: ckocagil@chromium.org

Comment 2 by x...@chromium.org, Jun 9 2017

Cc: x...@chromium.org
Owner: sammiequon@chromium.org
Assign to sammiequon@ per offline discussion
Status: Assigned (was: Untriaged)
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
**UI Mass Triage**

Adding labels for expert review.

Sign in to add a comment