New issue
Advanced search Search tips

Issue 681146 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 680795
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0.4% regression in sizes at 443636:443636

Project Member Reported by sullivan@chromium.org, Jan 13 2017

Issue description

Looks like this is due to https://codereview.chromium.org/2623143005
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=681146

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgoNizvAkM


Bot(s) for this bug's original alert(s):

win
Cc: sebmarchand@chromium.org
Crazy, that change reduced dependencies!

Looking at https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder/builds/46076/steps/generate_build_files/logs/stdio

unfortunately, I believe this is an instance of  crbug.com/680795 , that is, the builder is building is_official_build=true, but not full_wpo_on_official=true.

This confused me locally too, but it completely changes the sizes, see https://codereview.chromium.org/2624163003/#msg11 for numbers.
Note that I'm currently writing a document that describes the different optimization modes and the problem that this causes.
Mergedinto: 680795
Status: Duplicate (was: Assigned)
I'm (relatively) confident that this won't regress the "real" build given what was actually changed, so I'm going to dupe it into the full_wpo_on_official bug.

Sign in to add a comment