I'm not working on this.

The usual approach is to suppress new warnings, and then clean them up asynchronously if the warning looks useful. This one does look useful.

rnk saw this in some test in base/ as well

I'll prepare a patch to suppress them until we can fix.

Patch is in the cq: https://codereview.chromium.org/2622083008/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93e7e50976936431e9da049e74fed54e35c3d9ac

commit 93e7e50976936431e9da049e74fed54e35c3d9ac
Author: hans <hans@chromium.org>
Date: Fri Jan 13 23:12:07 2017

Suppress new Clang warning -Wunused-lambda-capture

The warning was added in Clang r291905. It seems useful, but needs to be
suppressed until we clean up the instances where it fires.

BUG= 681136 

Review-Url: https://codereview.chromium.org/2622083008
Cr-Commit-Position: refs/heads/master@{#443714}

[modify] https://crrev.com/93e7e50976936431e9da049e74fed54e35c3d9ac/build/config/compiler/BUILD.gn

Currently, a lot of builders fail due to an unused lambda again:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux%20%28dbg%29/builds/5316

I will take a look what's happened with the suppression in #5.

Oh, that's interesting. The suppression is there, and it's a non-compile test that's failing, because it manages to compile:
[4778/41612] CXX obj/base/base_nocompile_tests/bind_unittest_nc.o
FAILED: obj/base/base_nocompile_tests/bind_unittest_nc.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/base/base_nocompile_tests/bind_unittest_nc.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=292371 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1 -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DUNIT_TEST -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../testing/gtest/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/ClangToTLinux__dbg_/src=. -m64 -march=x86-64 -pthread -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -O0 -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fno-threadsafe-statics -fvisibility-inlines-hidden -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -fno-exceptions -c gen/base/bind_unittest_nc.cc -o obj/base/base_nocompile_tests/bind_unittest_nc.o
gen/base/bind_unittest_nc.cc:50:2: error: "NCTEST_DISALLOW_CAPTURING_LAMBDA Failed: Expectations [r'fatal error: implicit instantiation of undefined template 'base::internal::FunctorTraits<\(lambda at (\.\./)+base/bind_unittest.nc:[0-9]+:[0-9]+\), void>''] did not match output."
#error "NCTEST_DISALLOW_CAPTURING_LAMBDA Failed: Expectations [r'fatal error: implicit instantiation of undefined template 'base::internal::FunctorTraits<\(lambda at (\.\./)+base/bind_unittest.nc:[0-9]+:[0-9]+\), void>''] did not match output."
 ^
gen/base/bind_unittest_nc.cc:51:2: error: "compile line: /b/c/b/ClangToTLinux__dbg_/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -Wall -Werror -Wfatal-errors -I../../ --sysroot ../../build/linux/debian_wheezy_amd64-sysroot -DNCTEST_DISALLOW_CAPTURING_LAMBDA -std=c++11 -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
#error "compile line: /b/c/b/ClangToTLinux__dbg_/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++ -Wall -Werror -Wfatal-errors -I../../ --sysroot ../../build/linux/debian_wheezy_amd64-sysroot -DNCTEST_DISALLOW_CAPTURING_LAMBDA -std=c++11 -o /dev/null -c -x c++ ../../base/bind_unittest.nc"
 ^
gen/base/bind_unittest_nc.cc:52:2: error: "NCTEST_DISALLOW_CAPTURING_LAMBDA stderr:"
#error "NCTEST_DISALLOW_CAPTURING_LAMBDA stderr:"
 ^
gen/base/bind_unittest_nc.cc:53:2: error: "  ../../base/bind_unittest.nc:210:9: fatal error: lambda capture 'i' is not used [-Wunused-lambda-capture]"
#error "  ../../base/bind_unittest.nc:210:9: fatal error: lambda capture 'i' is not used [-Wunused-lambda-capture]"
 ^
gen/base/bind_unittest_nc.cc:54:2: error: "    Bind([i]() {});"
#error "    Bind([i]() {});"
 ^
gen/base/bind_unittest_nc.cc:55:2: error: "          ^"
#error "          ^"
 ^
gen/base/bind_unittest_nc.cc:56:2: error: "  1 error generated."
#error "  1 error generated."
 ^
gen/base/bind_unittest_nc.cc:57:2: error: "  "
#error "  "
 ^
8 errors generated.

Temporary fix is in the CQ: https://codereview.chromium.org/2645593002/
I disable nocompile tests on Clang ToT bots.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3fd65856d4f56e3ee07f2e7db42047f87ff4eef

commit a3fd65856d4f56e3ee07f2e7db42047f87ff4eef
Author: krasin <krasin@chromium.org>
Date: Wed Jan 18 17:55:54 2017

Temporarily disable nocompile tests on Linux ToT bots.

The tests should be reenabled once -Wunused-lambda-capture
suppression is gone.

BUG= 681136 
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2645593002
Cr-Commit-Position: refs/heads/master@{#444416}

[modify] https://crrev.com/a3fd65856d4f56e3ee07f2e7db42047f87ff4eef/tools/mb/mb_config.pyl

Modulo the offline slaves ( https://crbug.com/682283 ), I expect many ToT bots come green in 1-2 hours.

I have been working on unused lambda cleanups locally and expect to send a number of CLs for a review before noon.

Fixes for V8 were sent for a review: https://codereview.chromium.org/2646553002/

WebKit/Blink fixes: https://codereview.chromium.org/2645613003/

And here goes the first interesting case. MSVC++ complains about the removed lambda captures:

e:\b\build\slave\win\build\v8\test\unittests\heap\slot-set-unittest.cc(171): error C3493: 'kDelta' cannot be implicitly captured because no default capture mode has been specified
e:\b\build\slave\win\build\v8\test\unittests\heap\slot-set-unittest.cc(172): error C3493: 'kHostDelta' cannot be implicitly captured because no default capture mode has been specified

I will try to understand if we can make both compilers happy at the same time.

In any case, it'd be probably a good idea to come up with a small sample and post that on the review for the warning.

(the review where that new clang warning got added to clang, that is)

Nico, I have updated a description on https://codereview.chromium.org/2645613003/ to match your suggestion in #14. Please, take a look, if you're curious.

No, I meant an example where clang now warns, but where fixing that warning makes MSVC warn. (And then post that on the review for the clang warning on phab)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cbffe1aa36f518681414e7bed5627a57449b58a

commit 5cbffe1aa36f518681414e7bed5627a57449b58a
Author: krasin <krasin@chromium.org>
Date: Wed Jan 18 21:06:19 2017

Fix unused lambda captures in Blink.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in WebKit/Blink.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

BUG= 681136 

Review-Url: https://codereview.chromium.org/2645613003
Cr-Commit-Position: refs/heads/master@{#444477}

[modify] https://crrev.com/5cbffe1aa36f518681414e7bed5627a57449b58a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/5cbffe1aa36f518681414e7bed5627a57449b58a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Re: #17: I have posted a comment on the LLVM review tool: https://reviews.llvm.org/D28467 with the following example:

#include <stdio.h>

int main(void) {
  const int kDelta = 10000001;
  auto g = [kDelta](int i)
           {
             printf("%d\n", i % kDelta);
           };
  g(2);
}

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5ccc719a3169f4b05843cfc69de8e1b9e8e67e7e

commit 5ccc719a3169f4b05843cfc69de8e1b9e8e67e7e
Author: krasin <krasin@chromium.org>
Date: Thu Jan 19 21:34:00 2017

Fix unused lambda captures.

Clang just got more strict about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in V8.

BUG= chromium:681136 

Review-Url: https://codereview.chromium.org/2646553002
Cr-Commit-Position: refs/heads/master@{#42523}

[modify] https://crrev.com/5ccc719a3169f4b05843cfc69de8e1b9e8e67e7e/src/builtins/builtins-array.cc
[modify] https://crrev.com/5ccc719a3169f4b05843cfc69de8e1b9e8e67e7e/src/code-stubs.cc
[modify] https://crrev.com/5ccc719a3169f4b05843cfc69de8e1b9e8e67e7e/src/heap/mark-compact.cc
[modify] https://crrev.com/5ccc719a3169f4b05843cfc69de8e1b9e8e67e7e/src/heap/spaces.cc
[modify] https://crrev.com/5ccc719a3169f4b05843cfc69de8e1b9e8e67e7e/test/unittests/heap/slot-set-unittest.cc
[modify] https://crrev.com/5ccc719a3169f4b05843cfc69de8e1b9e8e67e7e/test/unittests/value-serializer-unittest.cc

For the record, a simple workaround for Windows (indirectly suggested on the llvm CL discussion) is to make these constants static.

We still have a few issues in src/ and I have a local patch that fixes them all. Will send them for a review today. Hopefully, tomorrow will be able to reenable the warning and nocompile tests on ToT bots.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cc294f047397929621de8cb19c2e911c8f488a1

commit 3cc294f047397929621de8cb19c2e911c8f488a1
Author: krasin <krasin@chromium.org>
Date: Thu Jan 19 22:55:58 2017

Fix unused lambda captures in //device and //services/media_capture.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //device and //services/media_capture.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

BUG= 681136 

Review-Url: https://codereview.chromium.org/2649443002
Cr-Commit-Position: refs/heads/master@{#444873}

[modify] https://crrev.com/3cc294f047397929621de8cb19c2e911c8f488a1/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
[modify] https://crrev.com/3cc294f047397929621de8cb19c2e911c8f488a1/services/video_capture/test/fake_device_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c9a1c6ec0f08e65ec3aa5e8a42a239c267ca611

commit 7c9a1c6ec0f08e65ec3aa5e8a42a239c267ca611
Author: jianli <jianli@chromium.org>
Date: Thu Jan 19 23:36:29 2017

Revert of Fix unused lambda captures in //device and //services/media_capture. (patchset #1 id:1 of https://codereview.chromium.org/2649443002/ )

Reason for revert:
https://build.chromium.org/p/chromium/builders/Win/builds/51061

Original issue's description:
> Fix unused lambda captures in //device and //services/media_capture.
>
> Clang just got a new warning about unused lambda captures,
> and that requires us to clean all places with this issue
> across all the Chromium code base. This CL fixes all such
> cases in //device and //services/media_capture.
>
> An example of a code that is no longer considered normal is
>
> auto g = [i, j]() { printf("%d\n", i); };
>
> in which j is never used in the lambda and therefore its capture is unnecessary.
>
> BUG= 681136 
>
> Review-Url: https://codereview.chromium.org/2649443002
> Cr-Commit-Position: refs/heads/master@{#444873}
> Committed: https://chromium.googlesource.com/chromium/src/+/3cc294f047397929621de8cb19c2e911c8f488a1

TBR=rockot@chromium.org,krasin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 681136 

Review-Url: https://codereview.chromium.org/2643853006
Cr-Commit-Position: refs/heads/master@{#444889}

[modify] https://crrev.com/7c9a1c6ec0f08e65ec3aa5e8a42a239c267ca611/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
[modify] https://crrev.com/7c9a1c6ec0f08e65ec3aa5e8a42a239c267ca611/services/video_capture/test/fake_device_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbbf64cf6fa9c2ec032d680d1fbb08a60e5915ba

commit bbbf64cf6fa9c2ec032d680d1fbb08a60e5915ba
Author: krasin <krasin@chromium.org>
Date: Fri Jan 20 15:39:13 2017

Fix unused lambda captures in //content.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //content.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

BUG= 681136 

Review-Url: https://codereview.chromium.org/2644133004
Cr-Commit-Position: refs/heads/master@{#445061}

[modify] https://crrev.com/bbbf64cf6fa9c2ec032d680d1fbb08a60e5915ba/content/renderer/presentation/presentation_dispatcher_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea33b332c6d28c050b657baada979a22ae5ad3a6

commit ea33b332c6d28c050b657baada979a22ae5ad3a6
Author: krasin <krasin@chromium.org>
Date: Fri Jan 20 15:40:25 2017

Fix unused lambda captures in //chrome, //services/ui and //ui.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //chrome, //services/ui and //ui.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

BUG= 681136 

Review-Url: https://codereview.chromium.org/2646863002
Cr-Commit-Position: refs/heads/master@{#445062}

[modify] https://crrev.com/ea33b332c6d28c050b657baada979a22ae5ad3a6/chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc
[modify] https://crrev.com/ea33b332c6d28c050b657baada979a22ae5ad3a6/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/ea33b332c6d28c050b657baada979a22ae5ad3a6/services/ui/ws/user_display_manager.cc
[modify] https://crrev.com/ea33b332c6d28c050b657baada979a22ae5ad3a6/ui/message_center/views/message_popup_collection_unittest.cc

All but two unused-lambda-captures issues are now fixed. The remaining are:

1. https://codereview.chromium.org/2639883006/ (relanding a reverted CL; the test it touches is not run by any of the windows try bots, but there are some buildbots which build it)

2. https://codereview.chromium.org/2646873002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17305ea8ba2799834b6eda071348c7724e2c68be

commit 17305ea8ba2799834b6eda071348c7724e2c68be
Author: krasin <krasin@chromium.org>
Date: Fri Jan 20 18:06:16 2017

Fix unused lambda captures in //net.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //net.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

BUG= 681136 

Review-Url: https://codereview.chromium.org/2646873002
Cr-Commit-Position: refs/heads/master@{#445087}

[modify] https://crrev.com/17305ea8ba2799834b6eda071348c7724e2c68be/net/quic/test_tools/simulator/simulator_test.cc

One CL is remaining: https://codereview.chromium.org/2639883006/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f1771ac371b74ddfff193a764dfea08b4a86314

commit 2f1771ac371b74ddfff193a764dfea08b4a86314
Author: krasin <krasin@chromium.org>
Date: Mon Jan 23 18:39:04 2017

Fix unused lambda captures in //device and //services/media_capture.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //device and //services/media_capture.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

This is a second attempt to submit this CL. Previous one
was reverted because of (now fixed) Windows issues.
The original review url:
https://codereview.chromium.org/2649443002/

BUG= 681136 

Review-Url: https://codereview.chromium.org/2639883006
Cr-Commit-Position: refs/heads/master@{#445418}

[modify] https://crrev.com/2f1771ac371b74ddfff193a764dfea08b4a86314/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
[modify] https://crrev.com/2f1771ac371b74ddfff193a764dfea08b4a86314/services/video_capture/test/fake_device_unittest.cc

Re: #c7

About the nocompile test, how about using this instead?

void WontCompile() {
  int i = 0, j = 1;
  Bind([i,&j]() {j = i;});
}

Well, the code compiles for me with Clang ToT:

$ cat lala.cc
int main(void) {
  int i = 0, j = 1;
  auto g = [i,&j]() {j = i;};
  g();
}

$ clang++ lala.cc -o lala -std=c++14 -g -Wall -Werror
$

Do I miss anything (like a flag?)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9461af221d3d56769f21b6755a8afbef00d6d7d

commit a9461af221d3d56769f21b6755a8afbef00d6d7d
Author: krasin <krasin@chromium.org>
Date: Tue Jan 24 17:17:58 2017

Enable use-after-scope check in ASAN configs.

This is a second attempt to land this change.
Previous attempts failed on some ChromeOS bots
using old version of Clang, on Clang-CL Win bots
and also there were a couple of webkit_tests failed
due to a real use-after-scope issue.

The use-after-scope issue is now fixed by
https://codereview.chromium.org/2649903005/, Windows and
ChromeOS are temporarily blacklisted.

BUG= 681136 , 683459 ,683966, 683445 

Review-Url: https://codereview.chromium.org/2654623002
Cr-Commit-Position: refs/heads/master@{#445747}

[modify] https://crrev.com/a9461af221d3d56769f21b6755a8afbef00d6d7d/build/config/sanitizers/BUILD.gn

Everything seems to build with the warning enabled. I have sent a CL that reenables -Wunused-lambda-capture: https://codereview.chromium.org/2653683005/

The plan proposed by Nico is:

>Rollout plan: Maybe it makes sense to wait for the next clang roll and then >turn it on after that? Else the next clang roll will update both the compiler and (implicitly) turn on this warning, which increases roll risk. And once the
compiler is rev'd, this CL can be tested on the try bots. (I'm not sure this is
necessary, but it kind of feels like it might be a good idea.)

So, this issue will not get updates until the next roll.

Let's marked it blocked on that then. I still think it might be nice to a) find the bit of standardese showing that clang is correct to warn on unused const(expr) variables b) possibly moving the const(expr) parts of the warning behind a separate flag.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5c9128c3d52b14e61e82279963348fdf0b07a83

commit d5c9128c3d52b14e61e82279963348fdf0b07a83
Author: krasin <krasin@chromium.org>
Date: Wed Feb 08 22:51:54 2017

Remove unused lambda capture in browser_presentation_connection_proxy_unittest.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //chrome, //services/ui and //ui.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is
unnecessary.

BUG= 681136 

Review-Url: https://codereview.chromium.org/2679423004
Cr-Commit-Position: refs/heads/master@{#449120}

[modify] https://crrev.com/d5c9128c3d52b14e61e82279963348fdf0b07a83/chrome/browser/media/router/browser_presentation_connection_proxy_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7525a848b3036662353f3d3b244fa4e3e9114f9e

commit 7525a848b3036662353f3d3b244fa4e3e9114f9e
Author: wychen <wychen@chromium.org>
Date: Sat Feb 25 00:14:32 2017

Fix nocompile test failure due to clang roll and re-enable

BUG=695991, 681136 

Review-Url: https://codereview.chromium.org/2716913002
Cr-Commit-Position: refs/heads/master@{#453010}

[modify] https://crrev.com/7525a848b3036662353f3d3b244fa4e3e9114f9e/base/bind_unittest.nc
[modify] https://crrev.com/7525a848b3036662353f3d3b244fa4e3e9114f9e/build/nocompile.gni

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e08d0dd8c897cc06417cc3528f15e3ded54d46b

commit 3e08d0dd8c897cc06417cc3528f15e3ded54d46b
Author: wychen <wychen@chromium.org>
Date: Tue Mar 14 02:25:44 2017

Revert "Temporarily disable nocompile tests on Linux ToT bots."

This reverts commit a3fd65856d4f56e3ee07f2e7db42047f87ff4eef.

Revert https://codereview.chromium.org/2645593002 because nocompile
tests don't trigger unused-lambda-capture warning anymore.

BUG= 681136 , 695991

Review-Url: https://codereview.chromium.org/2715313002
Cr-Commit-Position: refs/heads/master@{#456582}

[modify] https://crrev.com/3e08d0dd8c897cc06417cc3528f15e3ded54d46b/tools/mb/mb_config.pyl

thakis@ do we still want to do this?  krasin@ is no longer working on this.

I'm interested in this.

I think we decided on a codereview somewhere that this is basically infeasible. This warning complains about captures of static vars, but msvc fails to compile lambdas referencing static vars if they aren't captured. I can find details if you want.

Hmm, I already made patch for chromium/src
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

And msvc 2017 looks to allow such compiles.
https://godbolt.org/z/XFNbk8

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6d308af0b0e0679aaa8b33f1dcb91e14d3c7b5b2

commit 6d308af0b0e0679aaa8b33f1dcb91e14d3c7b5b2
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Wed Oct 17 10:45:35 2018

Remove unused lambda capture if DCHECK is not used.

This is a preparation CL to remove -Wno-unused-lambda-capture warning suppression.

Bug:  chromium:681136 
Change-Id: If3d16c8a6719bf3135e028ab2bafe850778e31b5
Reviewed-on: https://chromium-review.googlesource.com/c/1286390
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56722}
[modify] https://crrev.com/6d308af0b0e0679aaa8b33f1dcb91e14d3c7b5b2/src/heap/incremental-marking.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/c20ead32ad6d97a87ea64f7350f778959be91075

commit c20ead32ad6d97a87ea64f7350f778959be91075
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Wed Oct 17 15:05:30 2018

Remove unused lambda capture

This is a preparation CL to remove -Wno-unused-lambda-capture warning suppression.

Bug:  chromium:681136 
Change-Id: Ib5c1c4eeeed3b7406ede2dea33066c54e5fc3da0
Reviewed-on: https://chromium-review.googlesource.com/c/1286172
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/c20ead32ad6d97a87ea64f7350f778959be91075/src/tests/gl_tests/RobustResourceInitTest.cpp

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/a358d622339d022e3723525141900365caf55ca1

commit a358d622339d022e3723525141900365caf55ca1
Author: Takuto Ikuta <tikuta@google.com>
Date: Wed Oct 17 16:36:11 2018

Remove unused lambda capture

This is a preparation CL to remove -Wno-unused-lambda-capture warning suppression.

Bug:  chromium:681136 
Change-Id: I0fccfd33e10757b282b45079f29b511951decc41
Reviewed-on: https://pdfium-review.googlesource.com/c/44190
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/a358d622339d022e3723525141900365caf55ca1/fpdfsdk/cpdfsdk_actionhandler.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e1208ce6a5acbbf49c9d2c14519924deb5f4dbe

commit 7e1208ce6a5acbbf49c9d2c14519924deb5f4dbe
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Oct 17 17:54:03 2018

Roll src/third_party/pdfium b01628451a54..a358d622339d (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/b01628451a54..a358d622339d


git log b01628451a54..a358d622339d --date=short --no-merges --format='%ad %ae %s'
2018-10-17 tikuta@google.com Remove unused lambda capture


Created with:
  gclient setdep -r src/third_party/pdfium@a358d622339d

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:681136 
TBR=dsinclair@chromium.org

Change-Id: Ic8928806baf7dfcb8666a43877fb30e91c488540
Reviewed-on: https://chromium-review.googlesource.com/c/1286698
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600467}
[modify] https://crrev.com/7e1208ce6a5acbbf49c9d2c14519924deb5f4dbe/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dda560bff9b2c843f3a70dff319cb353ce864560

commit dda560bff9b2c843f3a70dff319cb353ce864560
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Oct 17 21:20:04 2018

Roll src/third_party/angle 78bcd2bec371..3a482179dedb (4 commits)

https://chromium.googlesource.com/angle/angle.git/+log/78bcd2bec371..3a482179dedb


git log 78bcd2bec371..3a482179dedb --date=short --no-merges --format='%ad %ae %s'
2018-10-17 syoussefi@chromium.org Vulkan: Implement glFlush
2018-10-17 syoussefi@chromium.org Vulkan: Use a specialized macro for wrapped vulkan calls
2018-10-17 syoussefi@chromium.org Roll clang and other chromium deps
2018-10-17 tikuta@chromium.org Remove unused lambda capture


Created with:
  gclient setdep -r src/third_party/angle@3a482179dedb

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:none,chromium:681136
TBR=geofflang@chromium.org

Change-Id: I35923d6afed0109c6fe771342aa988e6aa5fcaec
Reviewed-on: https://chromium-review.googlesource.com/c/1287013
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600557}
[modify] https://crrev.com/dda560bff9b2c843f3a70dff319cb353ce864560/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2cde0effd7a49c6a21e8e14ada38d6cdead85fa7

commit 2cde0effd7a49c6a21e8e14ada38d6cdead85fa7
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Oct 18 07:43:28 2018

Remove unused lambda capture

This is a preparation CL to remove -Wno-unused-lambda-capture warning suppression.

Bug:  chromium:681136 
Change-Id: Iacd0933363cfe7e4a17191f83f567f2834dee6aa
Reviewed-on: https://chromium-review.googlesource.com/c/1288209
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56754}
[modify] https://crrev.com/2cde0effd7a49c6a21e8e14ada38d6cdead85fa7/test/cctest/test-assembler-arm64.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b8f54d7a5af398999e864b249448efac5894d15

commit 8b8f54d7a5af398999e864b249448efac5894d15
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Oct 18 08:21:30 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=jdoerrie@chromium.org

Bug:  681136 
Change-Id: I948c064bed03c801088e96007b641be2412bc6ee
Reviewed-on: https://chromium-review.googlesource.com/c/1288509
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600690}
[modify] https://crrev.com/8b8f54d7a5af398999e864b249448efac5894d15/device/fido/cable/fido_cable_device_unittest.cc
[modify] https://crrev.com/8b8f54d7a5af398999e864b249448efac5894d15/device/fido/cable/fido_cable_discovery_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d27e6b8542e1b304b8c0b016c24a7b2bfe906c45

commit d27e6b8542e1b304b8c0b016c24a7b2bfe906c45
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Oct 18 08:23:11 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=peria@chromium.org

Bug:  681136 
Change-Id: I9dce2f01375277b9f471e65d30479ec91689e478
Reviewed-on: https://chromium-review.googlesource.com/c/1288496
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600691}
[modify] https://crrev.com/d27e6b8542e1b304b8c0b016c24a7b2bfe906c45/third_party/blink/renderer/platform/bindings/runtime_call_stats_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee829599e79940255564063df608f236f3491127

commit ee829599e79940255564063df608f236f3491127
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Oct 18 08:59:46 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=yosin@chromium.org

Bug:  681136 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6bd5a1a0e8a2050c579cf459e243c5b63185b1f6
Reviewed-on: https://chromium-review.googlesource.com/c/1288515
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600701}
[modify] https://crrev.com/ee829599e79940255564063df608f236f3491127/third_party/blink/renderer/core/editing/markers/document_marker_controller.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f452e2b60c44997a9ac88fc5eebbc9001cfb27e7

commit f452e2b60c44997a9ac88fc5eebbc9001cfb27e7
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Oct 18 10:46:07 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=grt@chromium.org

Bug:  681136 
Change-Id: I29dd163da1243fb036c9a828210ce5c3a3a9f444
Reviewed-on: https://chromium-review.googlesource.com/c/1288337
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600721}
[modify] https://crrev.com/f452e2b60c44997a9ac88fc5eebbc9001cfb27e7/components/zucchini/buffer_source_unittest.cc
[modify] https://crrev.com/f452e2b60c44997a9ac88fc5eebbc9001cfb27e7/components/zucchini/patch_utils_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96aca44d031ac70876e4b454426141c173c9b684

commit 96aca44d031ac70876e4b454426141c173c9b684
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Oct 18 14:28:32 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=xiyuan@chromium.org

Bug:  681136 
Change-Id: I54485b40c1808525659f4af61369a04819c40e06
Reviewed-on: https://chromium-review.googlesource.com/c/1288493
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600756}
[modify] https://crrev.com/96aca44d031ac70876e4b454426141c173c9b684/ash/frame/non_client_frame_view_ash_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/740dc099b3527755c27d6aea290bee595a1ad817

commit 740dc099b3527755c27d6aea290bee595a1ad817
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Oct 18 15:07:15 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=emircan@chromium.org

Bug:  681136 
Change-Id: I860ea8a950d3802572c22aaeecba23f716f55d5b
Reviewed-on: https://chromium-review.googlesource.com/c/1288339
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600761}
[modify] https://crrev.com/740dc099b3527755c27d6aea290bee595a1ad817/media/capture/video/win/video_capture_device_factory_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09e8b44201f40a2243e8694b694029f477f0d25e

commit 09e8b44201f40a2243e8694b694029f477f0d25e
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 00:15:43 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=jyasskin@chromium.org

Bug:  681136 
Change-Id: I59478d51c2b81e5d856319871ebc76b9d2401697
Reviewed-on: https://chromium-review.googlesource.com/c/1288514
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600979}
[modify] https://crrev.com/09e8b44201f40a2243e8694b694029f477f0d25e/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f589909e13d5aea7c182e5cebe0590c44f85c7b9

commit f589909e13d5aea7c182e5cebe0590c44f85c7b9
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 00:16:47 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=zmo@chromium.org

Bug:  681136 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I05d68bcadcd0b152962ae6828fc8af66687e46d3
Reviewed-on: https://chromium-review.googlesource.com/c/1288510
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600981}
[modify] https://crrev.com/f589909e13d5aea7c182e5cebe0590c44f85c7b9/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f03bf8739d80d650dc21fce93661631ff47ddff

commit 5f03bf8739d80d650dc21fce93661631ff47ddff
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 00:17:55 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=oysteine@chromium.org

Bug:  681136 
Change-Id: Ide55f05c47a2572da354617a83c9b6727633f61f
Reviewed-on: https://chromium-review.googlesource.com/c/1288495
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600983}
[modify] https://crrev.com/5f03bf8739d80d650dc21fce93661631ff47ddff/services/tracing/coordinator.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4033f1e0199ac93276aa590442788bf72ca1a7c6

commit 4033f1e0199ac93276aa590442788bf72ca1a7c6
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 00:19:05 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=chrishtr@chromium.org

Bug:  681136 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib2e84f9aef18ed801d27f74520edeb7e41eda54b
Reviewed-on: https://chromium-review.googlesource.com/c/1288494
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600985}
[modify] https://crrev.com/4033f1e0199ac93276aa590442788bf72ca1a7c6/third_party/blink/renderer/platform/graphics/paint/paint_controller_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20ed286d82dc197f2d8839816418d7060dacc370

commit 20ed286d82dc197f2d8839816418d7060dacc370
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 00:19:51 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=jochen@chromium.org

Bug:  681136 
Change-Id: I2de6838cb20e249234f820aa84d996311acc58c1
Reviewed-on: https://chromium-review.googlesource.com/c/1288345
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600986}
[modify] https://crrev.com/20ed286d82dc197f2d8839816418d7060dacc370/extensions/renderer/native_renderer_messaging_service_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5644e93e7d7151ec62fd751d746d16801dffbeea

commit 5644e93e7d7151ec62fd751d746d16801dffbeea
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 00:30:37 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=petewil@chromium.org

Bug:  681136 
Change-Id: I9ee910da99a5c3d34039be1e61d9eb44819cddee
Reviewed-on: https://chromium-review.googlesource.com/c/1288492
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600991}
[modify] https://crrev.com/5644e93e7d7151ec62fd751d746d16801dffbeea/components/offline_pages/core/prefetch/prefetch_dispatcher_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc7a5decfe4210688f16c59210afc700fd2b715c

commit fc7a5decfe4210688f16c59210afc700fd2b715c
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 00:31:20 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=kmackay@chromium.org

Bug:  681136 
Change-Id: I6f95a419588a54b279da8516096bff1f65daf05d
Reviewed-on: https://chromium-review.googlesource.com/c/1288340
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600992}
[modify] https://crrev.com/fc7a5decfe4210688f16c59210afc700fd2b715c/chromecast/media/audio/cast_audio_mixer_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2ab63b3f7485d5bc0081cc2cb31cbddfb60ed17

commit b2ab63b3f7485d5bc0081cc2cb31cbddfb60ed17
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 00:35:10 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=battre@chromium.org

Bug:  681136 
Change-Id: Ie31e3afbb761c43dded20d7b15da8354e167014a
Reviewed-on: https://chromium-review.googlesource.com/c/1288490
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600996}
[modify] https://crrev.com/b2ab63b3f7485d5bc0081cc2cb31cbddfb60ed17/chrome/browser/extensions/api/web_request/web_request_apitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd1f5528e827705d9d158f67e947c2783f07a576

commit cd1f5528e827705d9d158f67e947c2783f07a576
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 00:36:38 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=scottmg@chromium.org

Bug:  681136 
Change-Id: I64f5b45d9f9d378578c3d0f2d80deb675fe3aa6a
Reviewed-on: https://chromium-review.googlesource.com/c/1288341
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600998}
[modify] https://crrev.com/cd1f5528e827705d9d158f67e947c2783f07a576/ui/ozone/platform/scenic/scenic_window_manager.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/868e7a188ae4b9b79494abadaf9f1d4211f9e8f6

commit 868e7a188ae4b9b79494abadaf9f1d4211f9e8f6
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 04:43:58 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=xdai@chromium.org

Bug:  681136 
Change-Id: I2dff39578c1c05a5ddef7758b74a84f7b54b00af
Reviewed-on: https://chromium-review.googlesource.com/c/1288491
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601054}
[modify] https://crrev.com/868e7a188ae4b9b79494abadaf9f1d4211f9e8f6/chrome/browser/ui/ash/test_wallpaper_controller.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2160c34d2cf09527039626aa33785cab4bb21c3

commit b2160c34d2cf09527039626aa33785cab4bb21c3
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 05:02:44 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=xdai@chromium.org

Bug:  681136 
Change-Id: Ie3ad102b5b38cbb0ee31622d4b544358a947b8f9
Reviewed-on: https://chromium-review.googlesource.com/c/1288343
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601056}
[modify] https://crrev.com/b2160c34d2cf09527039626aa33785cab4bb21c3/chromeos/printing/ppd_line_reader_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b845a71234dbf491dc8a4a4fa1b094f2fcb5f580

commit b845a71234dbf491dc8a4a4fa1b094f2fcb5f580
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 18:03:35 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=miu@chromium.org

Bug:  681136 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If7d9e65dd131693198a2df86716ba85b0b60ab91
Reviewed-on: https://chromium-review.googlesource.com/c/1288344
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601222}
[modify] https://crrev.com/b845a71234dbf491dc8a4a4fa1b094f2fcb5f580/components/viz/service/frame_sinks/video_capture/interprocess_frame_pool.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e4149ac2118c3d25ebaf5b9b0b9dec7cae10d89

commit 0e4149ac2118c3d25ebaf5b9b0b9dec7cae10d89
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Oct 19 23:54:59 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=mef@chromium.org

Bug:  681136 
Change-Id: I55220b203c6798614bd7978710aa6fe3669c70dc
Reviewed-on: https://chromium-review.googlesource.com/c/1288348
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601361}
[modify] https://crrev.com/0e4149ac2118c3d25ebaf5b9b0b9dec7cae10d89/net/base/network_change_notifier_fuchsia.cc
[modify] https://crrev.com/0e4149ac2118c3d25ebaf5b9b0b9dec7cae10d89/net/third_party/quic/core/congestion_control/bbr_sender_test.cc
[modify] https://crrev.com/0e4149ac2118c3d25ebaf5b9b0b9dec7cae10d89/net/third_party/quic/core/quic_dispatcher_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77ba1a3375c9fb4d4edb7e663035c48775175b2d

commit 77ba1a3375c9fb4d4edb7e663035c48775175b2d
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Sat Oct 20 03:41:16 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=timvolodine@chromium.org

Bug:  681136 
Change-Id: I98dd1c92df3d38301e0394e44cea06263f54beaf
Reviewed-on: https://chromium-review.googlesource.com/c/1288512
Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601400}
[modify] https://crrev.com/77ba1a3375c9fb4d4edb7e663035c48775175b2d/services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4091dcc2a7bc4edb27213702905b69aebd190cbb

commit 4091dcc2a7bc4edb27213702905b69aebd190cbb
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Mon Oct 22 18:06:52 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=aleventhal@chromium.org

Bug:  681136 
Change-Id: I7961ce74b47e41b4818e4fed007df38e1060539d
Reviewed-on: https://chromium-review.googlesource.com/c/1288338
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601650}
[modify] https://crrev.com/4091dcc2a7bc4edb27213702905b69aebd190cbb/ui/accessibility/ax_tree.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9749849528daa147f4a72ecd457679ecea7e747

commit c9749849528daa147f4a72ecd457679ecea7e747
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Mon Oct 22 23:25:01 2018

Fix for unused-lambda-capture warning

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=hansberry@chromium.org

Bug:  681136 
Change-Id: I310de48fb3c0d0423cf0cadff7de18e6a4815548
Reviewed-on: https://chromium-review.googlesource.com/c/1288513
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601773}
[modify] https://crrev.com/c9749849528daa147f4a72ecd457679ecea7e747/chromeos/components/tether/ble_service_data_helper_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/269cc84077c611f25fc4fceef86139726d420533

commit 269cc84077c611f25fc4fceef86139726d420533
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Tue Oct 23 01:50:56 2018

Remove -Wno-unused-lambda-capture flag from default_warnings

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=scottmg@chromium.org

Bug:  681136 
Change-Id: Id22ba18bda2f051b12b5ca439df66eab6f42260d
Reviewed-on: https://chromium-review.googlesource.com/c/1288511
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601821}
[modify] https://crrev.com/269cc84077c611f25fc4fceef86139726d420533/build/config/compiler/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2984928363b7f9d0920e5af850607ee53b5d46e7

commit 2984928363b7f9d0920e5af850607ee53b5d46e7
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Tue Nov 06 18:41:44 2018

Roll src/third_party/swiftshader/ 155f802a6..4169b3109 (4 commits)

https://swiftshader.googlesource.com/SwiftShader.git/+log/155f802a6be3..4169b31090db

$ git log 155f802a6..4169b3109 --date=short --no-merges --format='%ad %ae %s'
2018-11-05 tikuta Fix for unused-lambda-capture warning
2018-11-05 gordana.cmiljanovic [MIPS] Add support for 64b MIPS architecture
2018-11-03 tikuta Revert "Fix for unused-lambda-capture warning"
2018-10-23 tikuta Fix for unused-lambda-capture warning

Created with:
  roll-dep src/third_party/swiftshader

Bug:  681136 
Change-Id: I74a53ae11edbd50fb69c95764a7c77dc54b473c1
Reviewed-on: https://chromium-review.googlesource.com/c/1318511
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605754}
[modify] https://crrev.com/2984928363b7f9d0920e5af850607ee53b5d46e7/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6df919a2cf624a75cc0bb1a232e62c1380ade160

commit 6df919a2cf624a75cc0bb1a232e62c1380ade160
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Tue Nov 06 20:55:34 2018

Remove the flag -Wno-unused-lambda-capture completely

Now this flag is unnecessary.

Bug:  681136 
Change-Id: I76d762a7d2d36b42a0556cfd4667731d79cbc01a
Reviewed-on: https://chromium-review.googlesource.com/c/1316949
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605816}
[modify] https://crrev.com/6df919a2cf624a75cc0bb1a232e62c1380ade160/build/config/compiler/BUILD.gn