New issue
Advanced search Search tips

Issue 681133 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

chrome://version cleanup

Project Member Reported by michae...@chromium.org, Jan 13 2017

Issue description

The chrome://version UI has a lot of OS-specific strings, but most of these strings are compiled into every platform.

There are also a few unused parts, like the build ID on Android which causes the Android chrome://version page to show a lone ":" at the bottom of the page.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff

commit dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff
Author: michaelpg <michaelpg@chromium.org>
Date: Sat Jan 28 04:10:56 2017

Clean up chrome://version page.

The version UI has a bunch of unused stuff and a bunch of per-platform strings
that are included on all platforms. Make it a little better.

BUG= 681133 
R=xiyuan@chromium.org,michaeldo@chromium.org,eugenebut@chromium.org

Review-Url: https://codereview.chromium.org/2626043007
Cr-Commit-Position: refs/heads/master@{#446905}

[modify] https://crrev.com/dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff/chrome/app/generated_resources.grd
[modify] https://crrev.com/dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff/chrome/browser/ui/webui/version_ui.cc
[modify] https://crrev.com/dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff/components/version_ui/resources/about_version.html
[modify] https://crrev.com/dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff/components/version_ui/resources/about_version.js
[modify] https://crrev.com/dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff/components/version_ui/version_ui_constants.cc
[modify] https://crrev.com/dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff/components/version_ui/version_ui_constants.h
[modify] https://crrev.com/dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/dcf341fef4994468f4ec8e384a8dcdc7ece9d3ff/ios/chrome/browser/ui/webui/version_ui.mm

Status: Fixed (was: Started)

Sign in to add a comment