New issue
Advanced search Search tips

Issue 681131 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Sync address_has_converted and card_billing_address_id through Chrome Sync.

Project Member Reported by se...@chromium.org, Jan 13 2017

Issue description

Add these two fields to the autofill_specifics.proto and add the appropriate login into autofill_wallet_metadata_syncable_service.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca7d5cf7a234e2f4d085b3be0781bfd0765c0130

commit ca7d5cf7a234e2f4d085b3be0781bfd0765c0130
Author: sebsg <sebsg@chromium.org>
Date: Wed Jan 18 18:38:58 2017

[Autofill] Sync new wallet metadata fields through Chrome Sync.

Sync the new has_converted field for wallet addresses metadata and the
new billing_address_id field for the wallet card metadata through
Chrome Sync.

BUG= 681131 

Review-Url: https://codereview.chromium.org/2626263005
Cr-Commit-Position: refs/heads/master@{#444423}

[modify] https://crrev.com/ca7d5cf7a234e2f4d085b3be0781bfd0765c0130/components/autofill/core/browser/autofill_profile.cc
[modify] https://crrev.com/ca7d5cf7a234e2f4d085b3be0781bfd0765c0130/components/autofill/core/browser/autofill_profile.h
[modify] https://crrev.com/ca7d5cf7a234e2f4d085b3be0781bfd0765c0130/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/ca7d5cf7a234e2f4d085b3be0781bfd0765c0130/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h
[modify] https://crrev.com/ca7d5cf7a234e2f4d085b3be0781bfd0765c0130/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc
[modify] https://crrev.com/ca7d5cf7a234e2f4d085b3be0781bfd0765c0130/components/sync/protocol/autofill_specifics.proto
[modify] https://crrev.com/ca7d5cf7a234e2f4d085b3be0781bfd0765c0130/components/sync/protocol/proto_visitors.h

Comment 2 by se...@chromium.org, Jan 18 2017

Status: Fixed (was: Started)

Comment 3 by se...@chromium.org, Feb 6 2017

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 6 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge your change to M57 branch 2987 before 5:00 PM PT, Tuesday (02/07/17) so we can pick it up for next Beta release. Thank you.

Comment 6 by se...@chromium.org, Feb 6 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-57
Removed merge request
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment