New issue
Advanced search Search tips

Issue 681115 link

Starred by 1 user
Status: Fixed
Owner:
fgor...@chromium.org
Closed: Jan 2017
Cc:
tedc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

OmniboxUrlEmphasizer is missing a case for HTTP_SHOW_WARNING in switch statement causing an assert in Debug builds

Project Member Reported by fgor...@chromium.org, Jan 13 2017 
OmniboxUrlEmphasizer is missing a case for HTTP_SHOW_WARNING in switch statement causing an assert in Debug builds

This does not affect official builds.

Repro (on ToT):
1. Navigate to HTTP page like: http://arched-memory-100.appspot.com/images/form.html
2. click on OIB
3. Observe crash

01-13 11:05:28.427: E/AndroidRuntime(6666): Process: org.chromium.chrome, PID: 6666
01-13 11:05:28.427: E/AndroidRuntime(6666): 	at org.chromium.chrome.browser.omnibox.OmniboxUrlEmphasizer.emphasizeUrl(OmniboxUrlEmphasizer.java:167)
01-13 11:05:28.427: E/AndroidRuntime(6666): 	at org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup.<init>(WebsiteSettingsPopup.java:393)
01-13 11:05:28.427: E/AndroidRuntime(6666): 	at org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup.show(WebsiteSettingsPopup.java:961)
01-13 11:05:28.427: E/AndroidRuntime(6666): 	at org.chromium.chrome.browser.omnibox.LocationBarLayout.onClick(LocationBarLayout.java:1918)
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91942aefbedd1909d0ab28a87bda8603ca99b87c

commit 91942aefbedd1909d0ab28a87bda8603ca99b87c
Author: fgorski <fgorski@chromium.org>
Date: Sat Jan 14 00:01:51 2017

[Android Omnibox] Fixing Emphasizer missing ConnectionSecurityLevel entry in switch

Adding a case statement for HTTP_SHOW_WARNING with a fall-through same
as for NONE per usage in LocationBarLayout.java

BUG= 681115 
R=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2629543011
Cr-Commit-Position: refs/heads/master@{#443733}

[modify] https://crrev.com/91942aefbedd1909d0ab28a87bda8603ca99b87c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java

Comment 2 by fgor...@chromium.org, Jan 17 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment