pre-upload enforcement of well-formed COMMIT-QUEUE.ini |
|||||||||||||
Issue descriptionFollow up on crbug.com/680185 It's annoying and difficult to determine if a COMMIT-QUEUE.ini file is well formatted. It could fail to be so either because of being malformed, or by requesting an non-existant pre-cq config. In either case, today's behavior is that the pre-cq-launcher will silently ignore the config and fallback to the defauly pre-cq set. This is hard to notice. Instead, we could add a pre-upload hook across all of chromeos repos that attempts to parse COMMIT-QUEUE.ini files (using the chromite code in the checkout; the same code that runs on the pre-cq-launcher) and fails if the file is malformed.
,
Jan 23 2017
,
Jan 27 2017
,
Jan 30 2017
I can't seem to find any support for a repo-checkout-wide presubmit hook (only apparently available on a repo-by-repo PRESUBMIT.py/PRESUBMIT.cfg basis. +vapier@ am I mistaken? Therefore, this might be a little beyond fixit scope.
,
Jan 30 2017
repohooks are repo wide: https://cs.corp.google.com/chromeos_internal/src/repohooks/?q=presubmit&sq=package:chromeos&dr=C
,
Jan 30 2017
putting it back, I think we can still do this.
,
Jan 30 2017
Nice. Ok, taking it.
,
Jan 30 2017
,
Jan 31 2017
repohooks are repo-wide. it has two sets of hooks: ones that we run all the time, and ones that are run only if PRESUBMIT.cfg requests it. i've been trying to move most hooks out to PRESUBMIT.cfg, but i think this is an acceptable use case for not being configurable.
,
Feb 2 2017
Fixed by https://chromium-review.googlesource.com/#/c/428351/
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by akes...@chromium.org
, Jan 13 2017