New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681100 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 680776
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

198.1% regression in blink_perf.canvas at 442934:443046

Project Member Reported by nzolghadr@chromium.org, Jan 13 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=681100

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgwP-XpwsM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 13 2017

Mergedinto: 680776
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : zakerinasab
  Commit : 7fb9535883e50ab0d7262ea8a0e8470934e57a9c
  Date   : Wed Jan 11 19:09:13 2017
  Subject: Implement color management for ImageData

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : blink_perf.canvas
  Metric       : toBlob_duration/toBlob_duration
  Change       : 222.85% | 235.934166667 -> 761.721166667

Revision             Result                  N
chromium@442934      235.934 +- 23.961       6      good
chromium@442962      234.211 +- 16.2345      6      good
chromium@442969      231.56 +- 22.8583       6      good
chromium@442971      234.403 +- 28.1872      6      good
chromium@442972      229.574 +- 12.4179      6      good
chromium@442973      854.001 +- 390.022      6      bad       <--
chromium@442976      829.071 +- 144.679      6      bad
chromium@442990      823.668 +- 181.549      6      bad
chromium@443046      761.721 +- 71.4103      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.canvas

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8990556534287259424

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5851063543922688


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Owner: zakerinasab@chromium.org
Status: Assigned (was: Duplicate)
Cc: sullivan@chromium.org
Status: Fixed (was: Assigned)
The issue has been addressed and the CL is landed again at commit position #443939.(https://codereview.chromium.org/2555213002). Here is the link to the Chrome perf graph showing that the regression is fixed:

https://chromeperf.appspot.com/report?sid=9e2ce666534535fe6fdeecb2ec8cd09bb237e7799bf4a04c5b9eafd66611a0fe&start_rev=442200&end_rev=444200

Sign in to add a comment