There have been a couple of cc unit tests failing with callback_count failures like this: I 2488.981s run_tests_on_device(0622a7e6003b8c5b) [ RUN ] TextureLayerImplWithMailboxThreadedCallback.RunMultiThread_DelegatingRenderer I 2488.982s run_tests_on_device(0622a7e6003b8c5b) ../../cc/layers/texture_layer_unittest.cc:721: Failure I 2488.982s run_tests_on_device(0622a7e6003b8c5b) Value of: callback_count_ I 2488.982s run_tests_on_device(0622a7e6003b8c5b) Actual: 1 I 2488.982s run_tests_on_device(0622a7e6003b8c5b) Expected: 2 I 2488.982s run_tests_on_device(0622a7e6003b8c5b) ../../cc/layers/texture_layer_unittest.cc:728: Failure I 2488.982s run_tests_on_device(0622a7e6003b8c5b) Value of: callback_count_ I 2488.982s run_tests_on_device(0622a7e6003b8c5b) Actual: 2 I 2488.982s run_tests_on_device(0622a7e6003b8c5b) Expected: 3 Failures: https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone Recent builds: https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone/builds/1578/steps/cc_unittests/logs/stdio https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone/builds/1580/steps/cc_unittests/logs/stdio Eric, Maybe your recent CL is related? https://codereview.chromium.org/2609253003 Please help triage.
Looks like this also flaked once on lollipop tablet: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/6478/steps/cc_unittests/logs/stdio
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b443521bc4bc46b4bd1537910f089fbf1578273 commit 4b443521bc4bc46b4bd1537910f089fbf1578273 Author: ericrk <ericrk@chromium.org> Date: Fri Jan 13 22:54:24 2017 Revert of Remove ForceReclaimResources (patchset #8 id:170001 of https://codereview.chromium.org/2609253003/ ) Reason for revert: This has introduced flakiness into TextureLayerImplWithMailboxThreadedCallback.RunMultiThread_DelegatingRenderer, will address this and re-land. Original issue's description: > Remove ForceReclaimResources > > We had previously added ForceReclaimResources to BeginCommit to throttle > frame output and prevent starving the display compositor's rasterization > tasks. Unfortunately, this introduces significant overhead as well. > > With the addition of the Display Scheduler, this change no longer > appears to be needed. The scheduler has independent controls for > limiting the number of pending frames, and these should be used instead > (if further tweaking is necessary). > > Removing this logic does not regress the benchmarks which it was > initially added for, and seems unneeded at this point. Removing. > > R=reveman@chromium.org > BUG=676852,489515, 617268 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2609253003 > Cr-Commit-Position: refs/heads/master@{#443061} > Committed: https://chromium.googlesource.com/chromium/src/+/dc1892fc0639464d4418ccfaedfd1f95a5b947d0 TBR=reveman@chromium.org,danakj@chromium.org,enne@chromium.org,tommi@chromium.org,brianderson@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=676852,489515, 617268 , 681093 , 680770 Review-Url: https://codereview.chromium.org/2633563003 Cr-Commit-Position: refs/heads/master@{#443709} [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/layers/texture_layer_unittest.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/output/compositor_frame_sink.h [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/direct_compositor_frame_sink.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/direct_compositor_frame_sink.h [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/direct_compositor_frame_sink_unittest.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface.h [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface_factory.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface_factory.h [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/layer_tree_pixel_test.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/layer_tree_test.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/test_compositor_frame_sink.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/test_compositor_frame_sink.h [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_pixeltest_tiles.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/content/renderer/gpu/render_widget_compositor.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/content/test/layouttest_support.cc [modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/ui/compositor/layer_unittest.cc
Comment 1 by donnd@chromium.org
, Jan 13 2017