New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681063 link

Starred by 25 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

GPU detection fails under Citrix remote session

Project Member Reported by georgesak@chromium.org, Jan 13 2017

Issue description

Chrome is unable to detect the vendor/device ID when running in a remote session under Citrix which blocks GPU acceleration. This is due to the fact that the device ID returned by EnumDisplayDevices is empty. However, the device name and device string are valid.

I tested this and got the following:

dd.DeviceID = ""
dd.DeviceName = "\\.\DISPLAY1"
dd.DeviceString = "Citrix Systems Inc. Display Driver"

Using the command line flag –ignore-gpu-blacklist overrides the blacklist and enables GPU acecleration.

I would like to remove the need for this override in such environment by detecting the video card and enabling the acceleration.

 
jbauman, I would like to modify CollectGpuID to look for that string and enable acceleration in that case, even if DeviceID is empty.

Are you ok with such a workaround? If so, I'll prepare the CL and send it your way.

Thanks.
One problem is that maybe the GPU being used should actually be blacklisted, but we have no way of knowing. Also it's unclear to me how Chrome's performance changes when using software vs. the GPU on citrix.
So the idea here was to enable acceleration when in a remote session and let the VM take care of either passing them through or emulating them, depending on the setup. 

That being said, that will probably be suboptimal in case the hardware acceleration is not enabled in the session. So I'm looking at figuring out on how we can detect that and only enable acceleration if it makes sense.

I'll update the thread once I have more info.

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7b6ddf8b2940d17dc8dd0feaffce5b33ecee785

commit e7b6ddf8b2940d17dc8dd0feaffce5b33ecee785
Author: georgesak <georgesak@chromium.org>
Date: Thu Feb 23 17:37:29 2017

Add workaround for GPU detection inside a Citrix remote session.

This CL extends the workaround to Citrix sessions (previously only pure RDP sessions were considered).

Note: I've tested this manually in our lab environment.

BUG= 681063 
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2698273004
Cr-Commit-Position: refs/heads/master@{#452538}

[modify] https://crrev.com/e7b6ddf8b2940d17dc8dd0feaffce5b33ecee785/gpu/config/gpu_info_collector_win.cc

Comment 5 by tnagel@chromium.org, Feb 28 2017

Labels: Enterprise-Triaged

Comment 6 by tnagel@chromium.org, Feb 28 2017

Components: Enterprise

Comment 7 by tnagel@chromium.org, Feb 28 2017

Components: -Enterprise>Triaged
Status: Fixed (was: Assigned)
Cc: pastarmovj@chromium.org georgesak@chromium.org zmo@chromium.org cyrusm@chromium.org apatrick@chromium.org scottmg@chromium.org luken@chromium.org wiltzius@chromium.org
 Issue 161476  has been merged into this issue.

Sign in to add a comment