New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681050 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 594639



Sign in to add a comment

Implement <script nomodule>

Project Member Reported by zcorpan@gmail.com, Jan 13 2017

Issue description

Discussion: https://github.com/whatwg/html/issues/1442.

Change: https://github.com/whatwg/html/pull/2261.

If for some reason we don't think this is a good idea now would be the time to object.
 

Comment 1 by adamk@chromium.org, Jan 13 2017

Cc: dominicc@chromium.org
Owner: kouhei@chromium.org
Status: Assigned (was: Untriaged)
I believe kouhei has this on his radar.

Comment 2 Deleted

Comment 3 by kouhei@chromium.org, Apr 14 2017

Cc: hirosh...@chromium.org module-dev@chromium.org kouhei@chromium.org
Owner: japhet@chromium.org
japhet: Would you be able to take this? Feel very free to push back.

Comment 4 by japhet@chromium.org, Apr 14 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85827883d6102e09951e13c14c8d383cd6e3833f

commit 85827883d6102e09951e13c14c8d383cd6e3833f
Author: japhet <japhet@chromium.org>
Date: Wed Apr 19 23:44:00 2017

Implement <script nomodule>

BUG= 681050 
TEST=external/wpt/html/semantics/scripting-1/the-script-element/nomodule-*

Review-Url: https://codereview.chromium.org/2824583002
Cr-Commit-Position: refs/heads/master@{#465811}

[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/LayoutTests/external/wpt/html/dom/reflection-misc-expected.txt
[delete] https://crrev.com/92c74fb30a1ccbb068b98f41d99fa0be53bf93de/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/nomodule-reflect-expected.txt
[delete] https://crrev.com/92c74fb30a1ccbb068b98f41d99fa0be53bf93de/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/nomodule-set-on-async-classic-script-expected.txt
[delete] https://crrev.com/92c74fb30a1ccbb068b98f41d99fa0be53bf93de/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/nomodule-set-on-inline-classic-scripts-expected.txt
[delete] https://crrev.com/92c74fb30a1ccbb068b98f41d99fa0be53bf93de/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/nomodule-set-on-synchronously-loaded-classic-scripts-expected.txt
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/Source/core/dom/MockScriptElementBase.h
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/Source/core/dom/ScriptElementBase.h
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/Source/core/dom/ScriptLoader.h
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/Source/core/html/HTMLScriptElement.h
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/Source/core/html/HTMLScriptElement.idl
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/85827883d6102e09951e13c14c8d383cd6e3833f/third_party/WebKit/Source/core/svg/SVGScriptElement.h

Comment 6 by japhet@chromium.org, Apr 20 2017

Status: Fixed (was: Started)
Landed on trunk behind the modules flag.

Sign in to add a comment