New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681046 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression

Blocking:
issue 79180



Sign in to add a comment

[css-grid] Newegg "cancel order" screen layout is too narrow

Project Member Reported by pdr@chromium.org, Jan 13 2017

Issue description

Chrome Version: 57.0.2970.0
OS: MacOS

What steps will reproduce the problem?
(1) Visit https://kb.newegg.com/search/getsearch/12/3?text=*&catid=1285&title=Ordering&fromwidget=true&widgetsearch=1
(2) Notice the text is all to the right and very narrow.

What is the expected result?
Readable text, like Firefox and Safari.
 

Comment 1 by hdodda@chromium.org, Jan 16 2017

Cc: hdodda@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable M-57 OS-Linux OS-Mac OS-Windows
Owner: r...@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good Build : 57.0.2928.0 (revision : 433845)
Bad Build : 57.0.2929.0 (revision : 434071)

You are probably looking for a change made after 433852 (known good), but no later than 433853 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
 
https://chromium.googlesource.com/chromium/src/+log/c11607a50691c6da823467bb389d14f659433c77..79bd413143afe5ad68104a3c99b9c04f64fc25ac

From the CL above, assigning the issue to the concern owner 

@rego - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2521953002

Note : As this is a recent regression , adding ReleaseBlock-Stable . Please feel free to edit/remove this.

Thanks!

Comment 2 by r...@igalia.com, Jan 16 2017

Blocking: 79180
Cc: svil...@igalia.com jfernan...@igalia.com
Components: -Blink>Layout Blink>Layout>Grid
Owner: r...@igalia.com
Summary: [css-grid] Newegg "cancel order" screen layout is too narrow (was: Newegg "cancel order" screen layout is too narrow)
I didn't investigate it deep enough, but the output is the very same if you have grid enabled on Firefox too.

The issue is that ".searchresultcontainer" is using "display: grid".
Changing it to "display: block" or "display: inline-grid" solves the issue.

I didn't investigate it further, not sure if it's worth or not.
But I'm not sure if they're using grid layout on purpose or not.
What should be the next steps?

Comment 3 by r...@igalia.com, Jan 16 2017

BTW, a very similar issue appears if you use "display: flex" instead of "display: grid".

Comment 4 by pdr@chromium.org, Jan 17 2017

Can you minimize this test and figure out why it's different in Chrome vs Firefox?

Comment 5 by pdr@chromium.org, Jan 17 2017

Status: WontFix (was: Assigned)
Sorry--I misunderstood (missed the part about enabling grid in firefox). I guess this should be closed as wontfix. I'll try to contact Newegg about this as well.

Comment 6 by pdr@chromium.org, Jan 17 2017

neweggcancelorder.png
94.6 KB View Download

Sign in to add a comment