Fix artwork comparison |
||||
Issue descriptionAs pointed by foolip on the intent to ship, we should fix the following tests: // the same value is returned every time (currently fails) assert_equals(metadata.artwork, metadata.artwork); // the setter makes a copy of the value artwork = []; metadata.artwork = artwork; assert_not_equals(metadata.artwork, artwork); // even assigning the same value changes it old_artwork = metadata.artwork metadata.artwork = metadata.artwork; assert_not_equals(metadata.artwork, old_artwork);
,
Jan 16 2017
Assigning to mlamouri@ to keep in radar. Maybe a won't fix though :)
,
Jan 16 2017
Thanks for assigning, that worked :) +foolip@. The reason why zqzhang@ said it is probably a wont fix is that `assert_equals(metadata.artwork, metadata.artwork)` should fail because we don't return the same object but a copy as requested per spec and AFAIK, `assert_equals` uses `===` to compare. Is there something I'm missing?
,
Jan 19 2017
Marking this as WontFix per previous comment. foolip@, can you reopen if I misunderstood the issue?
,
Feb 13 2017
I have filed https://github.com/WICG/mediasession/issues/183 but will leave this closed until that is resolved one way or the other.
,
Feb 13 2017
The way that would be implemented in Blink is probably [CachedAttribute=hasArtworkChanged], see navigator.language. |
||||
►
Sign in to add a comment |
||||
Comment 1 by zqzh...@chromium.org
, Jan 13 2017