ClickModifierTest.WindowOpenControlShiftClickTest is also flaky:

 https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/19997

ahest@: I saw that you recently land this CL https://codereview.chromium.org/2601843002 that touches the chrome/browser/ui/browser_browsertest.cc and seems to involve some changes on
load timing. Could you investigate to check if this flakiness on ClickModifierTest is due to the change?

If this is unrelated to your change, please help triage this bug and assign it to the appropriate owner. Thanks.

 Issue 681141  has been merged into this issue.

other platforms are also seeing flakiness. 

ClickModifierTest.WindowOpenControlShiftClickTest is also flaky.

 Issue 681154  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667

commit 0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667
Author: xlai <xlai@chromium.org>
Date: Fri Jan 13 21:18:06 2017

Revert of Convert more test helpers to base::RunLoop, fix page title checks. (patchset #5 id:80001 of https://codereview.chromium.org/2601843002/ )

Reason for revert:
ClickModifierTest.WindowOpenBasicClickTest and ClickModifierTest.WindowOpenControlShiftClickTest become very flaky recently. Example builds are all
recorded at  crbug.com/681035 .

By looking at the error log file (https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/19997/steps/browser_tests/logs/stdio), I notice that
the error comes from src\chrome\browser\ui\browser_browsertest.cc(2451) which is recently modified by this CL. Therefore the revert.

Original issue's description:
> Convert more test helpers to base::RunLoop, fix page title checks.
>
> This CL removes the "deferred quit" from most of the touched helpers.
>
> The exclusions are UrlCommitObserver and TestFrameNavigationObserver.
> They were already using immediate quit mode, so there is no change in
> their behavior, just cleanup.
>
> Regarding title checks in browser_browsertest.cc: in these tests there
> is no guarantee on when the new tab will start and stop loading. It
> can start loading after WindowedNotificationObserver::Wait returns; also
> it can stop loading while we're still inside it. We can explicitly wait
> for the title to handle all these cases, and this makes the call to
> WaitForLoadStop unnecessary.
>
>
> BUG=668707
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2601843002
> Cr-Commit-Position: refs/heads/master@{#443395}
> Committed: https://chromium.googlesource.com/chromium/src/+/e7469132628fa7bd530d68c134e4159d2cfc1804

TBR=nasko@chromium.org,pkasting@chromium.org,ahest@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668707, 681035 

Review-Url: https://codereview.chromium.org/2630683003
Cr-Commit-Position: refs/heads/master@{#443671}

[modify] https://crrev.com/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667/content/public/test/browser_test_base.cc
[modify] https://crrev.com/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667/content/public/test/browser_test_utils.h
[modify] https://crrev.com/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667/content/public/test/test_frame_navigation_observer.cc
[modify] https://crrev.com/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667/content/public/test/test_frame_navigation_observer.h
[modify] https://crrev.com/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667/content/public/test/test_utils.cc
[modify] https://crrev.com/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667/content/public/test/test_utils.h
[modify] https://crrev.com/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667/content/test/content_browser_test_utils_internal.cc
[modify] https://crrev.com/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667/content/test/content_browser_test_utils_internal.h

It's very likely that this is related to my CL, I'll investigate how it happens.

Detected 8 new flakes for test/step "ClickModifierTest.WindowOpenControlShiftClickTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFDbGlja01vZGlmaWVyVGVzdC5XaW5kb3dPcGVuQ29udHJvbFNoaWZ0Q2xpY2tUZXN0DA. This message was posted automatically by the chromium-try-flakes app.

Detected 8 new flakes for test/step "ClickModifierTest.WindowOpenBasicClickTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipDbGlja01vZGlmaWVyVGVzdC5XaW5kb3dPcGVuQmFzaWNDbGlja1Rlc3QM. This message was posted automatically by the chromium-try-flakes app.

This looks fixed (no new flakes since 13th)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29276c3a4db55690390a4a2c7d072f21cd7b34d9

commit 29276c3a4db55690390a4a2c7d072f21cd7b34d9
Author: ahest <ahest@yandex-team.ru>
Date: Thu Jan 19 07:36:31 2017

Convert more test helpers to base::RunLoop, fix page title checks. (Reland)

This CL removes the "deferred quit" from most of the touched helpers.

The exclusions are UrlCommitObserver and TestFrameNavigationObserver.
They were already using immediate quit mode, so there is no change in
their behavior, just cleanup.

This is a reland of https://codereview.chromium.org/2601843002. It
caused flakiness in a pair of ClickModifierTests, because I was wrong
when removed the WaitForLoadStop call. After that the TitleWatcher could
be created after the load start, but before the title arrives. In this
case WebContents::GetTitle basically returns the url, and TitleWatcher
was modified to simply return it.
Turns out that waiting this way (without specific expectations) for a
title can easily be done wrong, so I removed changes related to it.
These tests now use TestNavigationObserver, which should be robust
(unless there is some unrelated feature that can create WebContents at
a random time, which I believe is not the case in chromium browser tests).

The first patch set contains the original CL, the second one includes
the fix.

BUG=668707,  681035 

Review-Url: https://codereview.chromium.org/2635933003
Cr-Commit-Position: refs/heads/master@{#444674}

[modify] https://crrev.com/29276c3a4db55690390a4a2c7d072f21cd7b34d9/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/29276c3a4db55690390a4a2c7d072f21cd7b34d9/content/public/test/browser_test_base.cc
[modify] https://crrev.com/29276c3a4db55690390a4a2c7d072f21cd7b34d9/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/29276c3a4db55690390a4a2c7d072f21cd7b34d9/content/public/test/browser_test_utils.h
[modify] https://crrev.com/29276c3a4db55690390a4a2c7d072f21cd7b34d9/content/public/test/test_frame_navigation_observer.cc
[modify] https://crrev.com/29276c3a4db55690390a4a2c7d072f21cd7b34d9/content/public/test/test_frame_navigation_observer.h
[modify] https://crrev.com/29276c3a4db55690390a4a2c7d072f21cd7b34d9/content/public/test/test_utils.cc
[modify] https://crrev.com/29276c3a4db55690390a4a2c7d072f21cd7b34d9/content/public/test/test_utils.h
[modify] https://crrev.com/29276c3a4db55690390a4a2c7d072f21cd7b34d9/content/test/content_browser_test_utils_internal.cc
[modify] https://crrev.com/29276c3a4db55690390a4a2c7d072f21cd7b34d9/content/test/content_browser_test_utils_internal.h