Issue metadata
Sign in to add a comment
|
DidFinishNavigation not called with error state after cancelling navigation in InterceptNavigationThrottle::OnAsynchronousChecksPerformed |
||||||||||||||||||||||||
Issue description1.) Enable plznavigate on Android device 2.) Run UrlOverridingTest#testNavigationFromUserGesture Expected: The test passes and we get a signal about the navigation cancelled (i.e. errorcode is non-zero). Actual: The test fails due to lack of signal that the navigation is cancelled. The only finish navigation call received has no error indication of the cancelation. This differs a subframe was cancelled (i.e. running testNavigationFromUserGestureInSubFrame passed after adding plznavigate calls in the test). onDidFinishNavigation : mainFrame: true url: intent://test/#Intent;scheme=test;package=com.chrome.test;end error code: 0 error page: false committed: false page transition: null
,
Jan 13 2017
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54b81d6a37ba2a48bfd34bf42d954e4c8fe56d93 commit 54b81d6a37ba2a48bfd34bf42d954e4c8fe56d93 Author: clamy <clamy@chromium.org> Date: Wed Feb 08 17:48:09 2017 PlzNavigate: set the error code in NavigationHandle on abort This CL ensures that when a NavigationThrottle aborts a navigation, the rigth error code of net::ERR_ABORTED will be set on the NavigationHandle when PlzNavigate is enabled. BUG= 681029 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2657813004 Cr-Commit-Position: refs/heads/master@{#449030} [modify] https://crrev.com/54b81d6a37ba2a48bfd34bf42d954e4c8fe56d93/content/browser/frame_host/navigation_handle_impl_browsertest.cc [modify] https://crrev.com/54b81d6a37ba2a48bfd34bf42d954e4c8fe56d93/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/54b81d6a37ba2a48bfd34bf42d954e4c8fe56d93/extensions/browser/extension_navigation_throttle.cc
,
Feb 13 2017
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tedc...@chromium.org
, Jan 13 2017