Issue metadata
Sign in to add a comment
|
Regression: Dragging the Omnibox to hide the extension icons is broken / is overlapping the toolbar preferences icon |
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2980.0 canary (64-bit) OS: Mac OS 10.12.2 What steps will reproduce the problem? (1) Open a Chrome window; (2) Install some extensions, so that the icon is to see on the Toolbar; (3) Drag the right side of the Omnibox a little bit faster, to hide the extension icons. What is the expected result? What happens instead? Omnibox dragging should not overlap the toolbar preferences icon. Please use labels and text to provide additional information. A screencast is attached.
,
Jan 13 2017
,
Jan 17 2017
Using the per-revision bisect providing the bisect results, Good Build :57.0.2973.0 (revision :441616 ) Bad Build : 57.0.2974.0 (revision :441962 ) CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/5d044bb4fef05b493693b2d548352bc025f08d46..8b0fd02afc2107ba123774e0a464a43407a108cf Review-Url: https://codereview.chromium.org/2607533004
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae80f9c27eb768d8a53f780c16af4d024e454659 commit ae80f9c27eb768d8a53f780c16af4d024e454659 Author: sdy <sdy@chromium.org> Date: Thu Jan 19 21:29:34 2017 [Mac] Fix bugs in resizing the browser actions area next to the omnibox. - Consistently bounds-check the new width of the BrowserActionsContainerView during dragging. Fixes crbug/681004. - Don't trust -[NSEvent deltaX/deltaY], it's inaccurate over time: http://stackoverflow.com/q/30324935/84745 - Get rid of kMinimumContainerWidth and another magic number (3.0) in browser_actions_controller.mm, which were both slightly wrong. This fixes the 1px jump when you let go of the resizing handle at the minimum width. - Refactor and de-dupe. This fixes animation when you stop dragging in between icons. The new size was getting applied twice, which aborted the animation. BUG= 681004 TEST=On a Mac, install several extensions. - Try resizing the browser actions area. - Try resizing it quickly (by moving the mouse back and forth quickly) to make sure you can't make it bigger than it needs to be for the number of icons, and can't make it so small that the omnibox overlaps the wrench menu. - Make sure that, when you let go of the mouse button with the browser actions area fully open or closed, nothing changes (e.g. the omnibox doesn't grow or shrink by a pixel). - Make sure that, when you resize the browser actions area and let go with only some extension icons visible, it smoothly animates to a size that doesn't leave any icon partially visible. Review-Url: https://codereview.chromium.org/2629723005 Cr-Commit-Position: refs/heads/master@{#444847} [modify] https://crrev.com/ae80f9c27eb768d8a53f780c16af4d024e454659/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h [modify] https://crrev.com/ae80f9c27eb768d8a53f780c16af4d024e454659/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm [modify] https://crrev.com/ae80f9c27eb768d8a53f780c16af4d024e454659/chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm [modify] https://crrev.com/ae80f9c27eb768d8a53f780c16af4d024e454659/chrome/browser/ui/cocoa/extensions/browser_actions_controller.h [modify] https://crrev.com/ae80f9c27eb768d8a53f780c16af4d024e454659/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/ae80f9c27eb768d8a53f780c16af4d024e454659/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h [modify] https://crrev.com/ae80f9c27eb768d8a53f780c16af4d024e454659/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
,
Jan 19 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Jan 13 2017