New issue
Advanced search Search tips

Issue 680946 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Enable compiler warnings for authpolicy

Project Member Reported by tnagel@chromium.org, Jan 13 2017

Issue description

... to catch errors like  issue 680504 .
 

Comment 1 by tnagel@chromium.org, Jan 19 2017

Also build with -fstack-protector?
Owner: ljusten@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/46b1339a8e3bdacb64fe5e2ecff38b1f38716da8

commit 46b1339a8e3bdacb64fe5e2ecff38b1f38716da8
Author: Lutz Justen <ljusten@chromium.org>
Date: Sat Mar 25 02:38:01 2017

authpolicy: Add additional warning cflags

Adds warnings about unused variables, shadowed variables etc.
and fixes the compile errors it revealed (nothing serious, though).

BUG= chromium:680946 
TEST=Compiles

Change-Id: I8d4457c5c86b48560d99a5b00e8c44130f0107ae
Reviewed-on: https://chromium-review.googlesource.com/458658
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/46b1339a8e3bdacb64fe5e2ecff38b1f38716da8/authpolicy/authpolicy.gyp
[modify] https://crrev.com/46b1339a8e3bdacb64fe5e2ecff38b1f38716da8/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/46b1339a8e3bdacb64fe5e2ecff38b1f38716da8/authpolicy/authpolicy_main.cc
[modify] https://crrev.com/46b1339a8e3bdacb64fe5e2ecff38b1f38716da8/authpolicy/authpolicy_testrunner.cc
[modify] https://crrev.com/46b1339a8e3bdacb64fe5e2ecff38b1f38716da8/authpolicy/stub_kinit_main.cc
[modify] https://crrev.com/46b1339a8e3bdacb64fe5e2ecff38b1f38716da8/authpolicy/process_executor.h
[modify] https://crrev.com/46b1339a8e3bdacb64fe5e2ecff38b1f38716da8/authpolicy/authpolicy.cc
[modify] https://crrev.com/46b1339a8e3bdacb64fe5e2ecff38b1f38716da8/authpolicy/authpolicy_parser_main.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment