New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680938 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in v8::internal::MemoryChunk::heap

Project Member Reported by ClusterFuzz, Jan 13 2017

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5556368460480512

Fuzzer: v8_builtins_generator
Job Type: linux_asan_d8
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x00000b400038
Crash State:
  v8::internal::MemoryChunk::heap
  v8::internal::HeapObject::GetIsolate
  Handle
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: V8: r42266:42267

Minimized Testcase (0.08 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv95hpIrwbhkHFvzHsn6zrlaosk54zL5MAKc6f6Efpbeu3vaONcQO7xdqdY8sjlnkLCEZfDRhS0V_ranUdUqv3r3YrKbPvgxOrtYb27SX_C7YNHx9fTMdulgNOmCJSu_P2fQp_uMly7qowB_tml87Uo90phIwbu-OSU28tUHpJHIiY_3wafcQXbfzEGOQjGvQq6_bIC_T0gl1I-TTER6ra1JEnxJA1RspHKczU7duYXhx8mynH0xgEfqDyX4b8roT1LmVtDA2MhIf0VHW8w-BB_wlfduSZnLXZh5rFElr-wGfOYLAqJ-QfBdGW2IJosIaV3nDj_yTE0QBwV0yoTsWqDaP-TWNcHSm-uK1kLfFHSZA6CImgJu116Z17WiN8CpmdGpQWcDZmWn8aSSEg7Ikkim2ASS9zg?testcase_id=5556368460480512
var v17 = {};
var v32 = {};
 v39 = new WebAssembly.Memory(v32); 
 v49 = v39.grow(v17); 


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jan 13 2017

Labels: M-57
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 13 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 13 2017

Labels: Pri-1

Comment 4 by ishell@chromium.org, Jan 13 2017

 Issue 680960  has been merged into this issue.

Comment 5 by ishell@chromium.org, Jan 13 2017

Cc: clemensh@chromium.org bradnelson@chromium.org ahaas@chromium.org rossberg@chromium.org
Owner: titzer@chromium.org
Status: Assigned (was: Untriaged)
Another crash caused by enabled Wasm (9884fb91e15e5e85218886b67af410668a08c38b).

Comment 6 by titzer@chromium.org, Jan 16 2017

Cc: -rossberg@chromium.org -clemensh@chromium.org titzer@chromium.org
Components: -Blink>JavaScript Blink>JavaScript>WebAssembly
Owner: gdeepti@chromium.org
This bug happens because WebAssembly.Memory.grow() doesn't handle the case where there is no instance associated with the memory.

Comment 7 by titzer@chromium.org, Jan 16 2017

Cc: rossberg@chromium.org clemensh@chromium.org
 Issue 680870  has been merged into this issue.

Comment 8 by titzer@chromium.org, Jan 17 2017

 Issue 680506  has been merged into this issue.
Labels: Hotlist-Asm
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6934db7ca7777db0799ec76b3fae811734e3c5c2

commit 6934db7ca7777db0799ec76b3fae811734e3c5c2
Author: gdeepti <gdeepti@chromium.org>
Date: Wed Jan 18 04:45:07 2017

[wasm] WebAssembly.Memory.grow() should handle the no instance case
 - Currently WebAssembly.Memory.grow() assumes that it always has an instance associated with it,
 fix to grow and reflect new size when no instance is associated with memory object.
 - Correctness fixes for the js api, throw range errors instead of generic errors

BUG= chromium:680938 

R=bradnelson@chromium.org, titzer@chromium.org

Review-Url: https://codereview.chromium.org/2638243002
Cr-Commit-Position: refs/heads/master@{#42432}

[modify] https://crrev.com/6934db7ca7777db0799ec76b3fae811734e3c5c2/src/wasm/wasm-js.cc
[modify] https://crrev.com/6934db7ca7777db0799ec76b3fae811734e3c5c2/src/wasm/wasm-module.cc
[modify] https://crrev.com/6934db7ca7777db0799ec76b3fae811734e3c5c2/src/wasm/wasm-module.h
[add] https://crrev.com/6934db7ca7777db0799ec76b3fae811734e3c5c2/test/mjsunit/regress/wasm/regression-680938.js
[modify] https://crrev.com/6934db7ca7777db0799ec76b3fae811734e3c5c2/test/mjsunit/wasm/js-api.js
[modify] https://crrev.com/6934db7ca7777db0799ec76b3fae811734e3c5c2/test/mjsunit/wasm/memory.js

Project Member

Comment 11 by ClusterFuzz, Jan 18 2017

ClusterFuzz has detected this issue as fixed in range 42431:42432.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5556368460480512

Fuzzer: v8_builtins_generator
Job Type: linux_asan_d8
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x00000b400038
Crash State:
  v8::internal::MemoryChunk::heap
  v8::internal::HeapObject::GetIsolate
  Handle
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: V8: r42266:42267
Fixed: V8: r42431:42432

Minimized Testcase (0.08 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv95hpIrwbhkHFvzHsn6zrlaosk54zL5MAKc6f6Efpbeu3vaONcQO7xdqdY8sjlnkLCEZfDRhS0V_ranUdUqv3r3YrKbPvgxOrtYb27SX_C7YNHx9fTMdulgNOmCJSu_P2fQp_uMly7qowB_tml87Uo90phIwbu-OSU28tUHpJHIiY_3wafcQXbfzEGOQjGvQq6_bIC_T0gl1I-TTER6ra1JEnxJA1RspHKczU7duYXhx8mynH0xgEfqDyX4b8roT1LmVtDA2MhIf0VHW8w-BB_wlfduSZnLXZh5rFElr-wGfOYLAqJ-QfBdGW2IJosIaV3nDj_yTE0QBwV0yoTsWqDaP-TWNcHSm-uK1kLfFHSZA6CImgJu116Z17WiN8CpmdGpQWcDZmWn8aSSEg7Ikkim2ASS9zg?testcase_id=5556368460480512
var v17 = {};
var v32 = {};
 v39 = new WebAssembly.Memory(v32); 
 v49 = v39.grow(v17); 


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Jan 18 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5556368460480512 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by sheriffbot@chromium.org, Jan 18 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: merge-review-5.7
This is not on the 5.7 branch. Please merge to 5.7 when you have Canary coverage.
Cc: ishell@chromium.org hablich@chromium.org gdeepti@chromium.org jkummerow@chromium.org
 Issue 679947  has been merged into this issue.
Labels: -Hotlist-Asm Hotlist-Wasm
Labels: -ReleaseBlock-Beta
Labels: -merge-review-5.7
Project Member

Comment 20 by sheriffbot@chromium.org, Apr 26 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment