New issue
Advanced search Search tips

Issue 680930 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Remove legacy code in CRWContextMenuController

Project Member Reported by olivierrobin@chromium.org, Jan 13 2017

Issue description

Some code refer to old versions of iOS (->iOS4.X).
Cleanup the legacy code.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44fccdc3a9d6879d4cba838106cae466373475cc

commit 44fccdc3a9d6879d4cba838106cae466373475cc
Author: olivierrobin <olivierrobin@chromium.org>
Date: Wed Jan 18 09:52:44 2017

Clean the new CRWContextMenuController

- Switch to ARC
- Remove legacy code that detected system gesture recognizers on web
  views.
- Extract the NSDictionary -> ContextMenuParams logic and add unittests.

Note: egtests are already available in context_menu_egtests.

BUG= 680930 

Review-Url: https://codereview.chromium.org/2640433002
Cr-Commit-Position: refs/heads/master@{#444318}

[modify] https://crrev.com/44fccdc3a9d6879d4cba838106cae466373475cc/ios/web/BUILD.gn
[add] https://crrev.com/44fccdc3a9d6879d4cba838106cae466373475cc/ios/web/web_state/context_menu_params_utils.h
[add] https://crrev.com/44fccdc3a9d6879d4cba838106cae466373475cc/ios/web/web_state/context_menu_params_utils.mm
[add] https://crrev.com/44fccdc3a9d6879d4cba838106cae466373475cc/ios/web/web_state/context_menu_params_utils_unittest.mm
[modify] https://crrev.com/44fccdc3a9d6879d4cba838106cae466373475cc/ios/web/web_state/ui/crw_context_menu_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment